Page MenuHomePhorge

Fix call to undefined HarbormasterBuildMessageRestartTransaction::isFailed()
Needs ReviewPublic

Authored by aklapper on Jul 27 2024, 11:21.

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Summary

The method HarbormasterBuildMessageRestartTransaction::isFailed() does not exist.

While there is a variety of classes that offer a public isFailed() method (HarbormasterBuildStatus, HarbormasterBuildableStatus, HarbormasterBuild, HarbormasterBuildTarget) which could have been meant instead (the git history provides no hints as this code has always been broken), the error message explicitly refers to a Build. Thus replace !$this->isFailed() with !$build->isFailed().

Test Plan

Run static code analysis; Read/grep the code.

Diff Detail

Repository
rP Phorge
Branch
harborBuildIsFailed
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1461
Build 1461: arc lint + arc unit