Rephrase comment

In D25450#12945, @speck wrote:

Maybe add some doc - the view and edit actions being lumped together are because it would be a larger change to split out that functionality right now, correct?

Show 404 error instead of policy based message

However, it would make sense not to query transactions in applications which once were installed and are now uninstalled and not accessible anymore anyway.
In downstream https://phabricator.wikimedia.org/T344232 , the exception is Query (of class "ConpherenceTransactionQuery") overheated.
However we uninstalled Conpherence more than four years ago in https://phabricator.wikimedia.org/T127640 (but of course the DB data is still around).

I am sorry, thanks for your last comment, I now understand your point. Yes, I guess we'd better return new Aphront404Response() instead of some permission based message. Like we'd do trying to access the URL of an uninstalled application. Now just need to find out how to do that :)

In D25452#12901, @speck wrote:

I’m guessing the user would be unable to remove their contact number (or even see it), unless turning off sms deletes their contact number. In this case I think the user would still want to know it’s saved somewhere and could remove it.

make linter happy

Note that this patch does NOT default to admin as proposed in T15443#9918 as I could imagine confusion by overwriting that value on existing installations. Happy to adjust though...

In P13#202, @smith wrote:

Shouldn't Create and Edit be lowercase?

@valerio.bozzolan: I've lost track a bit given the latest comments. Shall I commit the accepted version, or are changes required?

Where to find the test plan? (And is expanding a hard requirement to get this reviewed?)

After applying this patch locally, after selecting Import .ics file, I can confirm that /calendar/import/edit/ does not show an URI field anymore, and that selecting an ICS File and importing it successfully creates calendar/import/8/ with expected name, date, and time.

It's a Git repository branch called 201709 (see downstream) but still no idea how to trigger the exception.
If anyone has an idea what to do to reach code in DiffusionRequest::generateURI() or DiffusionCommitBranchesController, please share.

See e.g. https://www.law.cornell.edu/wex/release why to "license under" instead of "release in"

Public contents are released in Creative Commons Attribution-ShareAlike 4.0.

Abandoning per last comment; guess we should debug a bit more first in downstream to understand the root cause better

Not sure how to proceed here, this abandoning for now

In T15640#13668, @valerio.bozzolan wrote:

Are you aware of any non-git repository in Wikimedia?

Makes sense; let's close for now. (I need to get used to Conduit throwing exceptions into our server log for random broken input. I do not like that Conduit behavior.)

Looks like this created a regression: T15639: Exception: Value passed to "phutil_string_cast()" is an array in PhabricatorApplicationSearchEngine.php

Fixed my dirty tree, sorry

In theory this could be a two-liner: Changing the last character of the $prefix, and in PhabricatorCursorPagedPolicyAwareQuery.php

- $map[$field->getFieldKey()] = $field->getValueForStorage();
+ $map[$field->getModernFieldKey()] = $field->getValueForStorage();

In practice that leads to: Unhandled Exception ("PhutilTypeExtraParametersException") - Got unexpected parameters: customfield, customfield.index.table, customfield.index.key

<tl;dr>: This is a mismatch between legacy field keys still used for paging, versus modern field keys.