Add Phorge icon to auth/login PNG files.
Closes T15403
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15403: Fix "Amazon" icon on Phorge OAuth
- Commits
- rP8e6bb9b6903c: Correct Phorge icon on Auth Provider page
Go to /auth/config/new/ in browser and look at icons.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- amazorge (branched from master)
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 561 Build 561: arc lint + arc unit
Event Timeline
Comment Actions
I have no idea how to create the hash value in resources/sprite/manifest/login.json. Probably there's some magic commands to do all of this. While I created the CSS etc manually.
| resources/sprite/manifest/login.json | ||
|---|---|---|
| 74–78 | Interestingly, probably this script is related: ./scripts/celerity/generate_sprites.php I discovered that since I played with git blame on this file and found this commit that mentions that: | |
Comment Actions
yeah, ./scripts/celerity/generate_sprites.php. It will also generate the sprite files (and after that, bin/celerity map)
Comment Actions
Thanks! Used PNG images from T15478; then ran ./bin/celerity sprites (which replaced ./scripts/celerity/generate_sprites.php)
Comment Actions
Tested, thanks!
I approve this one also because the mere idea of receiving a fine from Amazon for calling it "Phorge" scares me on a molecular level ihih
