Page MenuHomePhorge
Differential D25255

Correct Phorge icon on Auth Provider page
ClosedPublic
Actions

Authored by aklapper on May 28 2023, 14:51.
Tags
None
Referenced Files
F4102777: D25255.1746899813.diff
Fri, May 9, 17:56
F4046169: D25255.1746737391.diff
Wed, May 7, 20:49
F4046165: D25255.1746737358.diff
Wed, May 7, 20:49
F4045338: D25255.1746732790.diff
Wed, May 7, 19:33
F4021432: D25255.1746667788.diff
Wed, May 7, 01:29
F4014028: D25255.1746630822.diff
Tue, May 6, 15:13
F3973646: D25255.1746533333.diff
Mon, May 5, 12:08
F3969869: D25255.1746524075.diff
Mon, May 5, 09:34
View All 49 Files
Subscribers
avivey
Cigaryno
Matthew
speck
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15403: Fix "Amazon" icon on Phorge OAuth
Commits
rP8e6bb9b6903c: Correct Phorge icon on Auth Provider page
Summary

Add Phorge icon to auth/login PNG files.

Closes T15403

Test Plan

Go to /auth/config/new/ in browser and look at icons.

Diff Detail

Repository
rP Phorge
Branch
amazorge (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 561
Build 561: arc lint + arc unit

Event Timeline

aklapper created this revision.May 28 2023, 14:51
Owners added a reviewer: O1: Blessed Committers.May 28 2023, 14:51
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 28 2023, 14:51
aklapper requested review of this revision.May 28 2023, 14:51
Harbormaster completed remote builds in B473: Diff 829.May 28 2023, 14:51
aklapper added a comment.May 28 2023, 14:53

I have no idea how to create the hash value in resources/sprite/manifest/login.json. Probably there's some magic commands to do all of this. While I created the CSS etc manually.

valerio.bozzolan added inline comments.May 28 2023, 16:28
resources/sprite/manifest/login.json
74–78

Interestingly, probably this script is related:

./scripts/celerity/generate_sprites.php

I discovered that since I played with git blame on this file and found this commit that mentions that:

23d192cb3ddefa5f69d94640ac3ce96a466ccc0e

avivey subscribed.May 28 2023, 18:19

yeah, ./scripts/celerity/generate_sprites.php. It will also generate the sprite files (and after that, bin/celerity map)

aklapper updated this revision to Diff 880.Jun 3 2023, 11:18

Ran ./scripts/celerity/generate_sprites.php and ./bin/celerity map

Harbormaster completed remote builds in B506: Diff 880.Jun 3 2023, 11:18
aklapper mentioned this in Z5: Phorge (flame).Jun 14 2023, 21:00
valerio.bozzolan added a comment.Jun 15 2023, 06:38

I asked for help to make a vector of that logo and render it x2 without grainy

valerio.bozzolan added a comment.Jun 15 2023, 07:02

Hoping to be useful here some useful materials exactly at 28x28 and 56x56:

T15478: Graphical Kit

aklapper updated this revision to Diff 966.Jun 15 2023, 08:35

Thanks! Used PNG images from T15478; then ran ./bin/celerity sprites (which replaced ./scripts/celerity/generate_sprites.php)

Harbormaster completed remote builds in B561: Diff 966.Jun 15 2023, 08:35
valerio.bozzolan accepted this revision.Jun 15 2023, 09:35

Tested, thanks!

I approve this one also because the mere idea of receiving a fine from Amazon for calling it "Phorge" scares me on a molecular level ihih

lgtm

This revision is now accepted and ready to land.Jun 15 2023, 09:35
Closed by commit rP8e6bb9b6903c: Correct Phorge icon on Auth Provider page. · Explain WhyJun 15 2023, 10:02
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rP8e6bb9b6903c: Correct Phorge icon on Auth Provider page.

Revision Contents
Changeset List

Diff 966

View Options

resources/celerity/map.php

Show All 37 Lines public function setIcon($icon) {
$this->icon = $icon; $this->icon = $icon;
return $this; return $this;
} }
public function getIcon() { public function getIcon() {
return $this->icon; return $this->icon;
} }
/**
* Set the text of the tag
*
* This is usually the 'name' key of your subtype map.
* Sometime this is an uppercase text like 'BUG' for a 'bug' subtype name.
*
* @param string|null $text
* @return self
*/
public function setTagText($text) { public function setTagText($text) {
$this->tagText = $text; $this->tagText = $text;
return $this; return $this;
} }
/**
* Get the text of the tag
*
* @see PhabricatorEditEngineSubtype::setTagText()
*
* @return string|null
*/
public function getTagText() { public function getTagText() {
return $this->tagText; return $this->tagText;
} }
public function setColor($color) { public function setColor($color) {
$this->color = $color; $this->color = $color;
return $this; return $this;
} }
Show All 25 Lines public function setMutations($mutations) {
return $this; return $this;
} }
public function getMutations() { public function getMutations() {
return $this->mutations; return $this->mutations;
} }
public function hasTagView() { public function hasTagView() {
return (bool)strlen($this->getTagText()); return phutil_nonempty_string($this->getTagText());
valerio.bozzolanUnsubmitted
Done
Inline Actions

✅ The only usage of setTagText() seems to be in PhabricatorEditEngineSubtype and the input domain is just a string coming from phutil_utf8_strtoupper() (like "BUG") or null (default). The phutil_nonempty_string() will report alien values and this is OK.

Also, the method was returning a bool, and it still returns a bool.

valerio.bozzolan: ✅ The only usage of `setTagText()` seems to be in `PhabricatorEditEngineSubtype` and the input…
} }
public function newTagView() { public function newTagView() {
$view = id(new PHUITagView()) $view = id(new PHUITagView())
->setType(PHUITagView::TYPE_OUTLINE) ->setType(PHUITagView::TYPE_OUTLINE)
->setName($this->getTagText()); ->setName($this->getTagText());
$color = $this->getColor(); $color = $this->getColor();
▲ Show 20 Lines • Show All 217 Lines • Show Last 20 Lines
View Options

resources/sprite/login_1x/Phorge.png

Show All 37 Lines public function setIcon($icon) {
$this->icon = $icon; $this->icon = $icon;
return $this; return $this;
} }
public function getIcon() { public function getIcon() {
return $this->icon; return $this->icon;
} }
/**
* Set the text of the tag
*
* This is usually the 'name' key of your subtype map.
* Sometime this is an uppercase text like 'BUG' for a 'bug' subtype name.
*
* @param string|null $text
* @return self
*/
public function setTagText($text) { public function setTagText($text) {
$this->tagText = $text; $this->tagText = $text;
return $this; return $this;
} }
/**
* Get the text of the tag
*
* @see PhabricatorEditEngineSubtype::setTagText()
*
* @return string|null
*/
public function getTagText() { public function getTagText() {
return $this->tagText; return $this->tagText;
} }
public function setColor($color) { public function setColor($color) {
$this->color = $color; $this->color = $color;
return $this; return $this;
} }
Show All 25 Lines public function setMutations($mutations) {
return $this; return $this;
} }
public function getMutations() { public function getMutations() {
return $this->mutations; return $this->mutations;
} }
public function hasTagView() { public function hasTagView() {
return (bool)strlen($this->getTagText()); return phutil_nonempty_string($this->getTagText());
valerio.bozzolanUnsubmitted
Done
Inline Actions

✅ The only usage of setTagText() seems to be in PhabricatorEditEngineSubtype and the input domain is just a string coming from phutil_utf8_strtoupper() (like "BUG") or null (default). The phutil_nonempty_string() will report alien values and this is OK.

Also, the method was returning a bool, and it still returns a bool.

valerio.bozzolan: ✅ The only usage of `setTagText()` seems to be in `PhabricatorEditEngineSubtype` and the input…
} }
public function newTagView() { public function newTagView() {
$view = id(new PHUITagView()) $view = id(new PHUITagView())
->setType(PHUITagView::TYPE_OUTLINE) ->setType(PHUITagView::TYPE_OUTLINE)
->setName($this->getTagText()); ->setName($this->getTagText());
$color = $this->getColor(); $color = $this->getColor();
▲ Show 20 Lines • Show All 217 Lines • Show Last 20 Lines
View Options

resources/sprite/login_2x/Phorge.png

Show All 37 Lines public function setIcon($icon) {
$this->icon = $icon; $this->icon = $icon;
return $this; return $this;
} }
public function getIcon() { public function getIcon() {
return $this->icon; return $this->icon;
} }
/**
* Set the text of the tag
*
* This is usually the 'name' key of your subtype map.
* Sometime this is an uppercase text like 'BUG' for a 'bug' subtype name.
*
* @param string|null $text
* @return self
*/
public function setTagText($text) { public function setTagText($text) {
$this->tagText = $text; $this->tagText = $text;
return $this; return $this;
} }
/**
* Get the text of the tag
*
* @see PhabricatorEditEngineSubtype::setTagText()
*
* @return string|null
*/
public function getTagText() { public function getTagText() {
return $this->tagText; return $this->tagText;
} }
public function setColor($color) { public function setColor($color) {
$this->color = $color; $this->color = $color;
return $this; return $this;
} }
Show All 25 Lines public function setMutations($mutations) {
return $this; return $this;
} }
public function getMutations() { public function getMutations() {
return $this->mutations; return $this->mutations;
} }
public function hasTagView() { public function hasTagView() {
return (bool)strlen($this->getTagText()); return phutil_nonempty_string($this->getTagText());
valerio.bozzolanUnsubmitted
Done
Inline Actions

✅ The only usage of setTagText() seems to be in PhabricatorEditEngineSubtype and the input domain is just a string coming from phutil_utf8_strtoupper() (like "BUG") or null (default). The phutil_nonempty_string() will report alien values and this is OK.

Also, the method was returning a bool, and it still returns a bool.

valerio.bozzolan: ✅ The only usage of `setTagText()` seems to be in `PhabricatorEditEngineSubtype` and the input…
} }
public function newTagView() { public function newTagView() {
$view = id(new PHUITagView()) $view = id(new PHUITagView())
->setType(PHUITagView::TYPE_OUTLINE) ->setType(PHUITagView::TYPE_OUTLINE)
->setName($this->getTagText()); ->setName($this->getTagText());
$color = $this->getColor(); $color = $this->getColor();
▲ Show 20 Lines • Show All 217 Lines • Show Last 20 Lines
View Options

resources/sprite/manifest/login.json

Show All 37 Lines public function setIcon($icon) {
$this->icon = $icon; $this->icon = $icon;
return $this; return $this;
} }
public function getIcon() { public function getIcon() {
return $this->icon; return $this->icon;
} }
/**
* Set the text of the tag
*
* This is usually the 'name' key of your subtype map.
* Sometime this is an uppercase text like 'BUG' for a 'bug' subtype name.
*
* @param string|null $text
* @return self
*/
public function setTagText($text) { public function setTagText($text) {
$this->tagText = $text; $this->tagText = $text;
return $this; return $this;
} }
/**
* Get the text of the tag
*
* @see PhabricatorEditEngineSubtype::setTagText()
*
* @return string|null
*/
public function getTagText() { public function getTagText() {
return $this->tagText; return $this->tagText;
} }
public function setColor($color) { public function setColor($color) {
$this->color = $color; $this->color = $color;
return $this; return $this;
} }
Show All 25 Lines public function setMutations($mutations) {
return $this; return $this;
} }
public function getMutations() { public function getMutations() {
return $this->mutations; return $this->mutations;
} }
public function hasTagView() { public function hasTagView() {
return (bool)strlen($this->getTagText()); return phutil_nonempty_string($this->getTagText());
valerio.bozzolanUnsubmitted
Done
Inline Actions

✅ The only usage of setTagText() seems to be in PhabricatorEditEngineSubtype and the input domain is just a string coming from phutil_utf8_strtoupper() (like "BUG") or null (default). The phutil_nonempty_string() will report alien values and this is OK.

Also, the method was returning a bool, and it still returns a bool.

valerio.bozzolan: ✅ The only usage of `setTagText()` seems to be in `PhabricatorEditEngineSubtype` and the input…
} }
public function newTagView() { public function newTagView() {
$view = id(new PHUITagView()) $view = id(new PHUITagView())
->setType(PHUITagView::TYPE_OUTLINE) ->setType(PHUITagView::TYPE_OUTLINE)
->setName($this->getTagText()); ->setName($this->getTagText());
$color = $this->getColor(); $color = $this->getColor();
▲ Show 20 Lines • Show All 217 Lines • Show Last 20 Lines
View Options

webroot/rsrc/css/sprite-login.css

Loading...
View Options

webroot/rsrc/image/sprite-login-X2.png

Loading...
View Options

webroot/rsrc/image/sprite-login.png

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0