Add Phorge icon to auth/login PNG files.
Closes T15403
Paths
| Differential D25255 Authored by aklapper on May 28 2023, 14:51.
Tags None Referenced Files
Details
Summary Add Phorge icon to auth/login PNG files. Closes T15403 Test Plan Go to /auth/config/new/ in browser and look at icons.
Diff Detail
Event TimelineHerald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptMay 28 2023, 14:512023-05-28 14:51:21 (UTC+0) Harbormaster completed remote builds in B473: Diff 829.May 28 2023, 14:512023-05-28 14:51:23 (UTC+0) Comment Actions I have no idea how to create the hash value in resources/sprite/manifest/login.json. Probably there's some magic commands to do all of this. While I created the CSS etc manually.
Comment Actions yeah, ./scripts/celerity/generate_sprites.php. It will also generate the sprite files (and after that, bin/celerity map) Comment Actions Thanks! Used PNG images from T15478; then ran ./bin/celerity sprites (which replaced ./scripts/celerity/generate_sprites.php) Harbormaster completed remote builds in B561: Diff 966.Jun 15 2023, 08:352023-06-15 08:35:31 (UTC+0) Comment Actions Tested, thanks! I approve this one also because the mere idea of receiving a fine from Amazon for calling it "Phorge" scares me on a molecular level ihih This revision is now accepted and ready to land.Jun 15 2023, 09:352023-06-15 09:35:56 (UTC+0) Closed by commit rP8e6bb9b6903c: Correct Phorge icon on Auth Provider page. · Explain WhyJun 15 2023, 10:022023-06-15 10:02:53 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 966 resources/celerity/map.php
resources/sprite/login_1x/Phorge.png
resources/sprite/login_2x/Phorge.png
resources/sprite/manifest/login.json
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0 |
✅ The only usage of setTagText() seems to be in PhabricatorEditEngineSubtype and the input domain is just a string coming from phutil_utf8_strtoupper() (like "BUG") or null (default). The phutil_nonempty_string() will report alien values and this is OK.
Also, the method was returning a bool, and it still returns a bool.