Regression from rP9448e815721c882196b8c541560270734574af8e.
Closes T15985
Details
Details
- Reviewers
mturdus avivey - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15985: Fix UX regression in Phame
- Commits
- rP12991c0d377a: Fix overlapping elements in Phame for >1791px width
For both a viewport width >1791px and below,
- Go to the Phriction wiki page http://phorge.localhost/w/blah which has sections so a table of contents is displayed
- Go to http://phorge.localhost/phame/ and with no blogs visible to the current user or no existing blogposts
- Go to http://phorge.localhost/phame/ with existing/visible blogposts, see no overlap of horizontal lines and Blogs box
- Go to an empty blog at http://phorge.localhost/phame/blog/view/4/
- Go to an existing blogpost at http://phorge.localhost/phame/post/view/1/whatever/
- Go to an existing blogpost at http://phorge.localhost/phame/post/view/1/whatever/ which includes a full width image via {F1234,size=full}
- Go to http://phorge.localhost/book/phorge/article/remarkup/
- Go to http://phorge.localhost/w/
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- arcpatch-D25873
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 1712 Build 1712: arc lint + arc unit
Event Timeline
Comment Actions
Fix unaligned elements by changing margin-left: -200px to -300px for div.phui-document-content and for full-size images, and by bumping max-width: 980px; to now 1280px for .phame-home-view .phame-home-container to avoid element overlapping
Comment Actions
I expanded the test plan a bit, still if there is more to add please also expand. This seems to work for me (phamous last words)
Comment Actions
Thanks for this patch! Kind reminder: if you touched CSS or JavaScript, please remember to also run this:
./bin/celerity map
⚙️ Thanks! Bip bop I'm a bot - helping for T15209