Page MenuHomePhorge

Fix Dark Mode theme color issues in several places
Needs ReviewPublic

Authored by mturdus on Jul 6 2024, 15:26.

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15056: Improve Dark Mode
Summary
  • Conpherence: date/timestamp is hard to read
  • Custom policy editor: fixed white background
  • Differential: diffs are hard to read
  • Diffusion: active commits screen is using some different blue as other dialogs
  • Account email settings: fixed white background
  • PHP exception logging: stack trace or errors are not readable
  • Setup issues menu: fixed white background when hovering over menu items
  • Navigation menu: background of selected menu item and hovered menu items hardly visible
  • Pholio: when using a transparent image the transparent background is white instead of a dark color.
  • Project workboards: when transferring tasks to another column so white fixed background is visible

Screenshots are available in T15056

Ref T15056

Test Plan
  • bin/celerity map
  • bin/cache purge --all
  • bin/phd restart
  • Sign in
  • Go to user's Settings > Display Preferences and select the Accessibility (user interface) "Dark Mode".
  • Go to Conpherence, join a room and check if date/timestamp is readable in this chat
  • Go to Phriction, select Edit Document, Open the "Visible To - Users" dropdown, select Custom Policy, check if dialog is readable
  • Go to Differential, select some diff, check if the diff changes at the bottom of the screen are readable
  • Go to Account Settings, click Email Addresses. Check if screen is readable
  • Simulate a PHP crash and check if the PHP error/stacktrace is readable in Phorge.
    • To simulate a crash, add this PHP file in your src/extensions directory, restart httpd and browse to <phorge>/conduit/query/all:
crash.php
<?php
final class Crash extends ConduitAPIMethod {
  public function getAPIMethodName() {
    throw new Exception("This is a custom exception");
    return 'crash';
  }
  public function getMethodDescription() {
    return pht('Invoke a crash');
  }
  protected function defineParamTypes() {
    return array();
  }
  protected function defineReturnType() {
    return 'dict';
  }
  protected function execute(ConduitAPIRequest $request) {
  }
}

Diff Detail

Repository
rP Phorge
Branch
develop
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 1426
Build 1426: arc lint + arc unit

Unit TestsFailed

TimeTest
468 msPhabricatorConduitTestCase::testConduitMethods
EXCEPTION (Exception): This is a custom exception #0 /var/www/htdocs/phorge/arcanist/src/symbols/PhutilClassMapQuery.php(263): BotUserCreateConduitAPIMethod->getAPIMethodName() #1 /var/www/htdocs/phorge/arcanist/src/symbols/PhutilClassMapQuery.php(184): PhutilClassMapQuery->loadMap()
49 msCelerityPostprocessorTestCase::testGetAllCelerityPostprocessors
1 assertion passed.
32 msCelerityResourceTransformerTestCase::testTransformation
3 assertions passed.
896 msPhabricatorCelerityTestCase::testCelerityMaps
4 assertions passed.
463 msPhabricatorInfrastructureTestCase::testApplicationsInstalled
1 assertion passed.
View Full Test Results (1 Failed · 8 Passed)