Page MenuHomePhorge

Run celerity map after rP1fa8c79b1ef86a9edda575b582b18fa24d60ea1f
ClosedPublic

Authored by aklapper on Jun 22 2024, 21:17.

Details

Summary

I obviously failed to run ./bin/celerity map one more time before running arc diff. Sorry for that.

Test Plan

Run ./bin/celerity map and see differences.

Diff Detail

Repository
rP Phorge
Branch
D25631followup (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1364
Build 1364: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jun 22 2024, 21:19

I obviously failed to run ./bin/celerity map one more time before running arc diff.

There should really be some way to detect and prevent that mistake. It's one I've made probably 100 times before.

I obviously failed to run ./bin/celerity map one more time before running arc diff.

There should really be some way to detect and prevent that mistake. It's one I've made probably 100 times before.

Me too.
This might (or should be) covered by the unit tests - maybe arc land should run tests before pushing?

This might (or should be) covered by the unit tests

I think unit tests are already done, but that one seems designed to be not triggered for that kind of /webroot changes 🤔

T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file