Update d3 from version 5.9.2 to 6.7.0
ClosedPublic
Actions

Authored by aklapper on May 9 2024, 15:21.

Details

Reviewers

speck

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15820: Update d3 from version 5.9.2 to 6.7.0

Commits

rP1fa8c79b1ef8: Update d3 from version 5.9.2 to 6.7.0

Summary

Update the d3 library to its last 6.x version available on https://github.com/d3/d3/releases

This also requires updating the tooltip event handling of dots in Chart.js to avoid an Uncaught TypeError: d3.event is undefined per https://observablehq.com/@d3/d3v6-migration-guide#event-management linked from https://github.com/d3/d3/releases/tag/v6.0.0

Closes T15820

Test Plan

Enable the Facts application, go to the Reports of a Project with task changes over time, look at charts, hover over data points, read the tooltip - e.g. on http://phorge.localhost/project/reports/1/ or http://phorge.localhost/maniphest/report/burn/
Check HTML source of above URIs for the <script type="text/javascript"> loading d3.min.js and open the JS file to verify the d3 version number bump.
Check Console of web browser's developer tools for no errors.

Diff Detail

Repository

rP Phorge

Branch

d3v6 (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1243
Build 1243: arc lint + arc unit

Event Timeline

aklapper created this revision.May 9 2024, 15:21

Owners added a reviewer: O1: Blessed Committers.May 9 2024, 15:21

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMay 9 2024, 15:21

aklapper requested review of this revision.May 9 2024, 15:21

Harbormaster completed remote builds in B1243: Diff 1963.May 9 2024, 15:21

aklapper mentioned this in D25660: PHPMailer: Set defaults for required parameters followed by optional parameters in Authorise() method signature.May 30 2024, 18:08

I take it the api used by Phorge hasn’t updated or changed in the update?

We can try it. I think d3 is little used and where it is, they are not popular apps (that I’m aware of) so seems like we can update and not have a large impact.

This revision is now accepted and ready to land.Jun 22 2024, 03:15

Thanks for taking a look! Grep'ing the Phorge codebase I could not find any other consumers of d3 than Chart.js used by the Facts application. The d3 API has changed between 5.9.2 and 6.7.0 but the only changes relevant to Phorge which I found are covered in the three lines touched in Chart.js in this very patch.

Great, I appreciate your thoroughness here!

aklapper edited the test plan for this revision. (Show Details)Jun 22 2024, 20:35

aklapper mentioned this in Next Up.Jun 22 2024, 20:42

Closed by commit rP1fa8c79b1ef8: Update d3 from version 5.9.2 to 6.7.0. · Explain WhyJun 22 2024, 20:42

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP1fa8c79b1ef8: Update d3 from version 5.9.2 to 6.7.0.

valerio.bozzolan mentioned this in T15209: The Celerity unit tests are not automatically run when touching whatever CSS or JS file.Jun 23 2024, 17:12

valerio.bozzolan mentioned this in 2024 week 35.Aug 28 2024, 10:19