Remarkup: minor refactor to identify anchor and relative URIs
AbandonedPublic
Actions

Authored by valerio.bozzolan on Mar 23 2023, 09:20.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15182: Simplify the way "internal links" are identified

Summary

This modification should not change anything logically.

This change simplifies these checks:

The methods are introduced in PhutilRemarkupRule since that
is the parent class of these children classes:

Test Plan

Repository

rP Phorge

Branch

T15161-remarkup-internal-links-refactor

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	src/infrastructure/markup/markuprule/PhutilRemarkupRule.php:115	XHP25	Spaces Inside Parentheses
Warning	src/infrastructure/markup/markuprule/PhutilRemarkupRule.php:125	XHP25	Spaces Inside Parentheses

Unit

Test Failures

Build Status

Buildable 153
Build 153: arc lint + arc unit

	Time	Test
	755 ms	PhabricatorCelerityTestCase::testCelerityMaps Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
	81 ms	PhabricatorAnchorTestCase::testAnchors 8 assertions passed.
	1,065 ms	PhabricatorConduitTestCase::testConduitMethods 1 assertion passed.
	407 ms	PhabricatorInfrastructureTestCase::testApplicationsInstalled 1 assertion passed.
	355 ms	PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries 1 assertion passed.
		View Full Test Results (1 Failed · 21 Passed · 1 Skipped)