Page MenuHomePhorge
Differential D25076

Fix regression in new confirmation Dialog
ClosedPublic
Actions

Authored by valerio.bozzolan on Mar 13 2023, 20:40.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 19:35
Unknown Object (File)
Mon, Apr 29, 19:34
Unknown Object (File)
Thu, Apr 25, 10:49
Unknown Object (File)
Thu, Apr 25, 10:49
Unknown Object (File)
Thu, Apr 25, 10:49
Unknown Object (File)
Thu, Apr 25, 05:22
Unknown Object (File)
Wed, Apr 24, 22:23
Unknown Object (File)
Thu, Apr 11, 04:21
View All Files
Subscribers
Cigaryno
Matthew
speck
tobiaswiese

Details

Reviewers
bekay
Ekubischta
avivey
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15034: Show confirmation dialog when closing a modal if form contents have been changed
Commits
rP3487ee444a88: Fix regression in new confirmation Dialog
Summary

Fix a JavaScript regression encapsulating the problematic part into an if.

Other minor changes:

  • dedicate a variable for the confirmation messages to improve i18n in the future (but also to avoid 80 characters and make lint happy)
  • replace confirm with window.confirm (to make lint happy)

Ref T15034
Ref D25015

Test Plan
  • surf on your local Phorge
  • no JavaScript errors in console

Diff Detail

Repository
rP Phorge
Branch
T15034-fix-regression
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 134
Build 134: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Mar 13 2023, 20:40
Owners added a reviewer: O1: Blessed Committers.Mar 13 2023, 20:40
Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptMar 13 2023, 20:40
valerio.bozzolan requested review of this revision.Mar 13 2023, 20:40
Harbormaster completed remote builds in B133: Diff 340.Mar 13 2023, 20:41
valerio.bozzolan mentioned this in D25015: Show confirmation dialog when closing a modal if form contents have been changed.Mar 13 2023, 20:45
valerio.bozzolan mentioned this in T15034: Show confirmation dialog when closing a modal if form contents have been changed.Mar 13 2023, 20:48
valerio.bozzolan mentioned this in 2023 Week 2.
valerio.bozzolan updated this revision to Diff 341.Mar 14 2023, 07:17
  • adopt window.confirm instead of just confirm to make linter happy

https://developer.mozilla.org/en-US/docs/Web/API/Window/confirm

Harbormaster completed remote builds in B134: Diff 341.Mar 14 2023, 07:17
valerio.bozzolan mentioned this in Z1: Phorge.Mar 14 2023, 07:19
valerio.bozzolan edited the summary of this revision. (Show Details)Mar 14 2023, 13:38
avivey accepted this revision.Mar 14 2023, 18:32
This revision is now accepted and ready to land.Mar 14 2023, 18:32
Closed by commit rP3487ee444a88: Fix regression in new confirmation Dialog. · Explain WhyMar 14 2023, 19:25
This revision was automatically updated to reflect the committed changes.
valerio.bozzolan added a commit: rP3487ee444a88: Fix regression in new confirmation Dialog.
Dylsss mentioned this in D25052: Add and use new RemarkupMetadata class.Apr 24 2023, 00:05

Revision Contents
Changeset List

PathSizePackages
webroot/
rsrc/
externals/
javelin/
lib/
41 linesO1: Blessed Committers

Diff 341

View Options

webroot/rsrc/externals/javelin/lib/Workflow.js

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0