Page MenuHomePhorge

Fix regression in new confirmation Dialog
ClosedPublic

Authored by valerio.bozzolan on Mar 13 2023, 20:40.
Tags
None
Referenced Files
F2943143: D25076.1738166728.diff
Tue, Jan 28, 16:05
F2942811: D25076.1738138488.diff
Tue, Jan 28, 08:14
F2940222: D25076.1738043221.diff
Mon, Jan 27, 05:47
F2936023: D25076.1737895723.diff
Sat, Jan 25, 12:48
F2936022: D25076.1737895714.diff
Sat, Jan 25, 12:48
F2936021: D25076.1737895700.diff
Sat, Jan 25, 12:48
F2935971: D25076.1737891023.diff
Sat, Jan 25, 11:30
F2935970: D25076.1737890994.diff
Sat, Jan 25, 11:29

Details

Summary

Fix a JavaScript regression encapsulating the problematic part into an if.

Other minor changes:

  • dedicate a variable for the confirmation messages to improve i18n in the future (but also to avoid 80 characters and make lint happy)
  • replace confirm with window.confirm (to make lint happy)

Ref T15034
Ref D25015

Test Plan
  • surf on your local Phorge
  • no JavaScript errors in console

Diff Detail

Repository
rP Phorge
Branch
T15034-fix-regression
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/externals/javelin/lib/Workflow.js:563W117JSHintW117
Unit
No Test Coverage
Build Status
Buildable 133
Build 133: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 14 2023, 18:32