Page MenuHomePhorge
Differential D25032

Update PassphraseCredential to support Mentions
ClosedPublic
Actions

Authored by Ekubischta on Jan 21 2022, 20:42.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 8, 10:32
Unknown Object (File)
Mon, Apr 8, 10:24
Unknown Object (File)
Mon, Apr 8, 10:11
Unknown Object (File)
Sun, Apr 7, 10:23
Unknown Object (File)
Mon, Apr 1, 00:40
Unknown Object (File)
Mon, Apr 1, 00:40
Unknown Object (File)
Mon, Apr 1, 00:40
Unknown Object (File)
Mon, Apr 1, 00:40
View All Files
Subscribers
Cigaryno
Matthew
speck
tobiaswiese
valerio.bozzolan

Details

Reviewers
Matthew
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15234: Support Mentions in Passphrase
Commits
rP4aedc206c727: Update PassphraseCredential to support Mentions
Summary

This revision allows us to see where passphrase credentials are mentioned in other parts of phabricator

This is very useful to "What is this credential for?" If we can see where it was been mentioned

Test Plan

Mentioned a passphrase and saw it in the transaction list

Diff Detail

Repository
rP Phorge
Branch
lc-phorge-master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 61
Build 61: arc lint + arc unit

Event Timeline

Ekubischta created this revision.Jan 21 2022, 20:42
Owners added a reviewer: O1: Blessed Committers.Jan 21 2022, 20:42
Herald added subscribers: valerio.bozzolan, tobiaswiese, speck. · View Herald TranscriptJan 21 2022, 20:42
Ekubischta requested review of this revision.Jan 21 2022, 20:42
Ekubischta updated this revision to Diff 85.
  • ran arc liberate
Harbormaster completed remote builds in B60: Diff 84.Jan 25 2022, 18:55
Harbormaster completed remote builds in B61: Diff 85.
Cigaryno subscribed.Sep 13 2022, 14:21
Matthew accepted this revision as: Matthew.Sep 30 2022, 00:00
Matthew subscribed.

LGTM

Screen Shot 2022-09-29 at 5.59.31 PM.png (1×2 px, 239 KB)

Matthew accepted this revision.Oct 4 2022, 19:04
This revision is now accepted and ready to land.Oct 4 2022, 19:04
avivey mentioned this in 2022-10-04.Oct 9 2022, 10:04
Closed by commit rP4aedc206c727: Update PassphraseCredential to support Mentions. · Explain WhyOct 9 2022, 10:30
This revision was automatically updated to reflect the committed changes.
avivey added a commit: rP4aedc206c727: Update PassphraseCredential to support Mentions.
Cigaryno mentioned this in 2022 Week 42.Oct 22 2022, 09:23
Cigaryno mentioned this in 2022 Week 43.Oct 29 2022, 10:09
Matthew mentioned this in 2022 Week 46.Nov 11 2022, 20:14
Cigaryno mentioned this in 2023 Week 2.Jan 7 2023, 08:39
valerio.bozzolan mentioned this in T15234: Support Mentions in Passphrase.Apr 6 2023, 12:06
valerio.bozzolan added a task: T15234: Support Mentions in Passphrase.
avivey mentioned this in 2023 Week 17.Apr 25 2023, 06:54

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)Packages
src/
--O1: Blessed Committers
applications/
passphrase/
storage/
1 line3%
Loading...
O1: Blessed Committers

Diff 85

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/passphrase/storage/PassphraseCredential.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0