I mark as phorge.it install since it also affects this website.

After your change, it seems Evan fixed this as well, but with a different approach:

Well, I did ask for this to be converted into a revision, so I'm OK getting added as a reviewer. Sorry for the delay, I've been on vacation.

@tiguchi you don't have to add reviewers yourself.

In T15105#3252, @tiguchi wrote:

In T15105#3239, @Matthew wrote:

In T15105#3233, @tiguchi wrote:

As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:

foreach ($new_phids as $phids) {
  foreach ($phids as $phid) {
    $file_phids[] = $editor->loadPholioImage($object, $phid)
      ->getFilePHID();
  }
}

This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes

Would you be willing to create a revision so we can put that fix into upstream? If you're not sure how, or need some help, feel free to ping me!

I just submitted a patch and ran into issues with running unit tests. It seems like the tests expect me to set up a MySQL database. I submitted the patch with arc diff --nounit if that's OK with you

In T15105#3239, @Matthew wrote:

In T15105#3233, @tiguchi wrote:

As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:

foreach ($new_phids as $phids) {
  foreach ($phids as $phid) {
    $file_phids[] = $editor->loadPholioImage($object, $phid)
      ->getFilePHID();
  }
}

This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes

Would you be willing to create a revision so we can put that fix into upstream? If you're not sure how, or need some help, feel free to ping me!

In T15105#3233, @tiguchi wrote:

As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:

foreach ($new_phids as $phids) {
  foreach ($phids as $phid) {
    $file_phids[] = $editor->loadPholioImage($object, $phid)
      ->getFilePHID();
  }
}

This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes

In addition to the above, it seems that commit d017f3f21021 is what broke this. And adjustTransactionValues is what changes the xaction from

Array
(
    [+] => Array
        (
            [0] => PHID-PIMG-m5pqg3eec46uvzw6uynm
        )

Small update: I just migrated our Phabricator installation to Phorge following the instructions in Update From Phabricator. The migration worked, but we still cannot upload new mockups.

I'm unable to reproduce this issue, after trying on multiple installs. I'm going to release this for someone else to take a try.

I'll see if I can reproduce this error.