Page MenuHomePhorge
Feed Advanced Search

Jun 5 2023

speck added inline comments to D25058: Fix broken file PHID extraction that causes Pholio uploads to crash.
Jun 5 2023, 17:38 · Pholio

May 7 2023

valerio.bozzolan edited Description on Pholio.
May 7 2023, 09:17

Apr 6 2023

avivey archived Pholio.
Apr 6 2023, 09:47

Mar 25 2023

valerio.bozzolan added a comment to T15105: Cannot upload new mockups via Pholio.

I mark as phorge.it install since it also affects this website.

Mar 25 2023, 22:32 · phorge.it install (DEPRECATED)
valerio.bozzolan triaged T15105: Cannot upload new mockups via Pholio as High priority.
Mar 25 2023, 22:31 · phorge.it install (DEPRECATED)

Mar 23 2023

valerio.bozzolan added inline comments to D25058: Fix broken file PHID extraction that causes Pholio uploads to crash.
Mar 23 2023, 17:19 · Pholio
valerio.bozzolan added a comment to D25058: Fix broken file PHID extraction that causes Pholio uploads to crash.

After your change, it seems Evan fixed this as well, but with a different approach:

Mar 23 2023, 17:14 · Pholio

Nov 11 2022

Matthew closed T15105: Cannot upload new mockups via Pholio as Resolved by committing rPa8a38835e15e: Fix broken file PHID extraction that causes Pholio uploads to crash.
Nov 11 2022, 20:10 · phorge.it install (DEPRECATED)
Matthew closed D25058: Fix broken file PHID extraction that causes Pholio uploads to crash.
Nov 11 2022, 20:10 · Pholio
Matthew accepted D25058: Fix broken file PHID extraction that causes Pholio uploads to crash.
Nov 11 2022, 20:09 · Pholio

Nov 7 2022

Matthew added a comment to D25058: Fix broken file PHID extraction that causes Pholio uploads to crash.

Well, I did ask for this to be converted into a revision, so I'm OK getting added as a reviewer. Sorry for the delay, I've been on vacation.

Nov 7 2022, 14:01 · Pholio

Nov 5 2022

Cigaryno removed a reviewer for D25058: Fix broken file PHID extraction that causes Pholio uploads to crash: Matthew.

@tiguchi you don't have to add reviewers yourself.

Nov 5 2022, 11:48 · Pholio

Oct 23 2022

Matthew added a comment to T15105: Cannot upload new mockups via Pholio.

As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:

foreach ($new_phids as $phids) {
  foreach ($phids as $phid) {
    $file_phids[] = $editor->loadPholioImage($object, $phid)
      ->getFilePHID();
  }
}

This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes

Would you be willing to create a revision so we can put that fix into upstream? If you're not sure how, or need some help, feel free to ping me!

I just submitted a patch and ran into issues with running unit tests. It seems like the tests expect me to set up a MySQL database. I submitted the patch with arc diff --nounit if that's OK with you

Oct 23 2022, 16:59 · phorge.it install (DEPRECATED)

Oct 21 2022

Cigaryno added a project to D25058: Fix broken file PHID extraction that causes Pholio uploads to crash: Pholio.
Oct 21 2022, 15:55 · Pholio
tiguchi added a comment to T15105: Cannot upload new mockups via Pholio.

As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:

foreach ($new_phids as $phids) {
  foreach ($phids as $phid) {
    $file_phids[] = $editor->loadPholioImage($object, $phid)
      ->getFilePHID();
  }
}

This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes

Would you be willing to create a revision so we can put that fix into upstream? If you're not sure how, or need some help, feel free to ping me!

Oct 21 2022, 15:11 · phorge.it install (DEPRECATED)
tiguchi added a revision to T15105: Cannot upload new mockups via Pholio: D25058: Fix broken file PHID extraction that causes Pholio uploads to crash.
Oct 21 2022, 15:09 · phorge.it install (DEPRECATED)

Oct 18 2022

Matthew added a comment to T15105: Cannot upload new mockups via Pholio.

As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:

foreach ($new_phids as $phids) {
  foreach ($phids as $phid) {
    $file_phids[] = $editor->loadPholioImage($object, $phid)
      ->getFilePHID();
  }
}

This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes

Oct 18 2022, 19:32 · phorge.it install (DEPRECATED)

Oct 16 2022

Dylsss added a comment to T15105: Cannot upload new mockups via Pholio.

In addition to the above, it seems that commit d017f3f21021 is what broke this. And adjustTransactionValues is what changes the xaction from

Array
(
    [+] => Array
        (
            [0] => PHID-PIMG-m5pqg3eec46uvzw6uynm
        )
Oct 16 2022, 15:32 · phorge.it install (DEPRECATED)

Oct 15 2022

tiguchi added a comment to T15105: Cannot upload new mockups via Pholio.

Small update: I just migrated our Phabricator installation to Phorge following the instructions in Update From Phabricator. The migration worked, but we still cannot upload new mockups.

Oct 15 2022, 17:27 · phorge.it install (DEPRECATED)

Sep 29 2022

Matthew placed T15105: Cannot upload new mockups via Pholio up for grabs.

I'm unable to reproduce this issue, after trying on multiple installs. I'm going to release this for someone else to take a try.

Sep 29 2022, 23:42 · phorge.it install (DEPRECATED)

Aug 9 2022

Matthew claimed T15105: Cannot upload new mockups via Pholio.

I'll see if I can reproduce this error.

Aug 9 2022, 20:00 · phorge.it install (DEPRECATED)

Aug 4 2022

tiguchi created T15105: Cannot upload new mockups via Pholio.
Aug 4 2022, 19:01 · phorge.it install (DEPRECATED)

Jun 15 2021

Matthew changed the visibility for Pholio.
Jun 15 2021, 04:26

Jun 11 2021

Matthew created Pholio.
Jun 11 2021, 16:16