Page MenuHomePhorge

aklapper (Andre Klapper)
Bot

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 28 2023, 20:44 (117 w, 1 d)
Availability
Available

Recent Activity

Yesterday

aklapper updated the summary of D26000: Remove orphan CSS selectors in calendar/phui-calendar.css.
Wed, May 28, 16:35
aklapper added a comment to D26000: Remove orphan CSS selectors in calendar/phui-calendar.css.

Is getDisplayIconColor() related to these? (spoiler: probably it's not)

Wed, May 28, 16:34
aklapper updated the summary of D25992: Remove unused anchor-target CSS for Conpherence message pane.
Wed, May 28, 16:26
aklapper updated the diff for D25992: Remove unused anchor-target CSS for Conpherence message pane.

remove unused CSS as it's also unhelpful CSS when actually used

Wed, May 28, 16:19
aklapper retitled D25992: Remove unused anchor-target CSS for Conpherence message pane from Conpherence message pane CSS: Fix typo in selector name
Wed, May 28, 14:31
aklapper planned changes to D25992: Remove unused anchor-target CSS for Conpherence message pane.

These selectors currently do not get applied at all in Conpherence rooms when opening or creating URIs with anchors.

Wed, May 28, 14:28
aklapper closed D26030: Fix project typeahead query with columns when string is not name prefix.
Wed, May 28, 13:23
aklapper closed T16068: Workboard column import project search: "Array for %Ls conversion is empty. Query: projectPHID IN (%Ls)" as Resolved by committing rP87da4d2a33e6: Fix project typeahead query with columns when string is not name prefix.
Wed, May 28, 13:23 · Bug Reports
aklapper committed rP87da4d2a33e6: Fix project typeahead query with columns when string is not name prefix.
Wed, May 28, 13:22
aklapper closed D26033: Search-related PhpDoc additions.
Wed, May 28, 10:41
aklapper committed rP93d9e1b05dd2: Search-related PhpDoc additions.
Wed, May 28, 10:41
aklapper retitled D26033: Search-related PhpDoc additions from Search related PhpDoc additions
Wed, May 28, 10:40
aklapper closed D25998: Remove orphan CSS selectors in base/main-menu-view.css.
Wed, May 28, 07:47
aklapper committed rP0347f1f619bb: Remove orphan CSS selectors in base/main-menu-view.css.
Wed, May 28, 07:47

Tue, May 27

aklapper updated the diff for D25998: Remove orphan CSS selectors in base/main-menu-view.css.

git rebase master

Tue, May 27, 21:27
aklapper closed D26014: Remove orphan CSS selectors in phui/phui-document*.css.
Tue, May 27, 21:20
aklapper committed rPf4f616410c23: Remove orphan CSS selectors in phui/phui-document*.css.
Tue, May 27, 21:20
aklapper updated the diff for D26028: Explain consequences when adding second Multi-Factor Auth.

Not really what we expected, but nice try

Tue, May 27, 21:06
aklapper updated the diff for D26033: Search-related PhpDoc additions.

@param loves $name

Tue, May 27, 17:56
aklapper requested review of D26033: Search-related PhpDoc additions.
Tue, May 27, 17:52
aklapper updated the summary of D26026: Add a Before-Destruction Engine.
Tue, May 27, 11:51
aklapper added a comment to T15903: Logged exceptions/errors should ignore user's language setting and be always in English.

pht() also does some escaping, formatting, and other safety related stuff

Tue, May 27, 10:10 · Localization

Mon, May 26

aklapper added a comment to D26032: Mark policy transactions of Conduit-created new tasks as such to fix empty Feed transaction entries.

Probably one screenshot is missing (?)

Mon, May 26, 15:58
aklapper added inline comments to D26026: Add a Before-Destruction Engine.
Mon, May 26, 11:52
valerio.bozzolan awarded T16085: PHP 8.1 "strncmp(null)" exception in transaction log for policy changes a Yellow Medal token.
Mon, May 26, 08:56 · PHP 8 support

Sun, May 25

aklapper accepted D26026: Add a Before-Destruction Engine.

Some small nitpicks only. Makes sense to me, didn't spot any logic flaws, keeps close to already existing code in that very directory

Sun, May 25, 23:43
aklapper added a comment to D26032: Mark policy transactions of Conduit-created new tasks as such to fix empty Feed transaction entries.

Feed before applying the patch (T3922) and after applying the patch (T3923):

Screenshot From 2025-05-25 23-03-12.png (432×1 px, 101 KB)

Sun, May 25, 21:42
aklapper requested review of D26032: Mark policy transactions of Conduit-created new tasks as such to fix empty Feed transaction entries.
Sun, May 25, 21:40
aklapper added a revision to T16085: PHP 8.1 "strncmp(null)" exception in transaction log for policy changes: D26032: Mark policy transactions of Conduit-created new tasks as such to fix empty Feed transaction entries.
Sun, May 25, 21:40 · PHP 8 support
aklapper added a comment to T16085: PHP 8.1 "strncmp(null)" exception in transaction log for policy changes.

getIsCreateTransaction() should return true here but it doesn't.
I believe that this underlying problem can also trigger an exception, see https://phabricator.wikimedia.org/T361459

Sun, May 25, 20:59 · PHP 8 support
aklapper created T16085: PHP 8.1 "strncmp(null)" exception in transaction log for policy changes.
Sun, May 25, 10:57 · PHP 8 support
aklapper closed T16059: Remove -webkit-font-smoothing and -moz-osx-font-smoothing from CSS as Resolved by committing rP555e569ff8c4: Remove macOS specific font smoothing CSS.
Sun, May 25, 10:04 · Wikimedia Hackathon 2025
aklapper closed D25989: Remove macOS specific font smoothing CSS.
Sun, May 25, 10:04
aklapper committed rP555e569ff8c4: Remove macOS specific font smoothing CSS.
Sun, May 25, 10:04

Sat, May 24

aklapper updated the diff for D25989: Remove macOS specific font smoothing CSS.

git rebase master

Sat, May 24, 16:13
aklapper updated the test plan for D26031: Allow using PCRE's just-in-time compilation.
Sat, May 24, 14:42
aklapper added a revision to T16084: Stop disabling pcre.jit by default: D26031: Allow using PCRE's just-in-time compilation.
Sat, May 24, 12:49
aklapper requested review of D26031: Allow using PCRE's just-in-time compilation.
Sat, May 24, 12:49
aklapper created T16084: Stop disabling pcre.jit by default.
Sat, May 24, 12:46
aklapper closed T16075: TypeError: idx(): Argument #1 ($array) must be of type array, string given in PhabricatorSearchHovercardController.php as Resolved by committing rPed7abd7c41f4: Ignore bogus cards parameter string values in Hovercards calls.
Sat, May 24, 08:40
aklapper closed D26023: Ignore bogus cards parameter string values in Hovercards calls.
Sat, May 24, 08:40
aklapper committed rPed7abd7c41f4: Ignore bogus cards parameter string values in Hovercards calls.
Sat, May 24, 08:40
aklapper closed D26007: Remove unused CSS file aphront/panel-view.css.
Sat, May 24, 07:28
aklapper committed rPd784533cf71d: Remove unused CSS file aphront/panel-view.css.
Sat, May 24, 07:28

Fri, May 23

aklapper updated the diff for D26007: Remove unused CSS file aphront/panel-view.css.

git rebase master

Fri, May 23, 21:44
aklapper added a comment to D26007: Remove unused CSS file aphront/panel-view.css.

no no I rock like a grapstar

Fri, May 23, 17:32
aklapper updated the diff for D26028: Explain consequences when adding second Multi-Factor Auth.

Uh right, thanks! Let's do as mainframe98 says

Fri, May 23, 17:28
aklapper requested review of D26007: Remove unused CSS file aphront/panel-view.css.
Fri, May 23, 17:21
aklapper added a comment to D26007: Remove unused CSS file aphront/panel-view.css.

@valerio.bozzolan core/remarkup.css has five more unused selectors so I'd put them all together into one patch.

Fri, May 23, 17:21
aklapper closed D25995: Remove orphan CSS selectors in PHUIFormView.
Fri, May 23, 00:08
aklapper committed rP5e64a0a81903: Remove orphan CSS selectors in PHUIFormView.
Fri, May 23, 00:08

Thu, May 22

aklapper added a comment to D26030: Fix project typeahead query with columns when string is not name prefix.

You're right, thank you (as usual)!

Thu, May 22, 17:13
aklapper updated the test plan for D26030: Fix project typeahead query with columns when string is not name prefix.
Thu, May 22, 17:13
aklapper updated the diff for D25995: Remove orphan CSS selectors in PHUIFormView.

git rebase master

Thu, May 22, 16:35
aklapper closed D25978: Fix wrong argument count in numerous calls' signatures.
Thu, May 22, 16:28
aklapper committed rPb174cce279aa: Fix wrong argument count in numerous calls' signatures.
Thu, May 22, 16:28
aklapper updated the summary of D26030: Fix project typeahead query with columns when string is not name prefix.
Thu, May 22, 10:13
aklapper requested review of D26030: Fix project typeahead query with columns when string is not name prefix.
Thu, May 22, 10:10
aklapper added a revision to T16068: Workboard column import project search: "Array for %Ls conversion is empty. Query: projectPHID IN (%Ls)": D26030: Fix project typeahead query with columns when string is not name prefix.
Thu, May 22, 10:10 · Bug Reports
aklapper closed D26006: Remove unused FatCow icon files.
Thu, May 22, 06:53
aklapper committed rP947b70441184: Remove unused FatCow icon files.
Thu, May 22, 06:53

Wed, May 21

aklapper added inline comments to D26026: Add a Before-Destruction Engine.
Wed, May 21, 12:59

Tue, May 20

aklapper accepted D26029: AphrontFormDateControlValue: fix PHP 8.1 strlen(null) from AphrontFormDateControlValue.php:72.

Thanks! Confirming; tested, also works as expected with other epoch values.

Tue, May 20, 16:21
aklapper added a comment to D26028: Explain consequences when adding second Multi-Factor Auth.

I'm too stuck in Serious Business Mode to introduce another string to translate, I'm afraid :-/

Tue, May 20, 13:13
aklapper added a comment to D26000: Remove orphan CSS selectors in calendar/phui-calendar.css.

Should we also add some PHPDoc @deprecate (or whatever its name) to most CalendarColors?

Tue, May 20, 13:02
aklapper updated the diff for D26028: Explain consequences when adding second Multi-Factor Auth.

indentation is arrsome

Tue, May 20, 12:44
aklapper updated the diff for D26028: Explain consequences when adding second Multi-Factor Auth.

oh true

Tue, May 20, 12:42
valerio.bozzolan awarded D26000: Remove orphan CSS selectors in calendar/phui-calendar.css a Yellow Medal token.
Tue, May 20, 12:38
aklapper added a comment to D26028: Explain consequences when adding second Multi-Factor Auth.

Hmm could you share why it's a "legacy feature"? I guess I'm clueless

Tue, May 20, 12:31
aklapper updated the diff for D26028: Explain consequences when adding second Multi-Factor Auth.

Rephrase to not mentioned "second MFA"; Avoid empty HTML paragraph

Tue, May 20, 12:21
aklapper added a comment to D26028: Explain consequences when adding second Multi-Factor Auth.

good points <3

Tue, May 20, 12:20
aklapper added a revision to T16081: Warn users that adding a second Multi-Factor Auth will require both instead of choosing one of them: D26028: Explain consequences when adding second Multi-Factor Auth.
Tue, May 20, 12:10
aklapper requested review of D26028: Explain consequences when adding second Multi-Factor Auth.
Tue, May 20, 12:10
aklapper added a comment to T16081: Warn users that adding a second Multi-Factor Auth will require both instead of choosing one of them.

Proposed behavior: Add additional text when setting up a second MFA.

Tue, May 20, 12:05
aklapper created T16081: Warn users that adding a second Multi-Factor Auth will require both instead of choosing one of them.
Tue, May 20, 12:01
aklapper added inline comments to D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.
Tue, May 20, 10:14
aklapper edited the content of Next Up.
Tue, May 20, 06:36
aklapper edited the content of Next Up.
Tue, May 20, 06:35
aklapper closed D26021: Make User-Agent regex detect Firefox on Android.
Tue, May 20, 06:33
aklapper closed T16071: Avoid large layout shifts while page loading on mobile as Resolved by committing rPf4d3c968461e: Make User-Agent regex detect Firefox on Android.
Tue, May 20, 06:33
aklapper committed rPf4d3c968461e: Make User-Agent regex detect Firefox on Android.
Tue, May 20, 06:33

Mon, May 19

aklapper closed D26025: Add PHPDoc to PhabricatorPHIDType::canLoadNamedObject().
Mon, May 19, 18:44
aklapper committed rP361b512bd532: Add PHPDoc to PhabricatorPHIDType::canLoadNamedObject().
Mon, May 19, 18:44
aklapper updated the diff for D26025: Add PHPDoc to PhabricatorPHIDType::canLoadNamedObject().

...and now even in the correct order of parameters, sigh

Mon, May 19, 17:52
aklapper requested review of D26025: Add PHPDoc to PhabricatorPHIDType::canLoadNamedObject().
Mon, May 19, 17:46
aklapper updated the summary of D25978: Fix wrong argument count in numerous calls' signatures.
Mon, May 19, 15:03
aklapper updated the diff for D25978: Fix wrong argument count in numerous calls' signatures.

You are correct. (And I am disappointed by PHPStan to not realize that.)

Mon, May 19, 14:05
aklapper updated the summary of D25978: Fix wrong argument count in numerous calls' signatures.
Mon, May 19, 14:05
aklapper requested review of D26024: Make long phui-tag-view object titles wrap in Remarkup context.
Mon, May 19, 11:54
aklapper added a revision to T16077: Referenced long object titles ({X123}) should wrap in descriptions/comments: D26024: Make long phui-tag-view object titles wrap in Remarkup context.
Mon, May 19, 11:54
aklapper created T16077: Referenced long object titles ({X123}) should wrap in descriptions/comments.
Mon, May 19, 11:47
aklapper updated the diff for D25978: Fix wrong argument count in numerous calls' signatures.

Make PhabricatorDifferentialRevisionTestDataGenerator::generateDescription() have more than one sentence

Mon, May 19, 09:54
aklapper closed D26017: Remove orphan CSS selectors in diffusion/diffusion-*.css.
Mon, May 19, 05:19
aklapper committed rP7e4c1e93b55b: Remove orphan CSS selectors in diffusion/diffusion-*.css.
Mon, May 19, 05:19

Sun, May 18

aklapper added inline comments to D26017: Remove orphan CSS selectors in diffusion/diffusion-*.css.
Sun, May 18, 21:23
aklapper closed D26009: Remove orphan CSS selectors in phui/phui-action-panel.css.
Sun, May 18, 21:12
aklapper committed rP39216af0db7b: Remove orphan CSS selectors in phui/phui-action-panel.css.
Sun, May 18, 21:12
aklapper closed D26008: Remove orphan CSS selectors in phui/phui-header-view.css.
Sun, May 18, 21:11
aklapper committed rP4195c91af0fe: Remove orphan CSS selectors in phui/phui-header-view.css.
Sun, May 18, 21:11
aklapper updated the diff for D26008: Remove orphan CSS selectors in phui/phui-header-view.css.

git rebase master

Sun, May 18, 21:10