In T15640#19898, @valerio.bozzolan wrote:

Wow. Assuming the line is the one with phutil_nonempty_string($branch), why branch "main" is considered a number?

Thanks for the super-quick patch! I can confirm that this fixes the issue in the Phriction ToC on wider screens.

@jeffrey: Would you like to arc land your patch to get it merged?

@bekay: Would you like to merge this?

In D25775#21206, @valerio.bozzolan wrote:

More understanding on the root cause is needed. Probably the root cause is "just" that getOldValue() returns an empty string. In that case we should probably at least understand what object is that (sub-class of PhabricatorTransactionRemarkupChange?) and we probably we need something like a generateOldValue() or something similar.

After installing subversion and setting LC_ALL instead of LANG I can finally reproduce on a Fedora 40 system:

Oh true, got it. Have to replace PhabricatorPolicyCapability::POLICY_ADMIN, with 'capability' => PhabricatorPolicies::POLICY_ADMIN, here

Right... one day I may get used to all those Phorge shortcuts, thanks

Oops, no for real

Uhm, right, heh

I applied this patch locally on top of git master and output does not complain anymore about 'link-brackets.txt' (thus it's correct) but fails in link-edge-cases.txt now (thus it's likely not complete):

@mturdus: Thanks! LGTM

@valerio.bozzolan: Feel free to give this revised version another review :)

Big thanks for digging deep into that regex (on which I gave up).

Thanks. Confirming that this works as expected (after manually changing test_accents.mbox to make the arc unit output fail)

Simplify return of validateRealName() as proposed by Valerio

Thanks for catching that! Amend in new PhutilNumber()

Finally got a reproducer URI in downstream:

• Broken: https://phabricator.wikimedia.org/diffusion/OSWB/branches/main/.gitignore;5a588bf0ee10546ddb9d0872d1be1bf48b3f3c07 (branches in URI).
• Works: https://phabricator.wikimedia.org/diffusion/OSWB/browse/main/.gitignore;5a588bf0ee10546ddb9d0872d1be1bf48b3f3c07 (browse in URI).

In D25696#22447, @valerio.bozzolan wrote:

Maybe relevant but PhabricatorObjectHandleData seems to do some magic

Also update the PhpDoc accordingly

Ignore PHP 8.3.0's new DateMalformedStringException and stick to generic Exception in all cases instead

@taavi: Uhm, thanks! If you have a chance to test D25839 that would be great. :)

Handle whitespace-only task and project titles correctly

This needs rework as the logic currently does not properly handle entering a title consisting of whitespace only. (Outcome gets unpleasant afterwards.)

This should be resolved by now in git master