In D26000#27480, @valerio.bozzolan wrote:

Is getDisplayIconColor() related to these? (spoiler: probably it's not)

remove unused CSS as it's also unhelpful CSS when actually used

These selectors currently do not get applied at all in Conpherence rooms when opening or creating URIs with anchors.

git rebase master

Not really what we expected, but nice try

@param loves $name

In T15903#18783, @avivey wrote:

pht() also does some escaping, formatting, and other safety related stuff

In D26032#27637, @valerio.bozzolan wrote:

Probably one screenshot is missing (?)

Some small nitpicks only. Makes sense to me, didn't spot any logic flaws, keeps close to already existing code in that very directory

Feed before applying the patch (T3922) and after applying the patch (T3923):

getIsCreateTransaction() should return true here but it doesn't.
I believe that this underlying problem can also trigger an exception, see https://phabricator.wikimedia.org/T361459

git rebase master

git rebase master

no no I rock like a grapstar

Uh right, thanks! Let's do as mainframe98 says

In D26007#26996, @aklapper wrote:

@valerio.bozzolan core/remarkup.css has five more unused selectors so I'd put them all together into one patch.

You're right, thank you (as usual)!

git rebase master

Thanks! Confirming; tested, also works as expected with other epoch values.

I'm too stuck in Serious Business Mode to introduce another string to translate, I'm afraid :-/

In D26000#27460, @valerio.bozzolan wrote:

Should we also add some PHPDoc @deprecate (or whatever its name) to most CalendarColors?

indentation is arrsome

oh true

Hmm could you share why it's a "legacy feature"? I guess I'm clueless

Rephrase to not mentioned "second MFA"; Avoid empty HTML paragraph

good points <3

Proposed behavior: Add additional text when setting up a second MFA.

...and now even in the correct order of parameters, sigh

You are correct. (And I am disappointed by PHPStan to not realize that.)

Make PhabricatorDifferentialRevisionTestDataGenerator::generateDescription() have more than one sentence

git rebase master