Page MenuHomePhorge

aklapper (Andre Klapper)
Bot

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 28 2023, 20:44 (56 w, 1 d)
Availability
Available

Recent Activity

Today

aklapper accepted D25552: Config Projects Extra Fields: link to the doc (like User).

LGTM

Thu, Mar 28, 20:07
aklapper placed T15650: AphrontDuplicateKeyQueryException dragging task from milestone column to main board column: Duplicate entry for key 'boardPHID' up for grabs.
Thu, Mar 28, 19:54 · Affects-Wikimedia, Bug Reports
aklapper added a subtask for T15650: AphrontDuplicateKeyQueryException dragging task from milestone column to main board column: Duplicate entry for key 'boardPHID': T15764: Moving tasks on a workboard via the "Add Action" dropdown does not update column and column positions tables.
Thu, Mar 28, 19:54 · Affects-Wikimedia, Bug Reports
aklapper added a parent task for T15764: Moving tasks on a workboard via the "Add Action" dropdown does not update column and column positions tables: T15650: AphrontDuplicateKeyQueryException dragging task from milestone column to main board column: Duplicate entry for key 'boardPHID'.
Thu, Mar 28, 19:54 · Bug Reports
aklapper created T15764: Moving tasks on a workboard via the "Add Action" dropdown does not update column and column positions tables.
Thu, Mar 28, 19:50 · Bug Reports

Tue, Mar 26

aklapper accepted D25562: Fix Project Hovercard rendering @mention.

I can confirm that the change fixes the exception locally on git master for me. Thanks!

Tue, Mar 26, 15:58
aklapper foisted D25269: Fix PHP 8.2 "strlen(null)" exceptions block rendering Differential Revision page (T15432 - 2/2) upon mturdus.
Tue, Mar 26, 15:46
aklapper abandoned D25269: Fix PHP 8.2 "strlen(null)" exceptions block rendering Differential Revision page (T15432 - 2/2).

All three changes superseded by D25250 in my understanding. If not, then please reopen. Thanks!

Tue, Mar 26, 15:45
aklapper commandeered D25269: Fix PHP 8.2 "strlen(null)" exceptions block rendering Differential Revision page (T15432 - 2/2).
Tue, Mar 26, 15:45

Fri, Mar 22

aklapper closed T15755: PHP 7.3: strpos(): Non-string needles will be interpreted as strings (in arcanist/src/utils/PhutilSortVector.php:33) as Resolved by committing rARCef73b12b580e: Fix "strpos(): Non-string needles will be interpreted as strings" in….
Fri, Mar 22, 12:35
aklapper closed D25557: Fix "strpos(): Non-string needles will be interpreted as strings" in PhutilSortVector.
Fri, Mar 22, 12:35
aklapper committed rARCef73b12b580e: Fix "strpos(): Non-string needles will be interpreted as strings" in….
Fix "strpos(): Non-string needles will be interpreted as strings" in…
Fri, Mar 22, 12:35
aklapper updated the summary of D25557: Fix "strpos(): Non-string needles will be interpreted as strings" in PhutilSortVector.
Fri, Mar 22, 10:27
aklapper requested review of D25557: Fix "strpos(): Non-string needles will be interpreted as strings" in PhutilSortVector.
Fri, Mar 22, 10:26
aklapper added a revision to T15755: PHP 7.3: strpos(): Non-string needles will be interpreted as strings (in arcanist/src/utils/PhutilSortVector.php:33): D25557: Fix "strpos(): Non-string needles will be interpreted as strings" in PhutilSortVector.
Fri, Mar 22, 10:26

Thu, Mar 21

aklapper updated the task description for T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.
Thu, Mar 21, 22:34 · Affects-Wikimedia, Bug Reports
aklapper added a comment to T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.

Also note that we have a similar PhabricatorDataNotAttachedException in PhabricatorRepositoryCommit (via getRepository()) in downstream https://phabricator.wikimedia.org/T360714. It's without reproduction steps but sounds a bit similar.

Thu, Mar 21, 20:40 · Affects-Wikimedia, Bug Reports
aklapper updated the task description for T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.
Thu, Mar 21, 20:21 · Affects-Wikimedia, Bug Reports
aklapper created T15762: PhabricatorDataNotAttachedException when rendering project hovercard with username mentioned in project description.
Thu, Mar 21, 20:19 · Affects-Wikimedia, Bug Reports
aklapper closed T15631: "Map returned omits required key" exception for second result page (cursor) for Maniphest search ordered by custom field as Resolved by committing rPd42b3eb0b17a: Fix "Map omits required key" exception by comparing result order against modern….
Thu, Mar 21, 18:26 · Affects-Wikimedia, Bug Reports
aklapper closed D25504: Fix "Map omits required key" exception by comparing result order against modern field keys.
Thu, Mar 21, 18:26
aklapper committed rPd42b3eb0b17a: Fix "Map omits required key" exception by comparing result order against modern….
Fix "Map omits required key" exception by comparing result order against modern…
Thu, Mar 21, 18:25
aklapper requested review of D25556: Fix PHP 8.1 "strlen(null)" exception querying project tags for autocomplete without additional hashtag slugs defined.
Thu, Mar 21, 17:36
aklapper added a revision to T15761: PHP 8.1 "strlen(null)" exception entering autocomplete project tag in task comment: D25556: Fix PHP 8.1 "strlen(null)" exception querying project tags for autocomplete without additional hashtag slugs defined.
Thu, Mar 21, 17:36 · PHP 8 support
aklapper created T15761: PHP 8.1 "strlen(null)" exception entering autocomplete project tag in task comment.
Thu, Mar 21, 17:30 · PHP 8 support

Sat, Mar 16

aklapper added a comment to D25502: Make PhabricatorSearchIntField validate its input.

Would anyone give this another review? Might make sense to apply the one-liner in D25527 to have a simple test case on the Maniphest Advanced Search page

Sat, Mar 16, 07:57
aklapper added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

On the other hand, as the variable is called $html_details let's go for phutil_implode_html() to be super-safe? ping @roberto.urbani

Sat, Mar 16, 07:56 · UX

Fri, Mar 15

aklapper claimed T15650: AphrontDuplicateKeyQueryException dragging task from milestone column to main board column: Duplicate entry for key 'boardPHID'.
Fri, Mar 15, 16:45 · Affects-Wikimedia, Bug Reports
aklapper added a comment to D25546: Warn in comment field if task is closed as duplicate.

I also don't get if in this part we have access to any thing related to Maniphest, ManiphestEditEngine or this kind of stuff, to just call $something->getCommentPanelPlaceholder() and have the business logic there in the specific application itself.

Fri, Mar 15, 10:02
aklapper added a comment to T15755: PHP 7.3: strpos(): Non-string needles will be interpreted as strings (in arcanist/src/utils/PhutilSortVector.php:33).

I assume we should change strpos("\0", $value) to strpos($value, chr(0))

Fri, Mar 15, 09:01

Thu, Mar 14

aklapper added a comment to T15670: Disallow webcrawlers to index Diffusion repository commits.

A root problem is that highlighted line number(s) should be a # fragment really, to do not multiply pages exponentially.

Thu, Mar 14, 09:53 · Discussion Needed
aklapper created T15755: PHP 7.3: strpos(): Non-string needles will be interpreted as strings (in arcanist/src/utils/PhutilSortVector.php:33).
Thu, Mar 14, 08:38
aklapper updated the diff for D25501: Feed: Do not query and display data of uninstalled applications.

refactor as recommended

Thu, Mar 14, 07:33

Wed, Mar 13

aklapper accepted D25550: Avoid "Action with no effect" for auto-claim statuses after manually removing assignee.

Thanks, this is way cleaner (and slightly more performant) than my D25476. I've tested this locally, also in combination with other actions (e.g. opening another action field without changing it) and behavior is as expected.

Wed, Mar 13, 14:24
aklapper abandoned D25476: Avoid "Action with no effect" for auto-claim statuses after manually removing assignee.

Superseded by D25550

Wed, Mar 13, 14:17
aklapper added a comment to T15121: Contributor Agreement.

Would you like to go to court to defend that statement? :)

Wed, Mar 13, 12:54 · Phorge
aklapper added a comment to T15121: Contributor Agreement.

I could not sign it if it required brushing three times a day. Removed purely due to egoistic laziness reasons.

Wed, Mar 13, 12:36 · Phorge
aklapper added a comment to T15121: Contributor Agreement.

Well, I would rewrite quite a bit, so I'll post a draft here before editing directly:

Wed, Mar 13, 11:52 · Phorge

Tue, Mar 12

aklapper added a comment to T15754: PHP creation of Tasks - problem with Title in feed.

I could not even reproduce but get an informative error instead:

Tue, Mar 12, 13:39 · Maniphest, Bug Reports
aklapper added a comment to D25526: Avoid exception in revision timeline when left diff does not exist.

As Wikimedia uninstalled Differential I cannot further debug in downstream.
We can either decline the ticket and its patch for now (if someone runs into this again, they could reopen or file a new task), or could get the patch in (setting a default value) without a test plan to have more robust code. Shrug.
Opinions? :)

Tue, Mar 12, 12:45
aklapper added a comment to T15638: RuntimeException: "Undefined index" when left diff does not exist in DifferentialRevisionTimelineEngine.php.

As Wikimedia uninstalled Differential I cannot further debug in downstream.
We can either decline the ticket and its patch for now (if someone runs into this again, they could reopen or file a new task), or could get the patch in (setting a default value) without a test plan to have more robust code. Shrug.
Opinions? :)

Tue, Mar 12, 12:45

Tue, Mar 5

aklapper closed T15748: Make lipsum project generator also fill in project description as Resolved by committing rP179f866deb74: Make lipsum project generator also fill in project description.
Tue, Mar 5, 11:08 · Feature Requests
aklapper closed D25545: Make lipsum project generator also fill in project description.
Tue, Mar 5, 11:08
aklapper committed rP179f866deb74: Make lipsum project generator also fill in project description.
Make lipsum project generator also fill in project description
Tue, Mar 5, 11:08

Sun, Mar 3

aklapper awarded D25549: Add Standard Custom Fields to Item List a Love token.
Sun, Mar 3, 10:15

Sat, Mar 2

aklapper accepted D25079: Trigger: Add Sound "Coin".
Sat, Mar 2, 18:31

Fri, Mar 1

aklapper renamed T15584: Incorrectly cropped box-shadow CSS around a.button:focus from Incorrectly cropped "glow effect" CSS around some UI buttons to Incorrectly cropped box-shadow CSS around a.button:focus.
Fri, Mar 1, 13:39
aklapper added a comment to T15664: Bug: Unable to add an empty repository to an owners package.

Cannot reproduce (or I misunderstand the steps):

  1. Created https://github.com/aklapper/emptyrepository for testing
  2. Went to phorge.localhost/diffusion/edit/form/default/?vcs=git and created emptyRepo.
  3. Went to http://phorge.localhost/diffusion/26/uri/edit/208/ and set URI's I/O Type to Read Only
  4. Went to http://phorge.localhost/diffusion/26/uri/edit/ and set URI to https://github.com/aklapper/emptyrepository and I/O Type to Mirror
  5. Went to http://phorge.localhost/owners/paths/1/ , edited/removed existing path by setting it to: Include R26 emptyRepo / , and clicked "Save Paths"
Fri, Mar 1, 12:46 · Diffusion
aklapper added a revision to T15681: PHP8 error running "ssh vcs-user@phorge.yourcompany.com conduit conduit.ping": D25483: fix PHP 8 "strlen(null)" when testing the ssh setup.
Fri, Mar 1, 12:35 · PHP 8 support
aklapper updated the summary of D25483: fix PHP 8 "strlen(null)" when testing the ssh setup.
Fri, Mar 1, 12:35
aklapper renamed T15681: PHP8 error running "ssh vcs-user@phorge.yourcompany.com conduit conduit.ping" from Fresh batch of PHP 8 deprecated use of strlen with a NULL argument to PHP8 error running "ssh vcs-user@phorge.yourcompany.com conduit conduit.ping".
Fri, Mar 1, 12:35 · PHP 8 support
aklapper added a comment to T15681: PHP8 error running "ssh vcs-user@phorge.yourcompany.com conduit conduit.ping".

Second issue got already fixed by rPa7fb04f96c92d4ff57ac8c01213e6dd73a03f5d6 which wasn't linked to this ticket

Fri, Mar 1, 12:34 · PHP 8 support
aklapper added a comment to T15681: PHP8 error running "ssh vcs-user@phorge.yourcompany.com conduit conduit.ping".

@jeanguyomarch: If you could provide stacktraces of these issues, that would be awesome.

Fri, Mar 1, 12:27 · PHP 8 support
aklapper added a comment to T15681: PHP8 error running "ssh vcs-user@phorge.yourcompany.com conduit conduit.ping".

First part is D25483

Fri, Mar 1, 12:27 · PHP 8 support

Thu, Feb 29

aklapper requested review of D25546: Warn in comment field if task is closed as duplicate.
Thu, Feb 29, 17:07
aklapper added a revision to T15749: Display warning about commenting on a task which is closed as a duplicate: D25546: Warn in comment field if task is closed as duplicate.
Thu, Feb 29, 17:07 · Feature Requests
aklapper created T15749: Display warning about commenting on a task which is closed as a duplicate.
Thu, Feb 29, 16:56 · Feature Requests
aklapper requested review of D25545: Make lipsum project generator also fill in project description.
Thu, Feb 29, 15:23
aklapper added a revision to T15748: Make lipsum project generator also fill in project description: D25545: Make lipsum project generator also fill in project description.
Thu, Feb 29, 15:23 · Feature Requests
aklapper created T15748: Make lipsum project generator also fill in project description.
Thu, Feb 29, 15:15 · Feature Requests

Wed, Feb 28

aklapper closed D25543: Replace all phurl.io short URIs with target URIs.
Wed, Feb 28, 13:59
aklapper committed rP7cee42ca2601: Replace all phurl.io short URIs with target URIs.
Replace all phurl.io short URIs with target URIs
Wed, Feb 28, 13:59
aklapper closed T15746: https://phurl.io is a HTTP 503 error as Resolved by committing rARC174bf094ef9f: Replace all phurl.io short URIs with target URIs.
Wed, Feb 28, 13:59
aklapper closed D25542: Replace all phurl.io short URIs with target URIs.
Wed, Feb 28, 13:59
aklapper committed rARC174bf094ef9f: Replace all phurl.io short URIs with target URIs.
Replace all phurl.io short URIs with target URIs
Wed, Feb 28, 13:59
aklapper closed D25541: Fix typo "pohrge" in "Adding New Classes" documentation.
Wed, Feb 28, 12:52
aklapper committed rP74ec4f7882a3: Fix typo "pohrge" in "Adding New Classes" documentation.
Fix typo "pohrge" in "Adding New Classes" documentation
Wed, Feb 28, 12:52
aklapper added a comment to T15121: Contributor Agreement.

I don't think that the author should ever allow to re-license its work. [...] Normal volunteers do not accept that.

Wed, Feb 28, 12:16 · Phorge
aklapper updated the diff for D25543: Replace all phurl.io short URIs with target URIs.

Clean up my local testing mess

Wed, Feb 28, 11:39
aklapper added a comment to T15746: https://phurl.io is a HTTP 503 error.

Most phurl.io short URIs point to old upstream tasks. The two related patches make the code at least point directly to these tasks (to still be found on https://web.archive.org/ if secure.phabricator.com ever went down) as there's no direct content equivalent on phorge.it.

Wed, Feb 28, 11:34
aklapper requested review of D25543: Replace all phurl.io short URIs with target URIs.
Wed, Feb 28, 11:31
aklapper added a revision to T15746: https://phurl.io is a HTTP 503 error: D25543: Replace all phurl.io short URIs with target URIs.
Wed, Feb 28, 11:31
aklapper requested review of D25542: Replace all phurl.io short URIs with target URIs.
Wed, Feb 28, 11:29
aklapper added a revision to T15746: https://phurl.io is a HTTP 503 error: D25542: Replace all phurl.io short URIs with target URIs.
Wed, Feb 28, 11:29
aklapper added a comment to T15745: Cannot install extension "Diagrams" (Failed to load symbol "DiagramTransactionType").

@valerio.bozzolan Are there any prehistoric traces that this extension has been successfully used in the past? :P

Wed, Feb 28, 11:08 · Diagrams (Extension)
aklapper created T15746: https://phurl.io is a HTTP 503 error.
Wed, Feb 28, 08:42
aklapper requested review of D25541: Fix typo "pohrge" in "Adding New Classes" documentation.
Wed, Feb 28, 08:34
aklapper abandoned D25477: Visually indicate new user accounts.

Makes sense, thanks everyone. Let's decline for the time being.

Wed, Feb 28, 07:03

Feb 25 2024

aklapper added a comment to D25540: WIP: add PhutilRemarkupHexColorCodeRule.

Interesting. What's the use case you have in mind?

Feb 25 2024, 10:15

Feb 23 2024

aklapper added a comment to D25079: Trigger: Add Sound "Coin".
Feb 23 2024, 15:16
aklapper added a comment to D25079: Trigger: Add Sound "Coin".

I guess I'm fine with adding that mp3 file.
I am personally not convinced by the creation of src/docs/flavor/project_credits.diviner: I've seen way too many "let's create some list, with best intentions, and at some point unfortunately forget about updating it" examples in FOSS projects. Every added line in software projects creates additional maintenance costs (and in some cases bitrot); human resources are in theory unlimited and in reality rather sparse.
Credits could go into the git commit message, maybe?

Feb 23 2024, 14:52

Feb 22 2024

aklapper added a comment to T15738: "parent"/"child" relationship for "Related Revisions" is different to "Related Tasks".

See discussion and reasons in https://secure.phabricator.com/T11833

Feb 22 2024, 13:21 · UX, Differential
aklapper renamed T15738: "parent"/"child" relationship for "Related Revisions" is different to "Related Tasks" from Make "Related Revisions" more similar to "Related Tasks" (magical quiz inside) to "parent"/"child" relationship for "Related Revisions" is different to "Related Tasks".
Feb 22 2024, 13:21 · UX, Differential

Feb 13 2024

aklapper closed T15720: Improve messages when no image formats are supported (due to GD not installed) as Resolved by committing rPe2bec4c1f58b: Improve messages when no image formats are supported (due to GD not installed).
Feb 13 2024, 16:07
aklapper closed D25525: Improve messages when no image formats are supported (due to GD not installed).
Feb 13 2024, 16:07
aklapper committed rPe2bec4c1f58b: Improve messages when no image formats are supported (due to GD not installed).
Improve messages when no image formats are supported (due to GD not installed)
Feb 13 2024, 16:07
aklapper updated the diff for D25502: Make PhabricatorSearchIntField validate its input.

Remove unreached return call as pointed out by speck

Feb 13 2024, 15:58
aklapper added a comment to D25502: Make PhabricatorSearchIntField validate its input.
In D25502#15384, @speck wrote:

Is it possible to check if anything is relying on this not working with negative numbers?

Feb 13 2024, 15:56

Feb 12 2024

aklapper added a comment to D25491: Improve contrast of Links in Dark Mode.

@deric: Hi, would you like to arc land your patch, or do you need any help? Thanks in advance!

Feb 12 2024, 12:29
aklapper added a comment to D25502: Make PhabricatorSearchIntField validate its input.

For the records, adding public function getValueForQuery($value) is needed because otherwise Expected a numeric scalar or null for %d conversion. Query: project.projectDepth >= %d

Feb 12 2024, 12:28
aklapper added a comment to D25502: Make PhabricatorSearchIntField validate its input.

Would anyone fancy reviewing this? :)

Feb 12 2024, 12:27
aklapper closed T15685: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom int field configured, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Feb 12 2024, 12:26 · PHP 8 support
aklapper closed T15685: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom int field configured as Resolved by committing rP052b5f41c705: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest….
Feb 12 2024, 12:26 · PHP 8 support
aklapper closed D25489: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom int field configured.
Feb 12 2024, 12:26
aklapper committed rP052b5f41c705: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest….
Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest…
Feb 12 2024, 12:26
aklapper closed T15129: Unmark Audit as a required application as Resolved by committing rP821708414eec: Allow to uninstall (hide) Audit application.
Feb 12 2024, 11:10 · Diffusion, User-Cigaryno
aklapper closed D25503: Allow to uninstall (hide) Audit application.
Feb 12 2024, 11:10
aklapper committed rP821708414eec: Allow to uninstall (hide) Audit application.
Allow to uninstall (hide) Audit application
Feb 12 2024, 11:10
aklapper updated the diff for D25525: Improve messages when no image formats are supported (due to GD not installed).

Make code more readable

Feb 12 2024, 11:01
aklapper added a comment to D25525: Improve messages when no image formats are supported (due to GD not installed).

Maybe simplify if (empty($v)) { to just if ($v) { and swapping the case

Feb 12 2024, 11:00