Alright, even after calling ->withEpochInRange(null, null) this very code change (comparing null with null) works fine without a problem, so I'd not add that additional null check

Oh wait I totally misunderstood you, sigh

Uh, nice thought! Phorge accepts and handles correctly one or two parameters being null which I think is fine as-is, so I'd only check for switched parameters created by confused developers here.

Ooops, indeed. Thanks for finding that. Abandoning in favor of D25869.

In D25363#18825, @aklapper wrote:

• Resulting E13 still shows "Private User 1" to "Private User 5" with no user matching - I don't think that is expected but I'm not sure we want to care as that is no regression?

For consistency, I'm wondering whether to

• rename src/applications/people/menuitem/PhabricatorPeopleTasksProfileMenuItem.php to src/applications/people/menuitem/PhabricatorPeopleTasksAssignedProfileMenuItem.php,
• rename src/applications/people/controller/PhabricatorPeopleProfileTasksController.php to src/applications/people/controller/PhabricatorPeopleProfileTasksAssignedController.php,
• update const ITEM_TASKS = 'people.tasks' to const ITEM_TASKS_ASSIGNED = 'people.tasks.assigned;,
• update 'tasks/(?P<id>[1-9]\d*)/' =>'PhabricatorPeopleProfileTasksController' to 'tasks-assigned/(?P<id>[1-9]\d*)/' =>'PhabricatorPeopleProfileTasksAssignedController'

as there is more than one "task" thingie now?

In T15726#15399, @aklapper wrote:

Fund: Going to http://phorge.localhost/fund/create/ and creating a New Initiative anyway yields

EXCEPTION: (RuntimeException) Undefined array key "totalAsCurrency" at [<arcanist>/src/error/PhutilErrorHandler.php:273]

In D25864#23737, @valerio.bozzolan wrote:

Question: in an ideal world would you love even more the same button, that "just" prefills the textarea?

Eh, let's make this exit(0) as that's more consistent with existing calls in the Arcanist codebase

Thanks. I can confirm with PHP 8.4.4 after upgrading one of my machines.

Probably same game as T15679 somewhere in src/applications/phriction/controller/PhrictionMoveController.php

grep -r " id(" --include=*.php . | wc -l gives a whopping 11220 results.
Would we accept a patch if I cooked up one? :)

I fail to reproduce with PHP 8.3 with the given steps: ../arcanist/bin/arc diff --create --help prints the help as expected, with no error.
Which PHP version do you use?

git rebase master

Okay, got to wait until D25885 is merged first

Okay, got to wait until D25885 is merged first

Let's try again without celerity noise

I wonder what's wrong with my CSS/JS, sigh

As I uploaded a new diff now how do I request a new review / reset the existing one "Changes Requested"?
"Foist Upon", or which vaguely named oh so "funny" option from the "Add Action..." dropdown which makes non-native speakers feel stupid and be scared to choose the wrong option? Oh UX and usability...

having a portal with something useful (e.g. a Dashboard): shows the Dashboard

Run ./bin/celerity map

Rename function to override from parent class, as proposed by Valerio

Right, PhabricatorDashboardPortalProfileMenuEngine extends PhabricatorProfileMenuEngine so we can override newNoContentView()... that probably makes most sense, thanks

I'd love to see better steps to reproduce something somewhere. :-/ I cannot even find e.p.p. or epp. somewhere in the Finnish translations anymore...

I expanded the test plan a bit, still if there is more to add please also expand. This seems to work for me (phamous last words)

Fix unaligned elements by changing margin-left: -200px to -200px for div.phui-document-content and for full-size images

git rebase master

./bin/celerity map as this touches a JS file

@mturdus: Could you land this one please, or would you like any help? Thanks!

@valerio.bozzolan: Would you like to give this a (hopefully) final review? TIA!

Setting Request Changes per the small review comments so far (as I am looking at https://we.phorge.it/differential/query/all/ and it helps to see correct statuses)

Thanks for the patch! I can confirm that after applying the patch, on PHP 8.3 I can successful create the initiative http://phorge.localhost/I4 (and I get an unrelated PHP 8.1 deprecation warning about strlen(): Passing null to parameter #1 in src/applications/fund/xaction/FundInitiativeDescriptionTransaction.php:19)

This is impressive, thanks for writing this up! I don't have enough expertise to comment on the "Edit Phases", however all in all this looks super helpful for technical understanding!

Confirming that this works as expected. I took the liberty to expand the commit message to also include the current error message.

With D25878 applied, dialog for folks who can use Herald:

null as fast as possible

Errm yes, now for real

Short-circuit null check, as rightfully proposed by Valerio

No, because people do not read. The "read-only mirror" Wikimedia and GNOME code repos on GitHub regularly receive pull requests because people do not read anything.