In D25912#24618, @valerio.bozzolan wrote:

P.S. maybe if the task number is very small (e.g. 2) maybe we can still allow that.

I believe that this is not the correct approach, thus abandoning.

I now realize that this is not about hierarchy (documents below other documents) but about the Table of Contents within a single wiki page? You may want to edit the title.

In T16007#21196, @Cigaryno wrote:

It depends on who on the wild (including large private companies developing closed-source software) is using prototype applications on Phorge.

See T15501: Voluntary Usage Survey App basically.

Or even better, hold a Slowvote

Please no popularity contests (with even higher self-selection bias)...

Hmm, maybe should not change ->setURI("/people/tasks/{$id}/") because there might be external third-party code relying on this?

@Cigaryno: Oops, I am sorry! I had forgotten that this proposal also existed as it wasn't linked under "Revisions and Commits" in T16007. My fault. :-/

Hej hej and welcome! I'm afraid I cannot really follow... In my understanding the hierarchy is expressed via the breadcrumbs navigation right below the top bar and not at the bottom, at least for a screen width of 513px and more?
For example if I go to https://we.phorge.it/w/changelog/next_up/ , see the Phriction > Welcome to the Phorge Wiki > Change Log > Next Up breadcrumbs.

where did my closing brakets go?

Grazie milée!

Sure, let's try again, why not

Make arc lint happier

@keithzg: Thanks for testing. Did you spot any explosions? I'm now also considering to deploy to our downstream instance for a week to see if anything goes wrong...

Is your Aphlict Server up and running?

Looks good to me. Feel free to land. Thanks for the patch!

@speck: Hi, would you be willing to land this? Thanks in advance!

Fix a typo

make linter happier

Add some more stuff (final change; moving on to other code areas for now)

Make funtion private now that it's all in the same class; fix a doc typo

Directly put the text of the previous milestone into the description field and display additional info about this new behavior. Less code complexity, less manual user actions.

I do not think changes are necessarily needed, because it already says "With rare exceptions".
Regarding the proposal, I do not believe that "prototype applications [...] are often subject to significant changes" either.

@Cigaryno: That only works in Phorge itself. See:

as rich text and/or in common markup formats

Rip out more unused ancient code like unneeded expensive database queries

It seems that there is even more code to rip out here

Thanks. I'm personally fine with bug fixes for prototype apps.

Per comments in T16006 this is rather workaround (ignore) instead of a fix (make it work).

Replace renderHandleLink() with renderHandle() and not renderObject(), as rightfully pointed out by mainframe98

Ah, thanks, that makes more sense, indeed. (I dislike changes that have an unclear reproduction path.)

@Cigaryno: Please provide references when you quote something from somewhere so others don't have to guess where to find things. Thanks!

rebase

Thanks, I can confirm that this works as expected. :)
I agree biggest question is where to put this. In my opinion the UX is already slightly inconsistent (given their are also concepts like "Related tasks" in Pholio or "Referenced Files" in tasks).
In Differential it feels a bit like a stretch to put this into a box called Revision Contents.
In Maniphest the same "Mentions" tab is in the Related Objects box; there is nothing similar in Differential which already has numerous boxes (also Details and Diff Detail but none of those have tabs).

Superseded by D25861

@xtex: Hi, would you like to arc land your patch? Or do you need any help? Thanks!

@xtex: Hi, would you like to arc land your patch? Or do you need any help? Thanks!

In D25886#23757, @valerio.bozzolan wrote:

Finally something that can be tested using arc anoid - I guess?

rebase? please?

./bin/celerity map for real, sigh

rebase to drop unrelated wrong celerity map change

Yes, I'd like to see this merged, as it fixes going to my local user profile currently only showing

PhutilAggregateException
Encountered a processing exception, then another exception when trying to build a response for the first exception.
- RuntimeException: Undefined array key "totalAsCurrency"
- RuntimeException: Undefined array key "totalAsCurrency"

on PHP 8.3.17 after performing the steps in the Test Plan above.

Beforehand,

• Created a publisher at http://phorge.localhost/packages/publisher/edit/form/default/ but afterwards, http://phorge.localhost/packages/package/publisher/edit/1/ is a 404.
• Created a package at http://phorge.localhost/packages/package/edit/form/default/ but afterwards, http://phorge.localhost/packages/package/package/edit/1/ is a 404.
• Created a version at http://phorge.localhost/packages/version/edit/form/default/ but afterwards, http://phorge.localhost/packages/package/version/edit/1/ is a 404.
• Going to http://phorge.localhost/packages/ is a 404, had to go to http://phorge.localhost/packages/package/ instead.

After applying this patch locally, all these four URIs work as expected.

setControlInstructions() is the right approach, after looking at other usage of it.
Tested the patch locally and works as expected.
I'd probably rephrase to "Callsign is the monogram rXXXX for this repository. It cannot contain spaces." and "Short Name is part of the URI paths for this repository. It cannot contain spaces." (we don't seem to use "repo" but only "repository" across the codebase, and use full stops), and drop the Placeholders, and rename the patch to "Show descriptions for "Callsign" and "Short Name" Repository form fields" (or such).
Apart from all that my nitpicking, good to go. Thanks for the patch!

Rename source files from Tasks to TasksAssigned for consistency; update two more exposed strings