Page MenuHomePhorge

aklapper (Andre Klapper)
Bot

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 28 2023, 20:44 (113 w, 6 d)
Availability
Available

Recent Activity

Today

aklapper added a comment to D25987: Add CSS class to object handle if user object is system agent.

Uhm. I don't know why but locally I cannot find the selector.

Tue, May 6, 16:27
aklapper added inline comments to D25847: Remarkup: harden how we recognize internal/external URIs (mailto, mobile phones, ...).
Tue, May 6, 07:03 · Remarkup

Sun, May 4

aklapper requested review of D25989: Remove macOS specific font smoothing CSS.
Sun, May 4, 12:16
aklapper added a revision to T16059: Remove -webkit-font-smoothing and -moz-osx-font-smoothing from CSS: D25989: Remove macOS specific font smoothing CSS.
Sun, May 4, 12:15 · Wikimedia Hackathon 2025
aklapper updated the task description for T16059: Remove -webkit-font-smoothing and -moz-osx-font-smoothing from CSS.
Sun, May 4, 12:06 · Wikimedia Hackathon 2025
aklapper created T16059: Remove -webkit-font-smoothing and -moz-osx-font-smoothing from CSS.
Sun, May 4, 12:03 · Wikimedia Hackathon 2025
valerio.bozzolan awarded T16058: Workboard column triggers: Allow assigning to user performing the move a Yellow Medal token.
Sun, May 4, 11:02 · Wikimedia Hackathon 2025, Feature Requests
aklapper added a comment to T16058: Workboard column triggers: Allow assigning to user performing the move.

I have a patch ready, need to clean up and test more

Sun, May 4, 10:22 · Wikimedia Hackathon 2025, Feature Requests
aklapper created T16058: Workboard column triggers: Allow assigning to user performing the move.
Sun, May 4, 10:22 · Wikimedia Hackathon 2025, Feature Requests
aklapper added inline comments to D25847: Remarkup: harden how we recognize internal/external URIs (mailto, mobile phones, ...).
Sun, May 4, 09:12 · Remarkup
aklapper edited the content of Next Up.
Sun, May 4, 08:15
aklapper closed T16005: Remove unused table code in ManiphestReportController::renderBurn() as Resolved.
Sun, May 4, 08:12 · Wikimedia Hackathon 2025
aklapper added a comment to T15564: Allow yourself to be Invited in Imported Events.

Can this be resolved? If not, what exactly is left in this task (apart from separate T15803)?

Sun, May 4, 08:09 · Wikimedia Hackathon 2025, User-valerio.bozzolan, Calendar
aklapper closed D25902: Remove unused code in ManiphestReportController::renderBurn().
Sun, May 4, 08:05
aklapper committed rP9047e940e063: Remove unused code in ManiphestReportController::renderBurn().
Sun, May 4, 08:05

Sat, May 3

aklapper moved T16046: CSS: Add "clip-path" as progressive enhancement for deprecated "clip" property from Plz Review 🥺 to We did it 😍 on the Wikimedia Hackathon 2025 board.
Sat, May 3, 22:00 · Wikimedia Hackathon 2025
aklapper closed T16046: CSS: Add "clip-path" as progressive enhancement for deprecated "clip" property as Resolved by committing rP261fdca137e5: CSS: Add "clip-path" to deprecated "clip" property.
Sat, May 3, 21:59 · Wikimedia Hackathon 2025
aklapper closed D25983: CSS: Add "clip-path" to deprecated "clip" property.
Sat, May 3, 21:59
aklapper edited the content of Next Up.
Sat, May 3, 21:59
aklapper committed rP261fdca137e5: CSS: Add "clip-path" to deprecated "clip" property.
Sat, May 3, 21:59
aklapper edited the content of Next Up.
Sat, May 3, 21:49
aklapper added a comment to D25988: transaction.search: add auto-generated documentation for objectType and handle unmanaged exception.

Should ideally use the same error message as in https://we.phorge.it/source/phorge/browse/master/src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php;4862eada5cd05236b81487b261668f2a2d72fad7$382-387 so one string less to translate.

Sat, May 3, 14:47
aklapper updated the summary of D25988: transaction.search: add auto-generated documentation for objectType and handle unmanaged exception.
Sat, May 3, 14:45
aklapper added a comment to D25987: Add CSS class to object handle if user object is system agent.

having "User Bot" possibly everywhere? 🌈

Sat, May 3, 09:14
aklapper added a comment to T16050: Make it easier for CSS customization to apply to comments by specific users/bots.

Personally I'd decline T16052 (data duplication) and I do not yet see a need for potential new transaction types either (a comment is a comment is a comment no matter who/what made it).

Sat, May 3, 09:07 · Feature Requests, Comments
aklapper updated the diff for D25987: Add CSS class to object handle if user object is system agent.

always set a bool so we have an explicit value and don't just fallback to "false"

Sat, May 3, 00:04

Fri, May 2

aklapper updated the diff for D25987: Add CSS class to object handle if user object is system agent.

Don't bool with the bool otherwise it bools

Fri, May 2, 23:57
aklapper requested review of D25987: Add CSS class to object handle if user object is system agent.
Fri, May 2, 23:53
aklapper added a revision to T16051: Add a CSS class on comments to indicate whether the comment author is a bot: D25987: Add CSS class to object handle if user object is system agent.
Fri, May 2, 23:53 · Wikimedia Hackathon 2025, Feature Requests, Comments
aklapper closed D25752: Fix call to undefined method PhrictionDocumentTitleTransaction::renderHandleLink().
Fri, May 2, 16:36 · Phriction
aklapper committed rP6b9b0490ddf5: Fix call to undefined method PhrictionDocumentTitleTransaction….
Fri, May 2, 16:36
aklapper added inline comments to D25823: arc browse: add support to Subversion repos.
Fri, May 2, 15:40 · Arcanist
aklapper accepted D25363: Calendar Import: calendar uploader is not anymore an alien.

works-on-my-machine.jpg (191×199 px, 21 KB)

Fri, May 2, 15:27
aklapper added a comment to D25363: Calendar Import: calendar uploader is not anymore an alien.

After a conversation with valerio, I probably had misunderstood the feature scope in my comment D25363#18825: When I tested if this also matches for a user who is not the user importing the event into the calendar.
As a note to myself, the commit message says:

WE DO NOT MATCH OTHER USERS BUT THE CALENDAR OWNER.

Fri, May 2, 15:20
aklapper added a comment to D25823: arc browse: add support to Subversion repos.

Seems to work locally.

Fri, May 2, 15:20 · Arcanist
aklapper requested review of D25985: Remove some unused CSS files.
Fri, May 2, 15:20

Thu, May 1

aklapper added a project to D25749: Fix call to undefined HarbormasterBuildMessageRestartTransaction::isFailed(): Wikimedia Hackathon 2025.
Thu, May 1, 22:57 · Wikimedia Hackathon 2025, Almanac/Drydock/Harbormaster
aklapper closed D25749: Fix call to undefined HarbormasterBuildMessageRestartTransaction::isFailed().
Thu, May 1, 22:56 · Wikimedia Hackathon 2025, Almanac/Drydock/Harbormaster
aklapper committed rPee9991d3c995: Fix call to undefined HarbormasterBuildMessageRestartTransaction::isFailed().
Thu, May 1, 22:56
aklapper added a comment to D25749: Fix call to undefined HarbormasterBuildMessageRestartTransaction::isFailed().

I am excited to announce that I personally watched @valerio.bozzolan crash Harbormaster's build and then load this awesome code into his PC computer machine and then repeat Harbormaster's build and then Harbormaster's build did not crash anymore. Therefore we decided that this awesome code is very good and as a courtesy to every Harbormaster out there will be made available for free, without any charge.

Thu, May 1, 22:56 · Wikimedia Hackathon 2025, Almanac/Drydock/Harbormaster
aklapper added a comment to D25983: CSS: Add "clip-path" to deprecated "clip" property.

Testing welcome.
Input from CSS folks welcome.

Thu, May 1, 12:28
aklapper requested review of D25983: CSS: Add "clip-path" to deprecated "clip" property.
Thu, May 1, 12:27
aklapper added a revision to T16046: CSS: Add "clip-path" as progressive enhancement for deprecated "clip" property: D25983: CSS: Add "clip-path" to deprecated "clip" property.
Thu, May 1, 12:27 · Wikimedia Hackathon 2025
aklapper added a comment to T16046: CSS: Add "clip-path" as progressive enhancement for deprecated "clip" property.

From a quick look it seems that clip: rect(0 0 0 0) is very much the same as clip: rect(1px, 1px, 1px, 1px) (make things invisible and only found by screenreaders), and clip-path: inset(50%) (covering each side by 50%) is very much the same outcome as clip-path: inset(100%).

Thu, May 1, 12:24 · Wikimedia Hackathon 2025
aklapper created T16046: CSS: Add "clip-path" as progressive enhancement for deprecated "clip" property.
Thu, May 1, 12:01 · Wikimedia Hackathon 2025
aklapper edited the content of Next Up.
Thu, May 1, 11:01
aklapper closed D25972: Remove non-existing min-device-pixel-ratio CSS syntax.
Thu, May 1, 10:59
aklapper committed rPb578854017fc: Remove non-existing min-device-pixel-ratio CSS syntax.
Thu, May 1, 10:59
aklapper edited the content of Next Up.
Thu, May 1, 10:43
aklapper edited the content of Next Up.
Thu, May 1, 10:42
aklapper edited the content of 2024 week 35.
Thu, May 1, 10:40
aklapper closed T16037: Bump ws npm package for Aphlict as Resolved by committing rPde2b53638299: Aphlict: Bump NodeJS package ws from 7.5.0 to 7.5.10.
Thu, May 1, 10:38 · Security, Aphlict
aklapper closed D25967: Aphlict: Bump NodeJS package ws from 7.5.0 to 7.5.10.
Thu, May 1, 10:38
aklapper committed rPde2b53638299: Aphlict: Bump NodeJS package ws from 7.5.0 to 7.5.10.
Thu, May 1, 10:38
aklapper added a comment to D25967: Aphlict: Bump NodeJS package ws from 7.5.0 to 7.5.10.

@aklapper want to land this?

Thu, May 1, 10:38

Wed, Apr 30

aklapper added a comment to D25676: DifferentialRevisionQuery: avoid nonsense query comparing r.authorPHID with project PHIDs.

Ah...I may take another look (jmeador: Feel of course also very free to commandeer this back to you)

Wed, Apr 30, 16:42 · Differential
aklapper retitled D25676: DifferentialRevisionQuery: avoid nonsense query comparing r.authorPHID with project PHIDs from Fix responsible authors in DifferentialRevisionQuery to Make responsible authors in DifferentialRevisionQuery only include users.
Wed, Apr 30, 16:32 · Differential
aklapper added a comment to D25676: DifferentialRevisionQuery: avoid nonsense query comparing r.authorPHID with project PHIDs.

Ah sorry for maybe stepping on toes, and welcome back! :)

Wed, Apr 30, 16:31 · Differential
aklapper updated the diff for D25676: DifferentialRevisionQuery: avoid nonsense query comparing r.authorPHID with project PHIDs.

Seems @jmeador is AWOL thus updating per last comment

Wed, Apr 30, 16:01 · Differential
aklapper commandeered D25676: DifferentialRevisionQuery: avoid nonsense query comparing r.authorPHID with project PHIDs.

seems @jmeador is AWOL thus boldly commandeering

Wed, Apr 30, 15:59 · Differential
aklapper renamed T16044: Diviner: All Method and File query results have invalid 404 URIs from Diviner: All Method query results have invalid 404 URIs to Diviner: All Method and File query results have invalid 404 URIs.
Wed, Apr 30, 15:31
aklapper added a comment to T16044: Diviner: All Method and File query results have invalid 404 URIs.

Digging a bit further, rP600a3e3b7c2de5d93644e0410cd354ea6752949d implies that methods and files should not be indexed at all and not show up in the results. See also T16045#21931.

Wed, Apr 30, 15:30
aklapper added a comment to T16045: All @{method:...} links in Diviner docs result in a "Documentation Not Found" error.

A quick fix would be removing the single line $query->withIsDocumentable(true); in https://we.phorge.it/source/phorge/browse/master/src/applications/diviner/controller/DivinerFindController.php;85f51c54303fe50ebc09ee0b652033a8a9f29ab1$45
as that'll allow results for Methods.

Wed, Apr 30, 14:58
aklapper edited the content of Next Up.
Wed, Apr 30, 14:39
aklapper renamed T16044: Diviner: All Method and File query results have invalid 404 URIs from Diviner: All Method query results have invalid URIs to Diviner: All Method query results have invalid 404 URIs.
Wed, Apr 30, 14:33
aklapper created T16045: All @{method:...} links in Diviner docs result in a "Documentation Not Found" error.
Wed, Apr 30, 14:33
valerio.bozzolan awarded T16044: Diviner: All Method and File query results have invalid 404 URIs a Yellow Medal token.
Wed, Apr 30, 14:28
aklapper added a revision to T16044: Diviner: All Method and File query results have invalid 404 URIs: D25812: Fix method search result URIs in Diviner.
Wed, Apr 30, 14:27
aklapper updated the summary of D25812: Fix method search result URIs in Diviner.
Wed, Apr 30, 14:27 · Diviner
aklapper created T16044: Diviner: All Method and File query results have invalid 404 URIs.
Wed, Apr 30, 14:27
aklapper updated the diff for D25967: Aphlict: Bump NodeJS package ws from 7.5.0 to 7.5.10.

also manually bump version in package.json; then running npm install results in another bump in package-lock.json

Wed, Apr 30, 10:50
aklapper added a comment to D25967: Aphlict: Bump NodeJS package ws from 7.5.0 to 7.5.10.

Both are good questions. I only put here the diff which npm created. First question: Very likely Yes.
(Note that I have no knowledge in this area and don't even know why both package-lock.json and package.json are needed.)

Wed, Apr 30, 10:49
aklapper closed D25979: Fix invalid return values for void.
Wed, Apr 30, 06:50
aklapper committed rPc51002398d63: Fix invalid return values for void.
Wed, Apr 30, 06:50
aklapper closed T15959: Modified files not counted in total when attaching files as Resolved by committing rP44c7bfb42ddf: Include number of modified files in total of attached files.
Wed, Apr 30, 06:46 · Good Starter Task, Bug Reports, Files
aklapper closed D25892: Include number of modified files in total of attached files.
Wed, Apr 30, 06:46
aklapper committed rP44c7bfb42ddf: Include number of modified files in total of attached files.
Wed, Apr 30, 06:46
aklapper closed D25981: PHPDoc: Correct syntax of variadic function params.
Wed, Apr 30, 06:45
aklapper committed rARC80906355979a: PHPDoc: Correct syntax of variadic function params.
Wed, Apr 30, 06:45
aklapper closed D25980: PHPDoc: Correct syntax of variadic function params.
Wed, Apr 30, 06:44
aklapper committed rP3f49ac5b484c: PHPDoc: Correct syntax of variadic function params.
Wed, Apr 30, 06:44
aklapper committed rPff6a998f2320: Strip surrounding whitespace from project and task titles.
Wed, Apr 30, 06:36
aklapper closed D25835: Strip surrounding whitespace from project and task titles.
Wed, Apr 30, 06:36 · Projects, Maniphest

Tue, Apr 29

aklapper edited the content of Next Up.
Tue, Apr 29, 20:11
aklapper updated the diff for D25979: Fix invalid return values for void.

Remove "return;" lines

Tue, Apr 29, 20:04
aklapper closed D25982: Remove doc references to LiskDAO::loadRelatives().
Tue, Apr 29, 20:00
aklapper committed rP1d27fde0186b: Remove doc references to LiskDAO::loadRelatives().
Tue, Apr 29, 19:59
aklapper requested review of D25982: Remove doc references to LiskDAO::loadRelatives().
Tue, Apr 29, 18:32
aklapper updated the diff for D25835: Strip surrounding whitespace from project and task titles.

gotta set it

Tue, Apr 29, 13:13 · Projects, Maniphest
aklapper updated the diff for D25835: Strip surrounding whitespace from project and task titles.

like this I guess

Tue, Apr 29, 13:01 · Projects, Maniphest
aklapper retitled D25980: PHPDoc: Correct syntax of variadic function params from PHPDoc: Correct syntax of variadic functions' params
Tue, Apr 29, 11:29
aklapper retitled D25981: PHPDoc: Correct syntax of variadic function params from PHPDoc: Correct syntax of variadic functions' params
Tue, Apr 29, 11:29
aklapper requested review of D25981: PHPDoc: Correct syntax of variadic function params.
Tue, Apr 29, 11:28
aklapper requested review of D25980: PHPDoc: Correct syntax of variadic function params.
Tue, Apr 29, 11:27
aklapper requested review of D25979: Fix invalid return values for void.
Tue, Apr 29, 11:21

Mon, Apr 28

aklapper updated the diff for D25972: Remove non-existing min-device-pixel-ratio CSS syntax.

git rebase master

Mon, Apr 28, 20:58
aklapper updated the summary of D25978: Fix wrong argument count in numerous calls' signatures.
Mon, Apr 28, 20:57
aklapper closed D25973: Correct invalid min-height CSS value.
Mon, Apr 28, 20:54
aklapper committed rPdc32286e4c52: Correct invalid min-height CSS value.
Mon, Apr 28, 20:54
aklapper edited the content of Next Up.
Mon, Apr 28, 20:54