Page MenuHomePhorge

aklapper (Andre Klapper)
Bot

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 28 2023, 20:44 (111 w, 15 h)
Availability
Available

Recent Activity

Today

aklapper created T16035: Update embedded copy of Font Awesome 4.7.0.
Wed, Apr 16, 09:25
aklapper updated the test plan for D25965: Disable opening of hovercard if trigger node is inside hovercard.
Wed, Apr 16, 09:13
aklapper retitled D25965: Disable opening of hovercard if trigger node is inside hovercard from Disables opening of hovercard if trigger node is inside hovercard
Wed, Apr 16, 09:13
aklapper accepted D25965: Disable opening of hovercard if trigger node is inside hovercard.

Uh nice, thank you! This seems to work as expected:

Screenshot From 2025-04-16 11-10-04.png (289×916 px, 66 KB)

Wed, Apr 16, 09:13
aklapper updated the summary of D25965: Disable opening of hovercard if trigger node is inside hovercard.
Wed, Apr 16, 07:42
aklapper edited the content of Next Up.
Wed, Apr 16, 07:29

Yesterday

aklapper edited the content of Next Up.
Tue, Apr 15, 15:04
aklapper created T16033: "To:" and "CC:" Recipient Hint footers in mail notifications list disabled user accounts.
Tue, Apr 15, 06:24

Mon, Apr 14

aklapper closed T16032: DiffusionCommitQuery passes duplicate CommitterIdentity values to PhabricatorRepositoryIdentityQuery as Resolved by committing rP7a29a6d15278: Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery.
Mon, Apr 14, 20:21
aklapper closed D25964: Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery.
Mon, Apr 14, 20:21
aklapper committed rP7a29a6d15278: Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery.
Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery
Mon, Apr 14, 20:21
aklapper requested review of D25964: Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery.
Mon, Apr 14, 12:18
aklapper added a revision to T16032: DiffusionCommitQuery passes duplicate CommitterIdentity values to PhabricatorRepositoryIdentityQuery: D25964: Pass unique CommitterIdentity values to PhabricatorRepositoryIdentityQuery.
Mon, Apr 14, 12:18
aklapper created T16032: DiffusionCommitQuery passes duplicate CommitterIdentity values to PhabricatorRepositoryIdentityQuery.
Mon, Apr 14, 12:13
aklapper edited the content of Next Up.
Mon, Apr 14, 10:14
aklapper updated the summary of D25957: Replace usages of PhutilProxyException.
Mon, Apr 14, 07:15
aklapper accepted D25957: Replace usages of PhutilProxyException.

Thanks! Accepting per testing in D25956#25577

Mon, Apr 14, 07:15

Sun, Apr 13

aklapper closed T16030: Expose time with File upload date as Resolved by committing rPafd21b827434: Expose time with File upload date.
Sun, Apr 13, 21:57
aklapper closed D25961: Expose time with File upload date.
Sun, Apr 13, 21:57
aklapper committed rPafd21b827434: Expose time with File upload date.
Expose time with File upload date
Sun, Apr 13, 21:57

Sat, Apr 12

aklapper closed D25942: Herald Transcripts: Use μs instead of us for microseconds.
Sat, Apr 12, 23:24
aklapper committed rP08637ce082d0: Herald Transcripts: Use μs instead of us for microseconds.
Herald Transcripts: Use μs instead of us for microseconds
Sat, Apr 12, 23:24
aklapper added a revision to T16030: Expose time with File upload date: D25961: Expose time with File upload date.
Sat, Apr 12, 22:58
aklapper requested review of D25961: Expose time with File upload date.
Sat, Apr 12, 22:58
aklapper created T16030: Expose time with File upload date.
Sat, Apr 12, 22:55
aklapper closed D25880: Replace some AphrontView::setUser() calls with AphrontView::setViewer().
Sat, Apr 12, 22:46
aklapper committed rP4d98c0a45586: Replace some AphrontView::setUser() calls with AphrontView::setViewer().
Replace some AphrontView::setUser() calls with AphrontView::setViewer()
Sat, Apr 12, 22:46
aklapper updated the summary of D25957: Replace usages of PhutilProxyException.
Sat, Apr 12, 20:52
aklapper accepted D25900: Remove the onboard "mailKey" from Paste.

I had to go dig for this, but from what I understand of looking at PhabricatorMetaMTAMailProperties, which is the class now responsible for this functionality, creating a mail key only happens when its loadMailKey method is called. That method is only called when email functionality engaged.

Sat, Apr 12, 20:46
aklapper updated the summary of D25956: Replace usages of PhutilProxyException.
Sat, Apr 12, 20:46
aklapper accepted D25956: Replace usages of PhutilProxyException.

Thanks! Small nitpick: I'd probably change @deprecated call Exception::getPrevious directly. to @deprecated Call Exception::getPrevious() directly.

Sat, Apr 12, 20:45
aklapper added a comment to D25900: Remove the onboard "mailKey" from Paste.

What is (or rather was, I guess) that mailKey thingie good for? Or more relevant, I assume it's intentionally after performing the Test Plan steps above that creating a new Paste does not create a new row in phabricator_metamta.metamta_mailproperties?
Apart from that, seems to work as expected. :) Thanks!

Sat, Apr 12, 11:06
aklapper updated the test plan for D25900: Remove the onboard "mailKey" from Paste.
Sat, Apr 12, 11:01

Fri, Apr 11

aklapper requested review of D25958: PHPDoc: Fix @return string for methods which can also return null.
Fri, Apr 11, 09:51
aklapper edited the content of Next Up.
Fri, Apr 11, 08:55
aklapper closed T15985: Fix UX regression in Phame as Resolved by committing rP12991c0d377a: Fix overlapping elements in Phame for >1791px width.
Fri, Apr 11, 08:54 · Phame, Bug Reports, UX
aklapper closed T15985: Fix UX regression in Phame, a subtask of T15920: Make table of contents visible when using wide screens, as Resolved.
Fri, Apr 11, 08:54 · UX, Feature Requests
aklapper closed D25873: Fix overlapping elements in Phame for >1791px width.
Fri, Apr 11, 08:54
aklapper committed rP12991c0d377a: Fix overlapping elements in Phame for >1791px width.
Fix overlapping elements in Phame for >1791px width
Fri, Apr 11, 08:54
aklapper updated the diff for D25873: Fix overlapping elements in Phame for >1791px width.

git rebase master

Fri, Apr 11, 08:53
aklapper updated the diff for D25955: Unhandled Exception: Add last call to error message.

Strip proceeding slash of path; wrap error message in quotation marks

Fri, Apr 11, 07:02

Thu, Apr 10

aklapper updated the diff for D25955: Unhandled Exception: Add last call to error message.

Only expose last call location if phabricator.developer-mode is set

Thu, Apr 10, 11:21
aklapper updated the diff for D25955: Unhandled Exception: Add last call to error message.

Thanks! Indeed I should have tested this more.

Thu, Apr 10, 11:17
valerio.bozzolan awarded T16027: People Search: Allow querying by project membership a Like token.
Thu, Apr 10, 10:15 · Feature Requests
aklapper created T16027: People Search: Allow querying by project membership.
Thu, Apr 10, 09:41 · Feature Requests
aklapper updated the task description for T16026: Provide a standard custom "Due Date" / Deadline field for tasks.
Thu, Apr 10, 09:07 · Feature Requests
aklapper created T16026: Provide a standard custom "Due Date" / Deadline field for tasks.
Thu, Apr 10, 09:06 · Feature Requests
aklapper added a project to T15846: Show previous value in transaction title when removing points or a custom field value set at task initialization: Affects-Wikimedia.
Thu, Apr 10, 08:31 · Affects-Wikimedia

Wed, Apr 9

aklapper renamed T15904: Tech Debt: Replace calls to PhutilProxyException with PhutilErrorHandler from Replace calls to PhutilProxyException with PhutilErrorHandler to Tech Debt: Replace calls to PhutilProxyException with PhutilErrorHandler.
Wed, Apr 9, 10:34
aklapper removed a parent task for T15354: Exception when trying to create Pholio mock without name: T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4.
Wed, Apr 9, 08:38
aklapper removed a subtask for T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4: T15354: Exception when trying to create Pholio mock without name.
Wed, Apr 9, 08:38 · PHP 8 support

Tue, Apr 8

aklapper requested review of D25955: Unhandled Exception: Add last call to error message.
Tue, Apr 8, 18:24
aklapper added a revision to T15689: built in exception display is missing top line: D25955: Unhandled Exception: Add last call to error message.
Tue, Apr 8, 18:24 · Phorge Development Tools
aklapper edited the content of Next Up.
Tue, Apr 8, 17:17
aklapper requested review of D25954: PHPDoc: Correct marker in one class header.
Tue, Apr 8, 16:07
aklapper requested review of D25953: PHPDoc: Replace invalid "key" and "value" types.
Tue, Apr 8, 15:49
aklapper requested review of D25952: PHPDoc: Replace invalid "obj" with "object".
Tue, Apr 8, 15:44
aklapper requested review of D25951: PHPDoc: Replace invalid "obj" with "object".
Tue, Apr 8, 15:36
aklapper closed D25937: PHPDoc: Make some parameter types match type in signatures.
Tue, Apr 8, 09:00
aklapper committed rP75d8c84c1372: PHPDoc: Make some parameter types match type in signatures.
PHPDoc: Make some parameter types match type in signatures
Tue, Apr 8, 09:00
aklapper closed D25941: PhabricatorCustomField: Fix a typo in PHPDoc.
Tue, Apr 8, 09:00
aklapper committed rPbf39f021d626: PhabricatorCustomField: Fix a typo in PHPDoc.
PhabricatorCustomField: Fix a typo in PHPDoc
Tue, Apr 8, 09:00
aklapper closed T15992: PHP 8.1 "strlen(null)" exception adding an MFA provider, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Tue, Apr 8, 08:59 · PHP 8 support
aklapper closed T15992: PHP 8.1 "strlen(null)" exception adding an MFA provider as Resolved by committing rPef3e0a75f62e: Fix PHP 8.1 "strlen(null)" exception in Feed setting up MFA.
Tue, Apr 8, 08:59 · Auth, PHP 8 support
aklapper closed D25867: Fix PHP 8.1 "strlen(null)" exception in Feed setting up MFA.
Tue, Apr 8, 08:59
aklapper committed rPef3e0a75f62e: Fix PHP 8.1 "strlen(null)" exception in Feed setting up MFA.
Fix PHP 8.1 "strlen(null)" exception in Feed setting up MFA
Tue, Apr 8, 08:59

Mon, Apr 7

aklapper closed T16025: Tech Debt: Complete session digest migration from SHA1 to SHA256 as Resolved by committing rP964b1d4b3dca: Complete session digest migration from SHA1 to SHA256.
Mon, Apr 7, 21:46
aklapper closed D25949: Complete session digest migration from SHA1 to SHA256.
Mon, Apr 7, 21:46
aklapper committed rP964b1d4b3dca: Complete session digest migration from SHA1 to SHA256.
Complete session digest migration from SHA1 to SHA256
Mon, Apr 7, 21:46
aklapper accepted D25256: Fix PHP 8.1 "strlen(null)" exception on auth email message body when PhabricatorAuthMessage is unset.

@mturdus: Could you land this one please, or would you like any help? Thanks!

Mon, Apr 7, 21:23 · PHP 8 support
aklapper accepted D25946: Remove support for PHP mysql extension.
  • Apply this patch on a Fedora 42 system with PHP 8.4.5. php -m listed mysqli, mysqlnd, pdo_mysql etc.
  • Uninstall php-mysqlnd package. After reboot, php -m does not list those three modules anymore, and Phorge complains Required PHP extensions are not installed: mysqli as expected.
  • Install package again, Phorge works: "Unresolved setup issues" still lists the same MySQL related stuff as before; /config/clusters/databases shows entry as usual; successfully filed a Maniphest task.
  • Open /etc/php.ini and set mysqli.allow_local_infile = On. Restart Apache HTTPD. "Unresolved setup issues" in Phorge shows Unsafe "MySQL "local_infile" Setting Enabled as expected.
Mon, Apr 7, 21:13
aklapper updated the test plan for D25950: Remove PHP APC support and APC references.
Mon, Apr 7, 20:47
aklapper updated the test plan for D25949: Complete session digest migration from SHA1 to SHA256.
Mon, Apr 7, 20:43
aklapper updated the summary of D25942: Herald Transcripts: Use μs instead of us for microseconds.
Mon, Apr 7, 20:15
aklapper closed D25933: Remove several unused private functions.
Mon, Apr 7, 20:14
aklapper committed rPd5ade92fd0d4: Remove several unused private functions.
Remove several unused private functions
Mon, Apr 7, 20:14
aklapper edited the content of Next Up.
Mon, Apr 7, 20:13
aklapper closed D25947: Remove setup check for safe_mode removed in PHP 5.4.
Mon, Apr 7, 20:12
aklapper committed rP969904e7fa3f: Remove setup check for safe_mode removed in PHP 5.4.
Remove setup check for safe_mode removed in PHP 5.4
Mon, Apr 7, 20:12

Sat, Apr 5

aklapper requested review of D25950: Remove PHP APC support and APC references.
Sat, Apr 5, 17:04
aklapper updated the diff for D25947: Remove setup check for safe_mode removed in PHP 5.4.

git rebase master

Sat, Apr 5, 14:05
aklapper closed D25948: Remove setup check for PHP 7.0.
Sat, Apr 5, 14:02
aklapper committed rPadc199eb4abb: Remove setup check for PHP 7.0.
Remove setup check for PHP 7.0
Sat, Apr 5, 14:02
aklapper requested review of D25949: Complete session digest migration from SHA1 to SHA256.
Sat, Apr 5, 14:00
aklapper added a revision to T16025: Tech Debt: Complete session digest migration from SHA1 to SHA256: D25949: Complete session digest migration from SHA1 to SHA256.
Sat, Apr 5, 14:00
aklapper requested review of D25948: Remove setup check for PHP 7.0.
Sat, Apr 5, 13:44
aklapper requested review of D25947: Remove setup check for safe_mode removed in PHP 5.4.
Sat, Apr 5, 13:39
aklapper requested changes to D25946: Remove support for PHP mysql extension.

Nearly perfect (thanks!), only thing missing is to also update mysql (or mysqli) in src/docs/user/installation_guide.diviner.

Sat, Apr 5, 13:12
aklapper created T16025: Tech Debt: Complete session digest migration from SHA1 to SHA256.
Sat, Apr 5, 09:50
aklapper added a comment to D25887: Remove use of deprecated E_STRICT PHP constant.

Phorge supports either the old mysql extension or mysqli - and mysql was deprecated in PHP 5.5, and removed in PHP 7.0.

Sat, Apr 5, 09:42
aklapper created T16024: Tech Debt: Remove PHP mysql extension related code.
Sat, Apr 5, 09:41
aklapper updated the summary of D25886: Remove use of deprecated E_STRICT PHP constant.
Sat, Apr 5, 09:24
aklapper updated the summary of D25887: Remove use of deprecated E_STRICT PHP constant.
Sat, Apr 5, 09:24
aklapper added a comment to D25887: Remove use of deprecated E_STRICT PHP constant.

I cannot remember how I attempted (and failed) to check a few weeks ago... Thank you both for jumping in and correcting!

Sat, Apr 5, 09:21

Wed, Apr 2

aklapper updated subscribers of T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated.

Patch based on my understanding of taavi's comments in T15963 (as I fail to set up an LDAP server locally):

diff --git a/src/applications/auth/adapter/PhutilLDAPAuthAdapter.php b/src/applications/auth/adapter/PhutilLDAPAuthAdapter.php
index 14047c1761..e25659a4aa 100644
--- a/src/applications/auth/adapter/PhutilLDAPAuthAdapter.php
+++ b/src/applications/auth/adapter/PhutilLDAPAuthAdapter.php
@@ -305,7 +305,16 @@ final class PhutilLDAPAuthAdapter extends PhutilAuthAdapter {
           'port' => $this->port,
         ));
Wed, Apr 2, 21:43 · Deprecation Notice, PHP 8 support
aklapper added a comment to rP67b7181f5226: Facts: Always render YYYY-MM-DD dates with eight digits in chart tooltips.

@valerio.bozzolan Could you remove the concern so this isn't listed on https://we.phorge.it/diffusion/commit/ for me? Thanks :)

Wed, Apr 2, 20:19
aklapper edited the content of Welcome to the Phorge Wiki.
Wed, Apr 2, 20:17 · Phorge
aklapper closed T15640: Errors when a commit belongs to a numeric git branch: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php as Resolved by committing rP17033a1c70d8: Fix exception handling a numeric git branch ("Call to phutil_nonempty_string()….
Wed, Apr 2, 13:09 · Bug Reports, Affects-Wikimedia
aklapper closed D25945: Fix exception handling a numeric git branch ("Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository).
Wed, Apr 2, 13:09
aklapper committed rP17033a1c70d8: Fix exception handling a numeric git branch ("Call to phutil_nonempty_string()….
Fix exception handling a numeric git branch ("Call to phutil_nonempty_string()…
Wed, Apr 2, 13:09