User Details
User Details
- User Since
- Feb 28 2023, 20:44 (98 w, 2 d)
- Availability
- Available
Wed, Jan 15
Wed, Jan 15
Add explicit cast to ArcanistUnitConsoleRenderer unit test
aklapper committed rP42234d56e5a4: Remove unused PhabricatorApplicationTransactionCommentView::getStatusID().
Remove unused PhabricatorApplicationTransactionCommentView::getStatusID()
aklapper added a comment to Q164: Issue with Attached Files Displaying as Text ({F469}).
Please answer my questions via text. The two images can only be seen by you.
Tue, Jan 14
Tue, Jan 14
aklapper added a comment to Q164: Issue with Attached Files Displaying as Text ({F469}).
Create a task in Phorge and attach a file (e.g., a screenshot or document).
Fri, Jan 10
Fri, Jan 10
aklapper committed rARCf0176263a7e6: JSON rendering: Avoid exception iterating on non-iterable objects.
JSON rendering: Avoid exception iterating on non-iterable objects
Thu, Dec 19
Thu, Dec 19
aklapper requested review of D25856: Add explicit cast to ArcanistUnitConsoleRenderer unit test.
aklapper updated the diff for D25855: JSON rendering: Avoid exception iterating on non-iterable objects.
git clean -fx to hopefully avoid test failure
Dec 17 2024
Dec 17 2024
aklapper added a comment to T15640: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.
Dec 11 2024
Dec 11 2024
aklapper requested review of D25855: JSON rendering: Avoid exception iterating on non-iterable objects.
Thanks for the super-quick patch! I can confirm that this fixes the issue in the Phriction ToC on wider screens.
aklapper added a comment to D25673: Fix error in Mercurial when no offset is specified.
@jeffrey: Would you like to arc land your patch to get it merged?
aklapper added a comment to D25619: Fix overflowing of AphrontSideNavFilterView on small screens and tidy up nav bar styles.
@bekay: Would you like to merge this?
Dec 10 2024
Dec 10 2024
aklapper added a project to T15074: Hide profile pictures and descriptions of disabled users: Spam mitigation.
aklapper added a comment to D25775: Do not re-subscribe @mentions when editing task description.
aklapper updated the summary of D25774: Strike through archived projects in navigation crumbs.
After installing subversion and setting LC_ALL instead of LANG I can finally reproduce on a Fedora 40 system:
aklapper updated the test plan for D25846: Fix Diffusion commands in non-English environments.
aklapper requested changes to D25850: Allow customizing default Phurl view and edit policies.
Oh true, got it. Have to replace PhabricatorPolicyCapability::POLICY_ADMIN, with 'capability' => PhabricatorPolicies::POLICY_ADMIN, here
aklapper updated the test plan for D25850: Allow customizing default Phurl view and edit policies.
aklapper added inline comments to D25850: Allow customizing default Phurl view and edit policies.
Dec 9 2024
Dec 9 2024
aklapper committed rPa5384ca60470: Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data.
Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data
Dec 6 2024
Dec 6 2024
aklapper closed T15968: Unit test PhabricatorAuthInviteTestCase::testDuplicateInvite fails, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
aklapper committed rARCabda70208340: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test.
Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test
aklapper updated the diff for D25849: Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data.
Right... one day I may get used to all those Phorge shortcuts, thanks
aklapper updated the diff for D25848: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test.
Oops, no for real
aklapper updated the diff for D25848: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test.
Uhm, right, heh
Dec 5 2024
Dec 5 2024
aklapper requested review of D25849: Hovercards: Avoid "Undefined index: objectPHID" when passing bogus data.
aklapper requested review of D25848: Fix PhabricatorAuthInviteTestCase::testDuplicateInvite unit test.
I applied this patch locally on top of git master and output does not complain anymore about 'link-brackets.txt' (thus it's correct) but fails in link-edge-cases.txt now (thus it's likely not complete):
Dec 3 2024
Dec 3 2024
aklapper updated the test plan for D25790: Show table of contents by default on wide screens.
@mturdus: Thanks! LGTM
aklapper added a comment to D25835: Strip surrounding whitespace from project and task titles.
@valerio.bozzolan: Feel free to give this revised version another review :)
aklapper accepted D25838: Rewrite regex for project names to be not prone to catastrophic backtracking.
Big thanks for digging deep into that regex (on which I gave up).
Thanks. Confirming that this works as expected (after manually changing test_accents.mbox to make the arc unit output fail)
aklapper updated the test plan for D25844: Add first unit test for mimemailparser headers.
Fix parsing of incoming mail with UTF-8 encoded headers
Dec 2 2024
Dec 2 2024
aklapper closed T15962: Account registration: Handle too long Real Name more gracefully as Resolved by committing rPeb380f922c9a: Account registration: Restrict Real Name length.
Account registration: Restrict Real Name length
aklapper reopened T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Open.
aklapper closed T15963: LDAP over TLS is broken as Resolved by committing rP0bfdcaa005b1: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"….
aklapper committed rP0bfdcaa005b1: Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"….
Revert "Fix PHP 8.3 "Usage of ldap_connect with two arguments is deprecated"…
Nov 30 2024
Nov 30 2024
aklapper updated the diff for D25841: Account registration: Restrict Real Name length.
Simplify return of validateRealName() as proposed by Valerio
Nov 29 2024
Nov 29 2024
aklapper updated the diff for D25841: Account registration: Restrict Real Name length.
Thanks for catching that! Amend in new PhutilNumber()
aklapper updated the summary of D25841: Account registration: Restrict Real Name length.
aklapper requested review of D25841: Account registration: Restrict Real Name length.
aklapper added a comment to T15640: Exception: "Call to phutil_nonempty_string() expected null or a string, got: int" in PhabricatorRepository.php.
Finally got a reproducer URI in downstream:
Nov 28 2024
Nov 28 2024
aklapper awarded T15961: Should we adopt modern PHP type hints in Phorge source code? a Like token.
aklapper committed rPa68b8daafde3: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.
Avoid "Unknown Object (????)" for custom Select field values in Herald editor
aklapper added a comment to D25696: Avoid "Unknown Object (????)" for custom Select field values in Herald editor.
Nov 26 2024
Nov 26 2024
aklapper updated the task description for T15860: Editing a Herald rule fails to display values of custom field: "Unknown Object (????)".
Validate some user provided calendar query range dates
aklapper committed rPb253675917c6: mimemailparser: Fix implicitly nullable parameter declarations for PHP 8.4.
mimemailparser: Fix implicitly nullable parameter declarations for PHP 8.4
aklapper updated the diff for D25825: Validate some user provided calendar query range dates.
Also update the PhpDoc accordingly
aklapper updated the diff for D25825: Validate some user provided calendar query range dates.
Ignore PHP 8.3.0's new DateMalformedStringException and stick to generic Exception in all cases instead
aklapper requested review of D25839: Fix parsing of incoming mail with UTF-8 encoded headers.
Make maniphest.gettasktransactions include metadata and title
aklapper closed T15945: Allow zooming Phorge pages on mobile as Resolved by committing rP828ea9bca030: Allow zooming on pages.
aklapper closed T15724: PHP 8.3: Usage of ldap_connect with two arguments is deprecated, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.