Mention closed-source apps in addition to open-source apps per @aklapper
Feed All Stories
Sat, Mar 29
Sat, Mar 29
Cigaryno updated the diff for D25934: Update TOTP suggestions to open-source applications.
Cigaryno planned changes to D25934: Update TOTP suggestions to open-source applications.
Per @aklapper, it's best to show both closed-source and open-source TOTP apps.
Cigaryno added a comment to T16018: Update TOTP suggestions to open-source applications.
Cigaryno added a comment to D25934: Update TOTP suggestions to open-source applications.
aklapper added a comment to T16018: Update TOTP suggestions to open-source applications.
I'd personally not remove common proprietary software options (as it makes life of users potentially harder if they already have such an app installed) but list FOSS options first.
aklapper added a comment to D25934: Update TOTP suggestions to open-source applications.
I'd prefer not to remove common proprietary software options but list FOSS options first.
Cigaryno requested review of D25934: Update TOTP suggestions to open-source applications.
I will submit a patch shortly.
valerio.bozzolan updated the test plan for D25933: Remove several unused private functions.
PHPDoc: Replace non-existing return type const with string
Cigaryno added a comment to D25926: Make Diffusion repository management accessible to logged-out users.
aklapper added a comment to D25926: Make Diffusion repository management accessible to logged-out users.
What is there to "further review"? It's two lines...
aklapper updated the test plan for D25932: PHPDoc: Replace non-existing return type const with string.
aklapper requested review of D25933: Remove several unused private functions.
aklapper requested review of D25932: PHPDoc: Replace non-existing return type const with string.
Cigaryno added a comment to D25926: Make Diffusion repository management accessible to logged-out users.
Can this be further reviewed?
Fri, Mar 28
Fri, Mar 28
valerio.bozzolan awarded T16023: Regression in Config: console generates errors when some libraries are not managed by Git a Yellow Medal token.
valerio.bozzolan renamed T16023: Regression in Config: console generates errors when some libraries are not managed by Git from Config console generates errors when some libraries are not managed by Git to Regression in Config: console generates errors when some libraries are not managed by Git.
xtex added a comment to T16023: Regression in Config: console generates errors when some libraries are not managed by Git.
Thanks for the hint.
valerio.bozzolan assigned T16023: Regression in Config: console generates errors when some libraries are not managed by Git to xtex.
Well done \o/
Config: Fix git errors when .git does not exist
xtex updated the diff for D25931: Config: Fix git errors when .git does not exist.
Remove duplicated assignments to $stderr
valerio.bozzolan added inline comments to D25931: Config: Fix git errors when .git does not exist.
xtex updated the diff for D25931: Config: Fix git errors when .git does not exist.
Add link to T16023
xtex updated the diff for D25931: Config: Fix git errors when .git does not exist.
Fix lint message
xtex updated the diff for D25931: Config: Fix git errors when .git does not exist.
Update to detect stderr messages
valerio.bozzolan added a comment to T16023: Regression in Config: console generates errors when some libraries are not managed by Git.
As said in https://we.phorge.it/D25931#25023 I think this is a sub-task of T15243. And in this specific case, very probably we don't want to log anything. So your report could be considered a regression caused by T15243.
valerio.bozzolan added a comment to D25931: Config: Fix git errors when .git does not exist.
Thanks my friend. I 100% understand the problem and I'm happy you shared the stack trace in the task and I'm happy about this test plan that helped me to reproduce,
valerio.bozzolan updated the diff for D25931: Config: Fix git errors when .git does not exist.
arc diff
xtex requested review of D25931: Config: Fix git errors when .git does not exist.
Fix invalid CSS overflow value for .phui-oi-name
aklapper updated the diff for D25921: Fix invalid CSS overflow value for .phui-oi-name.
git rebase master
valerio.bozzolan updated the test plan for D25921: Fix invalid CSS overflow value for .phui-oi-name.
valerio.bozzolan closed T16001: Celerity unit test not triggered: mitigate thanks to Herald as Resolved.
It seems H29 works lol. I've improved it a bit to do not trigger if the celerity map was already touched.
aklapper added a comment to D25930: Remove more obsolete IE9 filter CSS syntax.
No problem! I'll send you my crypto wallet address. Once the money has arrived you'll receive your clipboard content as an NFT.
valerio.bozzolan added a comment to D25930: Remove more obsolete IE9 filter CSS syntax.
Yep thanks, I need my clipboard of the 12 of August 2024 to get back the "D25772" to copy-paste it here and attract hackers asd
Remove more obsolete IE9 filter CSS syntax
aklapper added a comment to D25930: Remove more obsolete IE9 filter CSS syntax.
My keylogger thanks you! Would you like to know anything else about your online patterns?
valerio.bozzolan added a comment to D25930: Remove more obsolete IE9 filter CSS syntax.
You clearly hacked my account lol
aklapper added a comment to D25930: Remove more obsolete IE9 filter CSS syntax.
30 seconds for a review?! I think you broke a record.
aklapper requested review of D25930: Remove more obsolete IE9 filter CSS syntax.
Remove some pre-2013 vendor-prefixed -ms- CSS properties
aklapper updated the summary of D25928: Remove some pre-2013 vendor-prefixed -ms- CSS properties.
aklapper updated the diff for D25928: Remove some pre-2013 vendor-prefixed -ms- CSS properties.
git rebase master
Remove obsolete IE9 filter CSS syntax
Thu, Mar 27
Thu, Mar 27
aklapper updated the summary of D25929: Remove obsolete IE9 filter CSS syntax.
aklapper requested review of D25929: Remove obsolete IE9 filter CSS syntax.
aklapper requested review of D25928: Remove some pre-2013 vendor-prefixed -ms- CSS properties.
Cigaryno added a project to T16010: Owners not triggering audit on No Owner Involvement: Good Starter Task.
Looks like a Good Starter Task.
Remove pre-2016 vendor-prefixed -webkit- CSS properties
Wed, Mar 26
Wed, Mar 26
valerio.bozzolan accepted D25880: Replace some AphrontView::setUser() calls with AphrontView::setViewer().
aklapper requested review of D25927: Remove pre-2016 vendor-prefixed -webkit- CSS properties.
Diviner: Contributing Code: Update section on Prototype Changes
Apply "Can Bulk Edit Tasks" to "Move Tasks" workboard options
aklapper added a comment to D25926: Make Diffusion repository management accessible to logged-out users.
In theory yes if everyone behaved. In practice, robots.txt is ignored and LLM/AI crawlers are ruthless. (For example, GNOME GitLab admins recently installed Anubis to run background checks on your machine.)
valerio.bozzolan added a comment to D25912: Apply "Can Bulk Edit Tasks" to "Move Tasks" workboard options.
(I cannot double-accept so only just one accept asd)
Cigaryno updated the test plan for D25926: Make Diffusion repository management accessible to logged-out users.
Cigaryno added a comment to D25926: Make Diffusion repository management accessible to logged-out users.
robots.txt can have the solution for that (see below).
valerio.bozzolan added a comment to D25926: Make Diffusion repository management accessible to logged-out users.
Uhm. Good points:
Cigaryno added a comment to D25926: Make Diffusion repository management accessible to logged-out users.
Cigaryno added a comment to T15999: Make Phorge more accessible to logged-out users.
I don't think you need to be uncomfortable on your instance (phabricator.wikimedia.org)
For Herald, it looks to be restricted to trusted contributors to restrict who can create personal rules (they actually can vandalize tasks via personal rules with the action set to claim the task), that's not something to take care of at all on your instance.
Project members, maniphest reports, user tasks and badges are actually useful for logged-out users.
But everything that's Diffusion-related sounds pointless for your instance as every repo is a read-only mirror of the repos on a Gerrit instance.
aklapper added a comment to D25926: Make Diffusion repository management accessible to logged-out users.
Why would a logged-out user (who does not want to or cannot create an account) want to know about Repository management log or Repository limits? I don't see how that's their business (or interest)?
aklapper added a comment to T15999: Make Phorge more accessible to logged-out users.
Some items in the task description make me a bit uncomfortable in my instance. Why does everyone need to see Diffusion sync, pull, and push logs? Why Herald transcripts? Why repo management if you cannot manage? What are actual use cases which outweigh security implications?
Cigaryno updated the task description for T15140: switch from PHPExcel to PHPSpreadsheet for Maniphest task export.
Cigaryno updated the task description for T15999: Make Phorge more accessible to logged-out users.
Cigaryno updated the summary of D25926: Make Diffusion repository management accessible to logged-out users.
Cigaryno edited the content of Update From Phabricator.
Cigaryno added a comment to D25926: Make Diffusion repository management accessible to logged-out users.
avivey added a comment to D25926: Make Diffusion repository management accessible to logged-out users.
There might be some security implications to this.
Why is this needed?