Something I stumbled upon few months ago (via forgejo): agit-flow[^1]. Maybe worth sharing here -- for teh record? It does have some CLI client (git-repo) but it's optional and push via git push origin HEAD:refs/for/<target-branch>/<session> would trigger the Code Review process, without gerrit's Change-Id hack.

To implement this, you may want to start from this 🌈

In T15749#16629, @avivey wrote:

Maybe put the warning above the box, so it catches all actions, not just comments?

:p

I was responding to the previous comment which...

Our company uses the Phorge, and we use Keycloak as IAM. Keycloak is a very popular OAuth2/SAML provider now.

Maybe put the warning above the box, so it catches all actions, not just comments?

GitHub/Facebook is already supported as a Login/Registration providers.

Yes will be great to see a SAML or Oauth support for external authorities like:

• Keycloak
• Entra ID
• Github
• Facebook
• WeChat / WeCom

Interesting. I see. Maybe expanding its controller that should be this one:

Yeah, in this one special place it doesn't matter; But that page already have a special body, so we can save even the extra click by putting the message right there...

OK I see. Indeed we should not put any similar button anywhere else.

But in Diffusion, that button is hidden behind a "Actions -> Manage" button, inside a screen that also has dozens of other admin actions. The clutter cost there is minimized.

I see. Maybe the root problem is that I'm in love with that Diffusion popup 🤔

In that case, we don't even need another button - just add a line to the "deleted message" that says something like "To completely remove the history from the database, contact your admin".

Premising the user already have an Delete Document button.

I feel that adding such a button would clutter the UI.
Users should generally "know" that in order to really delete things, they need to go to the admin, because they don't have the permissions anyway; And adding that just for the once-in-a-while that the admin needs this...

I mean, we can maybe have a "Delete" button that just shows the related CLI command, like I've seen around (Diffusion maybe)

I don't think we actually allow "deleting" from the web ui, only hiding it (in the sense that the data is not removed from the database).

This feature request could also be expanded to:

I agree, badges seems like the right way to go. They are an underutilized feature really, IMO.

I've looked down some of the links of this request, and it looks like the definition of "new user" should be install-specific, and open to interpretation.

there is a presentation from eric brechner, who was in microsofts xbox development, about kanban. he does it on whiteboard, extremely sinple:
https://www.youtube.com/watch?v=CD0y-aU1sXo

I don't see the point in having this feature. What is it for?

Should this be configurable and behind a feature flag, as some Phorge installations may not want this (plus may slow down performance a little bit)?

I think a dedicated policy for "Can send messages" would be better, to cover more cases. It would be strange that all participants must also be allowed to edit all settings.

Ah! Indeed it would be lovely

Note: the <ins> tag is typically rendered as underlined text, so this would be very similar to the <u> formatting that is produced with __foobar__ → foobar. In fact, it might be worth repurposing that rule to produce <ins> instead, since ~~foobar~~ actually creates a semantic <del> tag rather than the presentational equivalent <s> (strikethrough) tag.

Ugh. I added this to the UX project but forgot to remove the test content from the comment box, so my changes ended up coupled with a comment that said "- List Item". I tried to delete the comment but now it looks weird like some sort of redacted content :( anway, though I'd leave the note here in case anyone is confused with the deleted comment.

This is now resolved.

In T15583#13304, @avivey wrote:

go for it.

There may already be a feature somewhere to automatically trigger a re-index because the code changed - I'll try to look for one this week.

edit: looks like it's just "add an autopatch" like resources/sql/autopatches/20191028.uriindex.01.rebuild.php. No worries.

This might be a Good Starter Task, I think - you'll need to add a class for the config, and pull the config value in diffusion.

go for it.

Okay, my proposal:

a hack that might work: add a field in the document that's called "typeahead-text" or something, and put both title and callsign into it (and maybe number and short-name as well). Then use that field in the Datasource.
Since this is a full-text field, whatever the user types will fit this field...

Okay, I have tried to wrap my head around the ferret engine. Problem is: the repo callsign is not part of the indexed material. So I would have to construct some query like (just a schema): WHERE ferret-query like '%term%' OR callsign like 'term%' - but that is not possible with the phabricator query engine. The ferret query parts are separatly created and every other where clause is merged with AND. I don't think, there is a clean way out of this. You could make TWO queries: The old one and one with the ferret engine. And then merge the results and remove doubles. But I don't know... just doesn't feel right.

In T15583#13296, @avivey wrote:

I suspect that the code in People is the oldest one - this stuff blames to 2011! and does explicit sql stuff!

rP99c9df96b4ffbf7 (2015) is the big "convert to Full Text Search" commit, but looks like it's not about Ferret (2017?).

I suspect that the code in People is the oldest one - this stuff blames to 2011! and does explicit sql stuff!

I have searched through the code a little bit and there is another system for typeahaed results. It is token based. So, how does it work?

Yeah, that's probably good - that's the query for typeaheads and probably global search, but not for other cases.

There is no ferret involved in my fix. I have already implemented it in our company instance and the devs are loving it. The change is in this line: https://we.phorge.it/source/phorge/browse/master/src/applications/repository/query/PhabricatorRepositoryQuery.php$650

I also don't fully understand the "Phabricator way" to create full text queries still using indexes. That is my main concern.

Yeah, totally reasonable feature request.
Do you think you can implement?
This might involve the Ferret engine (like this thing, or maybe there's a simpler approach for the query (title LIKE %text% in the Query class?).

• Automatically continued bulleted list upon new line

clicking such a link w/javascript disabled will do nothing. Changing it to #123 and no JS will do something....

Implicitly, Phorge generally works fine for browsers where Javascript is completely disabled.

4. Why these nice URLs are set in these links, if nobody visit them?

Less priority of course, since this Task I authored is super-stupid

OK I've done my best :D I admit it helped me psychologically.

If this is a feature request, then add all the things needed for a feature request - as in, "why would this feature be needed" and "what problem you're trying to solve".

Is this a bug or a feature request?

Should this be documented here? I think yes

@aklapper can you please re-write this ticket with the information required from a feature request?

For completeness - Landing revisions from the UI Since they wouldn't be able to land from git? - Would have to be enabled in the UI