Then, if every project could choose its own Task Create/Edit Form Configuration, it would solve the issue. Maybe form configurations could be tagged with projects, and when no tag = show for all projects?

I'd assume that it also links the task and the diff together and optionally allows to close the task automatically on diff land?

Just adding references

...set it by default to the space that the project belongs to...

Thanks, that's useful to know!

In T15903#18780, @pppery wrote:

Ideally strings not shown to the user would also not be wrapped in pht(...) at all to avoid wasting translator's time.

Remove unneeded if statements.

In D25764#20704, @valerio.bozzolan wrote:

Thanks. Have you already tried with just CSS? Any issue in that?

Ideally strings not shown to the user would also not be wrapped in pht(...) at all to avoid wasting translator's time. This is contrary to the documentation inherited from old upstream at https://we.phorge.it/book/contrib/article/internationalization/, though,

Remove typo

This is an issue in https://we.phorge.it/source/phorge/browse/master/src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php . In getObjectEmbedPattern(), preg_quote($prefix) returns \# and the method finally returns (\B{\#([^.\s?!,:;{}#\(\)"'\*/~]+(?:[^\s?!,:;{}#\(\)"'\*/~]*[^.\s?!,:;{}#\(\)"'\*/~]+)*)([,\s](?:[^}\\]|\\.)*)?}\B)u.
Within apply($text), $text becomes null after that first preg_replace_callback, so the second call barks.

I did some digging:

Create $page_size var to avoid casting twice

This entire method looks very hacky to me. I guess at the bottom of every useful UI, there's a bunch of if statements that map icon names to code.

Thanks. Have you already tried with just CSS? Any issue in that? Maybe something like this:

BTW - is something normalizing the header casing?

BTW - is something normalizing the header casing?

lol whatever, but please consider this instead to make happy also future/better versions of PHPStan

Giving this:

Double-slam-accept

I'm not skilled enough to look into the bigger picture, however maybe the Edit Column dialog could have a third field apart from Name and Point Limit to also have Task Limit (or Card Limit?). Point Limit and Task Limit then must be mutually exclusive (do not allow to set both for a column, or even...board?), somehow.

Double-accept asd

Borrow a short sentence from Valerio as his English skills in the morning are much much better than mine

Yep. In all cases it's at least a full-table-scan on file_attachment. Probably a bit more RAM-efficient with the NOT EXISTS thing since it does not need to have all file PHIDs in memory.

The title cannot exceed %d characters :D

Thanks. Also please show to the end user the same number, using some semantic pirouettes. So this limit is easier to be found.

Thanks. Also please show to the end user the same number, using some semantic pirouettes. So this limit is easier to be found.

In D25737#20607, @avivey wrote:

I'm happy to log it, but I'm nos sure this counts as "fixes" the issue - it still requires an admin to monitor the logs.
But then maybe T15887 and its friends can be collected to a single common "more visibility for Herald errors" issue.

Move max task title length into a variable

Seems super-reasonable. Please save that 255 in a variable and re-use in pht("Bla bla %d bla", $title_max_length) or similar, so it's easier to customize without invalidating translations

Tested, makes sense, lovely feature, no possible NULL pointers since isCommentTransaction() calls hasComment() that eliminates the possibility of getComment() being NULL; no possibility to get exception "Comment for this transaction was not loaded" since that was already checked with just isCommentTransaction(); green light 🌈

Little premise, in this method the return statement is dead, unreachable code:

In T15750#18669, @CryingWolf wrote:

Is this feature meant to include displaying custom project fields in search results as well? (and possibly for other applications that allow custom field definitions)

I'm happy to log it, but I'm nos sure this counts as "fixes" the issue - it still requires an admin to monitor the logs.
But then maybe T15887 and its friends can be collected to a single common "more visibility for Herald errors" issue.

Make the PHPDoc and the method name shamelessly admit its real intentions to the whole world out there