Maybe a good moment for minimal PHPDoc with

I will update the screenshots. Let's wait another +1 on strings.

Tried to re-phrase a bit, thanks to feedback from Italian coworkers and Andrè. lol

... but it turns out by concidence most of the date elements that are worth translating are already translatable from other references in the code:

// The only purpose of this function is to provide a static list of
// translations which can come from PhutilTranslator::translateDate() to
// allow translation extractor getting them.

I seem to have a bad habit of doing things and realizing they were stupid or I had missed something weeks to months later.

That would probably be a better User-Agent

/settings/panel/multifactor/ requires users to add a custom Name so there is likely code to adapt/reuse for /settings/panel/apitokens/

https://we.phorge.it/source/phorge/browse/master/src/applications/auth/adapter/PhutilGitHubAuthAdapter.php$57-58 uses a boring
$future->addHeader('User-Agent', __CLASS__); for this.

Use consistent CSS scopes. Tested. And really really last change for now. I think.

There may be some room for extra clarity for users in complex organization setups, but this is a rare enough operation (outside of dev) that it's probably not worth worrying about.

I would be find with turning this into "your PlatformSymbols::getPlatformServerName() account" instead if that's seen as clearer but I'm not convinced the platform is necessary here at all. Opinions on that welcome.

Use consistent class scope; fix a typo

IMHO this is ready to review.

Avoid non-ASCII bytes in CSS by using FontAwesome

Display custom collapse/expand arrows only on mobile screens; display them after the column header name instead of before

Add PHPDoc for setCollapsible

Fix syntax

Not sure if we prefer to make isCollabsable a property of the base classes, instead of making them non-final

Yeah right, NuanceFormItemType returns an array so NuanceGitHubEventItemType should also return an empty array. Good point, thanks!

kill it

Also fix the typo in the function name

Thanks. Your edit effectively reflects what already happens, but interestingly, it still may crash 🤔

@valerio.bozzolan: Y U so sirious??? :D

A bit more than Normal, since it reflects on a database with orphan elements that creates "ghosts in the UI".

Wow. With my proposal is not funny anymore. OK I will refrain myself from contributing here. But I personally like the new proposal from Andrè and @pppery. Personally approving.

I understand the points. Third proposal, starting with useful tips (good idea), and shorter:

I like the change in language here, but maybe a total rewrite of the text is better. My take:

When setting a new password. please keep it safe, using a trustworthy password manager and a randomly generated password.
We thank you, your administrator thanks you, and you'll thank yourself in the future.

In the unlikely event you that absolutely don't intend to keep it safe at all, you might choose instead, to:

• Write it down on a sticky note, put it on your monitor, and hope nobody else uses it on %s.
• Use the same password you've already used, especially for your e-mail and bank account.
• Use easy-to-remember, easy-to-guess passwords, like "12345abcde".

Modern security advice considers these practices "a bad idea".
If you're already doing any of these, here or elsewhere, you might want to consider the account compromised.

Thanks! Confirming that the link on https://we.phorge.it/book/dev/class/PhutilDaemon/ is a 404, and that the file was deleted in https://secure.phabricator.com/rPHU720c8116845bb9dc19334170e6c0702aa0210c78

Fix a double space after testing

Actually do that, since I screwed up before

Update to Andre's suggestion