- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
May 3 2023
May 2 2023
I am not sure about the assumption I made about the false return value of isRawCacheDataValid().
@valerio.bozzolan: Ah, thanks. If there is an assumption that string passed to phutil_escape_uri($string) shall never ever be null and in that case there is always an underlying bug to fix (that wasn't clear to me), then I'd say adding a phlog() makes sense if it automagically includes a stacktrace and has clear instructions what a random Phorge admin seeing that log entry is supposed to do (like "Unexpected null string passed to phutil_escape_uri. Please report a bug at https://we.phorge.it/maniphest/ and mention T15263 in your task.") Okay.
If you want easy extra points, maybe this can be even more nice, using phlog():
Pseudo code, not tested as other exceptions block me from testing:
No, I found this issue by reading the code. However, declining based on comments in D25174 as Phorge does not seem to check for PHP >= 5.5.
In D25174#5371, @avivey wrote:Why won't this software run with safe_mode enabled?
May 1 2023
Cover another exception/stacktrace in the same file in this patch
(When using arc diff --update it's still unclear to me how to update the commit message. It seems a separate comment gets added ( https://we.phorge.it/D25166#5298 ) instead.
Fix PHP 8.1 "strlen(null)" exception which blocks rendering the "Manage Menu" page
Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page