Page MenuHomePhorge
Create Task
Maniphest T15329

Remove PHP Safe Mode related code
Closed, WontfixPublic
Actions

Description

PHP "Safe Mode" feature has been deprecated as of PHP 5.3.0 and removed as of PHP 5.4.0.
( https://www.php.net/manual/en/features.safe-mode.php is a 404 nowadays; so see e.g. https://www.mediawiki.org/wiki/PHP_5_safe_mode )

https://we.phorge.it/book/phorge/article/installation_guide/ states PHP: You need PHP 5.5 or newer.

Revisions and Commits

rP Phorge
AbandonedD25174 Remove PHP Safe Mode related code

Related Objects

Event Timeline

aklapper created this task.May 2 2023, 13:12
Herald added subscribers: Cigaryno, Matthew, chris and 2 others. · View Herald TranscriptMay 2 2023, 13:12
aklapper added a revision: D25174: Remove PHP Safe Mode related code.May 2 2023, 13:14
valerio.bozzolan subscribed.May 2 2023, 13:17

Thanks

I think you have found this issues since ini_get('safe_mode') is null and that was checked inside a strlen(). Isn't it?

aklapper closed this task as Wontfix.May 2 2023, 14:06
aklapper claimed this task.

No, I found this issue by reading the code. However, declining based on comments in D25174 as Phorge does not seem to check for PHP >= 5.5.

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0