Page MenuHomePhorge

Remove PHP Safe Mode related code

Authored by aklapper on May 2 2023, 13:14.
Referenced Files
Unknown Object (File)
Wed, May 31, 06:32
Unknown Object (File)
Tue, May 23, 07:27
Unknown Object (File)
Tue, May 23, 00:27
Unknown Object (File)
Tue, May 16, 14:05
"Manufacturing Defect?" token, awarded by valerio.bozzolan.



PHP "Safe Mode" feature has been deprecated as of PHP 5.3.0 and removed as of PHP 5.4.0.

Phorge requires PHP 5.5 or newer.

Closes T15329

Test Plan

Not sure. Managed to still install Phorge on PHP 8.1 after removing these lines.

Diff Detail

rP Phorge
rmSafeMode (branched from master)
Lint Passed
Tests Passed
Build Status
Buildable 334
Build 334: arc lint + arc unit

Event Timeline

aklapper requested review of this revision.May 2 2023, 13:14

Why won't this software run with safe_mode enabled?

avivey requested changes to this revision.May 2 2023, 13:33

A change without a test plan is just a bug report waiting to happen.

This revision now requires changes to proceed.May 2 2023, 13:33
In D25174#5371, @avivey wrote:

Why won't this software run with safe_mode enabled?

How to enable safe_mode in PHP 5.5 or newer when Safe Mode was removed in PHP 5.4 && when Phorge requires PHP 5.5 or newer anyway according to the Phorge docs?

Anyway, looking at Phorge's code now it seems to lack a check that the PHP version is 5.5 or newer. That would indeed be something to add first, before thinking of this patch. Abandoning for the time being.