No, it never was called anywhere. Read the HTML comment this commit deletes.

... but it turns out by concidence most of the date elements that are worth translating are already translatable from other references in the code:

// The only purpose of this function is to provide a static list of
// translations which can come from PhutilTranslator::translateDate() to
// allow translation extractor getting them.

I seem to have a bad habit of doing things and realizing they were stupid or I had missed something weeks to months later.

I would be find with turning this into "your PlatformSymbols::getPlatformServerName() account" instead if that's seen as clearer but I'm not convinced the platform is necessary here at all. Opinions on that welcome.

Fix a double space after testing

Actually do that, since I screwed up before

Update to Andre's suggestion

In D25671#18362, @speck wrote:

In D25671#18360, @speck wrote:

Agree the current non-serious language needs updated.

Though, I’d guess Phab/Phorge will actually reject these short passwords.

Change commit message to reference spelling

"And complained on WMF, where this feature is disabled?" is true but misleading IMO - there was nowhere better to complain than WMF's instance since this took place after Phabricator was abandoned but before Phorge's initial release, and WMF's instance has received numerous other reports of Phabricator translation problems that were later redirected here or to old upstream.

And yes, I did read https://we.phorge.it/book/phorge/article/tone/ before filing this patch. You are welcome to berate me (and by extension Verdy_p on translatewiki.net, although they've been blocked there so the chance of them seeing anything you say is low) anyway.

Sorry, this isn't an upstream problem. It's an instance of the general "Phabricator lacks message documentation" problem, since nav is a bit of remarkup that niether Verdy_p on the translatewiki side nor I am familiar with. But I can handle that on the translatewiki.net side and there's nothing for upstream to do.

I upstreamed this as a largely procedural action (go through all requests for source message changes in translatewiki.net that haven't been resolved and move them up to Phorge so they can be evaluated properly rather than ignored).

Read the originally requested changes more carefully

In T15815#17273, @valerio.bozzolan wrote:

I also don't think Phabricator ever documented how to change language in command line Arcanist. If ever possible, btw 🤔

For the record: If I replace the entire file with just:

<?php

(that was me, I didn't have git author configured properly from on the system I landed from)

(that was me, I didn't have git author configured properly from on the system I landed from)

arc unit --everything passed. But I don't think this file is covered by tests at all,

In T15815#17273, @valerio.bozzolan wrote:

Thanks. Completely agree.

I also don't think Phabricator ever documented how to change language in command line Arcanist. If ever possible, btw 🤔

Re-diff with linting and tests working hopefully

Old upstream WONTFIXed this in https://secure.phabricator.com/T13154

Also related: https://phabricator.wikimedia.org/T266966

This already has been accepted. I think @Matthew 's old request for changes is what is keeping this from being landable right now.

Translatewiki finally processed the rebrand a few days ago, as part of https://phabricator.wikimedia.org/T318763