Page MenuHomePhorge
Feed Advanced Search

Aug 15 2023

aklapper committed rP7040bd525764: Fix PHP 8.1 "strlen(null)" exception adding "Build with Buildkite" build step….
Fix PHP 8.1 "strlen(null)" exception adding "Build with Buildkite" build step…
Aug 15 2023, 08:15
aklapper merged T15593: PHP 8.1 "strlen(null)" exception adding an External Build Systems build step in Harbormaster into T15580: PHP 8.1 "strlen(null)" exception setting Passphrase Credential.
Aug 15 2023, 08:14 · PHP 8 support
aklapper merged task T15593: PHP 8.1 "strlen(null)" exception adding an External Build Systems build step in Harbormaster into T15580: PHP 8.1 "strlen(null)" exception setting Passphrase Credential.
Aug 15 2023, 08:14 · PHP 8 support
aklapper abandoned D25378: Fix PHP 8.1 "strlen(null)" exception adding an External Build Systems build step in Harbormaster.

I finally managed to lost track: This got already fixed in D25370.

Aug 15 2023, 08:14
avivey awarded T15603: Exception: Call to undefined method PhutilJSON::encodeAsObject() a The World Burns token.
Aug 15 2023, 06:11

Aug 14 2023

aklapper requested review of D25391: Fix call to undefined method PhutilJSON::encodeAsObject().
Aug 14 2023, 20:56
aklapper added a revision to T15603: Exception: Call to undefined method PhutilJSON::encodeAsObject(): D25391: Fix call to undefined method PhutilJSON::encodeAsObject().
Aug 14 2023, 20:56
aklapper requested review of D25390: Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists.
Aug 14 2023, 20:49
aklapper added a revision to T15602: PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists: D25390: Fix PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists.
Aug 14 2023, 20:49 · PHP 8 support
aklapper created T15603: Exception: Call to undefined method PhutilJSON::encodeAsObject().
Aug 14 2023, 20:41
aklapper created T15602: PHP 8.1 "json_decode(null)" exception editing a form when custom field of type Users exists.
Aug 14 2023, 20:27 · PHP 8 support
aklapper updated the diff for D25389: Fix PHP 8.1 "strlen(null)" exceptions editing a form when custom field of type Date exists.

and of course after this round I got an additional RuntimeException: ctype_digit(): Argument of type int will be interpreted as string in the future to also tackle

Aug 14 2023, 20:18
aklapper updated the summary of D25389: Fix PHP 8.1 "strlen(null)" exceptions editing a form when custom field of type Date exists.
Aug 14 2023, 20:10
aklapper updated the diff for D25389: Fix PHP 8.1 "strlen(null)" exceptions editing a form when custom field of type Date exists.

Check for scalar instead of string as the passed value can also be an integer

Aug 14 2023, 20:08
aklapper added a comment to D25389: Fix PHP 8.1 "strlen(null)" exceptions editing a form when custom field of type Date exists.

...and wrong. Needs to check for a scalar instead because with a custom Date field I get: Call to phutil_nonempty_string() expected null or a string, got: int.

Aug 14 2023, 20:06
aklapper requested review of D25389: Fix PHP 8.1 "strlen(null)" exceptions editing a form when custom field of type Date exists.
Aug 14 2023, 20:01
aklapper added a revision to T15601: PHP 8.1 "strlen(null)" exceptions editing a form when custom field of type Date exists: D25389: Fix PHP 8.1 "strlen(null)" exceptions editing a form when custom field of type Date exists.
Aug 14 2023, 20:01 · PHP 8 support
aklapper created T15601: PHP 8.1 "strlen(null)" exceptions editing a form when custom field of type Date exists.
Aug 14 2023, 20:00 · PHP 8 support

Aug 11 2023

aklapper closed T15590: PHP 8.1 "strlen(null)" exceptions block account registration with custom OAuth provider after redirect, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Aug 11 2023, 19:03 · PHP 8 support
aklapper closed D25375: Fix PHP 8.1 "strlen(null)" exceptions blocking account registration with custom OAuth provider after redirect.
Aug 11 2023, 19:03
aklapper closed T15590: PHP 8.1 "strlen(null)" exceptions block account registration with custom OAuth provider after redirect as Resolved by committing rP98dfac53ba72: Fix PHP 8.1 "strlen(null)" exceptions blocking account registration with custom….
Aug 11 2023, 19:03 · PHP 8 support
aklapper committed rP98dfac53ba72: Fix PHP 8.1 "strlen(null)" exceptions blocking account registration with custom….
Fix PHP 8.1 "strlen(null)" exceptions blocking account registration with custom…
Aug 11 2023, 19:03
aklapper closed D25377: Fix PHP 8.1 "strlen(null)" exception adding a "Drydock: Run Command" build step in Harbormaster.
Aug 11 2023, 19:01
aklapper closed T15592: PHP 8.1 "strlen(null)" exception adding a "Drydock: Run Command" build step in Harbormaster, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Aug 11 2023, 19:01 · PHP 8 support
aklapper committed rPa2e8ab318070: Fix PHP 8.1 "strlen(null)" exception adding a "Drydock: Run Command" build step….
Fix PHP 8.1 "strlen(null)" exception adding a "Drydock: Run Command" build step…
Aug 11 2023, 19:01
aklapper closed T15592: PHP 8.1 "strlen(null)" exception adding a "Drydock: Run Command" build step in Harbormaster as Resolved by committing rPa2e8ab318070: Fix PHP 8.1 "strlen(null)" exception adding a "Drydock: Run Command" build step….
Aug 11 2023, 19:01 · PHP 8 support
aklapper closed T15591: PHP 8.1 "strlen(null)" exception adding a Harbormaster Build Plan as Resolved by committing rPc61c6a1ec3c1: Fix PHP 8.1 "strlen(null)" exception adding a Harbormaster Build Plan.
Aug 11 2023, 19:00 · PHP 8 support
aklapper closed T15591: PHP 8.1 "strlen(null)" exception adding a Harbormaster Build Plan, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Aug 11 2023, 19:00 · PHP 8 support
aklapper closed D25376: Fix PHP 8.1 "strlen(null)" exception adding a Harbormaster Build Plan.
Aug 11 2023, 19:00
aklapper committed rPc61c6a1ec3c1: Fix PHP 8.1 "strlen(null)" exception adding a Harbormaster Build Plan.
Fix PHP 8.1 "strlen(null)" exception adding a Harbormaster Build Plan
Aug 11 2023, 19:00
aklapper closed T15588: PHP 8.1 "strlen(null)" exceptions trying to authenticate via custom OAuth provider, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Aug 11 2023, 18:57 · PHP 8 support
aklapper closed T15588: PHP 8.1 "strlen(null)" exceptions trying to authenticate via custom OAuth provider as Resolved by committing rP085769ceb687: Fix PHP 8.1 "strlen(null)" exceptions trying to authenticate via custom OAuth….
Aug 11 2023, 18:57 · PHP 8 support
aklapper closed D25373: Fix PHP 8.1 "strlen(null)" exceptions trying to authenticate via custom OAuth provider.
Aug 11 2023, 18:57
aklapper committed rP085769ceb687: Fix PHP 8.1 "strlen(null)" exceptions trying to authenticate via custom OAuth….
Fix PHP 8.1 "strlen(null)" exceptions trying to authenticate via custom OAuth…
Aug 11 2023, 18:57
aklapper closed T15580: PHP 8.1 "strlen(null)" exception setting Passphrase Credential, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Aug 11 2023, 18:56 · PHP 8 support
aklapper closed T15580: PHP 8.1 "strlen(null)" exception setting Passphrase Credential as Resolved by committing rP10ee019785d5: Fix PHP 8.1 "strlen(null)" exception setting Passphrase Credential.
Aug 11 2023, 18:56 · PHP 8 support
aklapper closed D25370: Fix PHP 8.1 "strlen(null)" exception setting Passphrase Credential.
Aug 11 2023, 18:56
aklapper committed rP10ee019785d5: Fix PHP 8.1 "strlen(null)" exception setting Passphrase Credential.
Fix PHP 8.1 "strlen(null)" exception setting Passphrase Credential
Aug 11 2023, 18:56

Aug 7 2023

aklapper added a comment to T15586: arcanist EXCEPTION: (CommandException) Command failed with error #-1!.

For the records, I did not compile from source, I had used the official Fedora package php-8.2.9-1.fc38 created on Aug 1st from https://koji.fedoraproject.org/koji/packageinfo?packageID=72

Aug 7 2023, 10:21

Aug 6 2023

aklapper retitled D25378: Fix PHP 8.1 "strlen(null)" exception adding an External Build Systems build step in Harbormaster from Fix PHP 8.1 "strlen(null)" exception adding a "Drydock: Run Command" build step in Harbormaster
Aug 6 2023, 21:13
aklapper renamed T15593: PHP 8.1 "strlen(null)" exception adding an External Build Systems build step in Harbormaster from PHP 8.1 "strlen(null)" exception adding a "Drydock: Run Command" build step in Harbormaster to PHP 8.1 "strlen(null)" exception adding an External Build Systems build step in Harbormaster.
Aug 6 2023, 21:13 · PHP 8 support
aklapper requested review of D25379: Fix PHP 8.1 "strlen(null)" exception adding "Build with Buildkite" build step in Harbormaster.
Aug 6 2023, 21:08
aklapper added a revision to T15594: PHP 8.1 "strlen(null)" exception adding "Build with Buildkite" build step in Harbormaster: D25379: Fix PHP 8.1 "strlen(null)" exception adding "Build with Buildkite" build step in Harbormaster.
Aug 6 2023, 21:08 · PHP 8 support
aklapper created T15594: PHP 8.1 "strlen(null)" exception adding "Build with Buildkite" build step in Harbormaster.
Aug 6 2023, 21:04 · PHP 8 support
aklapper requested review of D25378: Fix PHP 8.1 "strlen(null)" exception adding an External Build Systems build step in Harbormaster.
Aug 6 2023, 20:55
aklapper added a revision to T15593: PHP 8.1 "strlen(null)" exception adding an External Build Systems build step in Harbormaster: D25378: Fix PHP 8.1 "strlen(null)" exception adding an External Build Systems build step in Harbormaster.
Aug 6 2023, 20:55 · PHP 8 support
aklapper created T15593: PHP 8.1 "strlen(null)" exception adding an External Build Systems build step in Harbormaster.
Aug 6 2023, 20:54 · PHP 8 support
aklapper requested review of D25377: Fix PHP 8.1 "strlen(null)" exception adding a "Drydock: Run Command" build step in Harbormaster.
Aug 6 2023, 20:48
aklapper added a revision to T15592: PHP 8.1 "strlen(null)" exception adding a "Drydock: Run Command" build step in Harbormaster: D25377: Fix PHP 8.1 "strlen(null)" exception adding a "Drydock: Run Command" build step in Harbormaster.
Aug 6 2023, 20:48 · PHP 8 support
aklapper created T15592: PHP 8.1 "strlen(null)" exception adding a "Drydock: Run Command" build step in Harbormaster.
Aug 6 2023, 20:46 · PHP 8 support
aklapper requested review of D25376: Fix PHP 8.1 "strlen(null)" exception adding a Harbormaster Build Plan.
Aug 6 2023, 20:37
aklapper added a revision to T15591: PHP 8.1 "strlen(null)" exception adding a Harbormaster Build Plan: D25376: Fix PHP 8.1 "strlen(null)" exception adding a Harbormaster Build Plan.
Aug 6 2023, 20:37 · PHP 8 support
aklapper created T15591: PHP 8.1 "strlen(null)" exception adding a Harbormaster Build Plan.
Aug 6 2023, 20:36 · PHP 8 support
aklapper added a comment to T15486: Do not expose "Contact Numbers" in user settings when no SMS support is set up in Phorge.
Aug 6 2023, 15:59 · Policy
aklapper added a comment to T15486: Do not expose "Contact Numbers" in user settings when no SMS support is set up in Phorge.

I'd expect that a user's contact numbers might show up on their profile to other registered users.

Aug 6 2023, 15:25 · Policy
aklapper added a comment to rP9fe2bfebe8d6: Fix PHP 8.1 "strlen(null)" exception adding LDAP authentication.
Aug 6 2023, 13:45

Aug 5 2023

aklapper closed T15581: PHP 8.1 "strlen(null)" exception creating Blueprint Working Copy, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Aug 5 2023, 21:29 · PHP 8 support
aklapper closed T15581: PHP 8.1 "strlen(null)" exception creating Blueprint Working Copy as Resolved by committing rP226f3150933d: Fix PHP 8.1 "strlen(null)" exception creating Blueprint Working Copy.
Aug 5 2023, 21:29 · PHP 8 support
aklapper closed D25371: Fix PHP 8.1 "strlen(null)" exception creating Blueprint Working Copy.
Aug 5 2023, 21:29
aklapper committed rP226f3150933d: Fix PHP 8.1 "strlen(null)" exception creating Blueprint Working Copy.
Fix PHP 8.1 "strlen(null)" exception creating Blueprint Working Copy
Aug 5 2023, 21:29
aklapper closed T15550: Add HTML header for Atom/RSS feed discovery on Phame blog pages, a subtask of T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge, as Resolved.
Aug 5 2023, 21:26 · Discussion Needed, Affects-Wikimedia
aklapper closed D25346: Add HTML header for Atom/RSS discovery on Phame blog pages.
Aug 5 2023, 21:26
aklapper closed T15550: Add HTML header for Atom/RSS feed discovery on Phame blog pages as Resolved by committing rP39b576b145ae: Add HTML header for Atom/RSS discovery on Phame blog pages.
Aug 5 2023, 21:26 · Feature Requests
aklapper committed rP39b576b145ae: Add HTML header for Atom/RSS discovery on Phame blog pages.
Add HTML header for Atom/RSS discovery on Phame blog pages
Aug 5 2023, 21:26
aklapper added a comment to T15586: arcanist EXCEPTION: (CommandException) Command failed with error #-1!.

Three days ago I ran into the same output (though different steps in Phorge that I don't perfectly remember) after upgrading from PHP 8.2.8 to PHP 8.2.9 on Fedora 38. Thus I downgraded again.

Aug 5 2023, 20:46
aklapper requested review of D25375: Fix PHP 8.1 "strlen(null)" exceptions blocking account registration with custom OAuth provider after redirect.
Aug 5 2023, 20:42
aklapper added a revision to T15590: PHP 8.1 "strlen(null)" exceptions block account registration with custom OAuth provider after redirect: D25375: Fix PHP 8.1 "strlen(null)" exceptions blocking account registration with custom OAuth provider after redirect.
Aug 5 2023, 20:42 · PHP 8 support
aklapper created T15590: PHP 8.1 "strlen(null)" exceptions block account registration with custom OAuth provider after redirect.
Aug 5 2023, 20:41 · PHP 8 support
aklapper requested review of D25374: Fix PHP 8.1 "urlencode(null)" exception blocking account registration redirect for custom OAuth provider.
Aug 5 2023, 20:28
aklapper added a revision to T15589: PHP 8.1 "urlencode(null)" exception blocks account registration redirect for custom OAuth provider: D25374: Fix PHP 8.1 "urlencode(null)" exception blocking account registration redirect for custom OAuth provider.
Aug 5 2023, 20:28 · PHP 8 support
aklapper created T15589: PHP 8.1 "urlencode(null)" exception blocks account registration redirect for custom OAuth provider.
Aug 5 2023, 20:27 · PHP 8 support

Aug 4 2023

aklapper requested review of D25373: Fix PHP 8.1 "strlen(null)" exceptions trying to authenticate via custom OAuth provider.
Aug 4 2023, 18:44
aklapper added a revision to T15588: PHP 8.1 "strlen(null)" exceptions trying to authenticate via custom OAuth provider: D25373: Fix PHP 8.1 "strlen(null)" exceptions trying to authenticate via custom OAuth provider.
Aug 4 2023, 18:44 · PHP 8 support
aklapper created T15588: PHP 8.1 "strlen(null)" exceptions trying to authenticate via custom OAuth provider.
Aug 4 2023, 18:41 · PHP 8 support
aklapper closed T15587: PHP 8.1 "strlen(null)" exception adding LDAP authentication, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Aug 4 2023, 16:06 · PHP 8 support
aklapper closed T15587: PHP 8.1 "strlen(null)" exception adding LDAP authentication as Resolved by committing rP9fe2bfebe8d6: Fix PHP 8.1 "strlen(null)" exception adding LDAP authentication.
Aug 4 2023, 16:06 · PHP 8 support
aklapper closed D25372: Fix PHP 8.1 "strlen(null)" exception adding LDAP authentication.
Aug 4 2023, 16:06
aklapper committed rP9fe2bfebe8d6: Fix PHP 8.1 "strlen(null)" exception adding LDAP authentication.
Fix PHP 8.1 "strlen(null)" exception adding LDAP authentication
Aug 4 2023, 16:06
aklapper requested review of D25372: Fix PHP 8.1 "strlen(null)" exception adding LDAP authentication.
Aug 4 2023, 15:01
aklapper added a revision to T15587: PHP 8.1 "strlen(null)" exception adding LDAP authentication: D25372: Fix PHP 8.1 "strlen(null)" exception adding LDAP authentication.
Aug 4 2023, 15:01 · PHP 8 support
aklapper created T15587: PHP 8.1 "strlen(null)" exception adding LDAP authentication.
Aug 4 2023, 15:00 · PHP 8 support

Aug 3 2023

aklapper updated the task description for T15584: Incorrectly cropped box-shadow CSS around a.button:focus.
Aug 3 2023, 12:47
aklapper created T15585: Replace or remove deprecated "-moz-outline-style" CSS property.
Aug 3 2023, 12:34 · Good Starter Task
aklapper created T15584: Incorrectly cropped box-shadow CSS around a.button:focus.
Aug 3 2023, 12:25
aklapper added a comment to T15582: Allow blocking users.

This ticket seems to mix several different things (block people who harass versus filtering content that you want to see). This ticket does not describe an underlying root problem but a potential solution. @Quartz: Please see https://we.phorge.it/book/contrib/article/describing_problems/ and improve this ticket - thanks.

Aug 3 2023, 09:53 · Clarification Needed
aklapper removed a project from T15582: Allow blocking users: Affects-Wikimedia.

Please do not add random project tags, as this is not a problem in Wikimedia at all. Thanks!

Aug 3 2023, 09:51 · Clarification Needed

Aug 1 2023

aklapper requested review of D25371: Fix PHP 8.1 "strlen(null)" exception creating Blueprint Working Copy.
Aug 1 2023, 17:47
aklapper added a revision to T15581: PHP 8.1 "strlen(null)" exception creating Blueprint Working Copy: D25371: Fix PHP 8.1 "strlen(null)" exception creating Blueprint Working Copy.
Aug 1 2023, 17:47 · PHP 8 support
aklapper created T15581: PHP 8.1 "strlen(null)" exception creating Blueprint Working Copy.
Aug 1 2023, 17:43 · PHP 8 support
aklapper updated the diff for D25239: Fix PHP 8.1 exceptions which block rendering Drydock's Create Blueprint page.

Remove unrelated Credentials change now covered in T15580 instead

Aug 1 2023, 17:34
aklapper updated the diff for D25239: Fix PHP 8.1 exceptions which block rendering Drydock's Create Blueprint page.

Handle empty $value in PhabricatorStandardCustomFieldPHIDs.php instead

Aug 1 2023, 17:31
aklapper requested review of D25370: Fix PHP 8.1 "strlen(null)" exception setting Passphrase Credential.
Aug 1 2023, 17:09
aklapper added a revision to T15580: PHP 8.1 "strlen(null)" exception setting Passphrase Credential: D25370: Fix PHP 8.1 "strlen(null)" exception setting Passphrase Credential.
Aug 1 2023, 17:09 · PHP 8 support
aklapper updated the task description for T15408: PHP 8.1 "json_decode(null)" exception blocks creating Almanac Hosts blueprint in Drydock.
Aug 1 2023, 17:09 · Almanac/Drydock/Harbormaster, PHP 8 support
aklapper created T15580: PHP 8.1 "strlen(null)" exception setting Passphrase Credential.
Aug 1 2023, 17:08 · PHP 8 support
aklapper added a comment to D25346: Add HTML header for Atom/RSS discovery on Phame blog pages.

I think this should be implemented using the getHead() method that's already defined.

Aug 1 2023, 15:01

Jul 29 2023

aklapper closed T15423: PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding as Resolved by committing rARC788098096e11: Fix PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding.
Jul 29 2023, 09:20 · Diffusion, PHP 8 support
aklapper closed T15423: PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jul 29 2023, 09:20 · PHP 8 support
aklapper closed D25249: Fix PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding.
Jul 29 2023, 09:20
aklapper committed rARC788098096e11: Fix PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding.
Fix PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding
Jul 29 2023, 09:20