Uh, that unit test was useful indeed, and I know understand the rest of the code.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
May 13 2023
May 13 2023
aklapper updated the diff for D25227: Fix PHP 8.1 "strlen(null)" exception which blocks rendering "Browse Dashboards" dialog.
aklapper added a comment to T15372: "RuntimeException: Undefined array key" when pasting "a {{{a}}} a" comment (due to regex in PhutilRemarkupInterpreterBlockRule.php).
Historical commits with some comments about that regex: https://secure.phabricator.com/D7338, https://secure.phabricator.com/D7012
aklapper removed a project from T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4: Affects-Wikimedia.
It might make sense to look into https://secure.phabricator.com/T13588 and https://secure.phabricator.com/D21862
aklapper added a comment to T15378: PhabricatorApplicationTransactionStructureException trying to mute File notifications: "Attempting to apply a transaction which has not been constructed correctly".
Same behavior for "Mute Notifications" on http://phorge.localhost/legalpad/view/1/ with same stacktrace:
[2023-05-13 10:48:02] EXCEPTION: (PhabricatorApplicationTransactionStructureException) Attempting to apply a transaction (of class "LegalpadTransaction", with type "core:edge") which has not been constructed correctly: Transaction has type "core:edge", but that transaction type is not supported by this editor (LegalpadDocumentEditor). at [<phorge>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1830] arcanist(head=master, ref.master=c14785c3795c), phorge(head=conduitEatMoreKittens, ref.master=2df7ea13a387, ref.conduitEatMoreKittens=2df7ea13a387) #0 <#2> PhabricatorApplicationTransactionEditor::validateEditParameters(LegalpadDocument, array) called at [<phorge>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1209] #1 <#2> PhabricatorApplicationTransactionEditor::applyTransactions(LegalpadDocument, array) called at [<phorge>/src/applications/subscriptions/controller/PhabricatorSubscriptionsMuteController.php:58] #2 <#2> PhabricatorSubscriptionsMuteController::handleRequest(AphrontRequest) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:284] #3 phlog(PhabricatorApplicationTransactionStructureException) called at [<phorge>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:41] #4 PhabricatorDefaultRequestExceptionHandler::handleRequestThrowable(AphrontRequest, PhabricatorApplicationTransactionStructureException) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:751] #5 AphrontApplicationConfiguration::handleThrowable(PhabricatorApplicationTransactionStructureException) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:296] #6 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:203] #7 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35]
aklapper abandoned D25225: Fix PHP 8.1 "array_fuse(null)" exception which blocks rendering Conduit's "Method Call Result" page.
Uh right, that makes way more sense to cover numerous such cases in Arcanist instead of playing whack-a-mole in Phorge Conduit. Thanks!
aklapper updated the diff for D25176: Fix PHP 8.1 "strlen(null)" exception which blocks creating a project with an empty Description field.
Use phutil_nonempty_stringlike; update doc comment.
May 12 2023
May 12 2023
aklapper requested review of D25223: Fix PHP 8.1 "strlen(null)" exception which blocks task Bulk Editor page.
aklapper added a comment to D25222: Fix PHP 8.1 "strlen(null)" exception setting Story Points on a Task.
lol, maybe makes more sense just to remove this three lines instead of blindly replacing a function call? :P
aklapper requested review of D25222: Fix PHP 8.1 "strlen(null)" exception setting Story Points on a Task.
aklapper updated the diff for D25175: Fix PHP 8.1 "strlen(null)" and "explode()" exceptions which block rendering Administrator Account Creation page.
Add minimal strict short-circuit check as proposed by Valerio
aklapper requested review of D25219: Fix PHP 8.1 "strlen(null)" exceptions which block adding 2FA factor.
aklapper updated the task description for T15386: PHP 8.1 "strlen(null)" exception blocks rendering MFA Provider page.
aklapper committed rP4d1adf69392a: Fix PHP 8.1 "strlen(null)" exceptions which block rendering Log In page after….
Fix PHP 8.1 "strlen(null)" exceptions which block rendering Log In page after…
aklapper committed rP3a3112f67b4e: Fix PHP 8.1 "strlen(null)" and preg_match() exceptions which block rendering….
Fix PHP 8.1 "strlen(null)" and preg_match() exceptions which block rendering…
aklapper committed rPbac87ca2646b: Fix PHP 8.1 "strlen(null)" exception[s] which block rendering "Browse Projects"….
Fix PHP 8.1 "strlen(null)" exception[s] which block rendering "Browse Projects"…
aklapper committed rPc2856b479fbd: Fix PHP 8.1 "implicit conversion from float to int" exception on certain avatar….
Fix PHP 8.1 "implicit conversion from float to int" exception on certain avatar…
aklapper added a comment to D25209: Fix PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.
Thanks for the additional checking and docs!
valerio.bozzolan awarded D25212: Fix PHP 8.1 "ltrim(null)" exception which blocks rendering first Meme comment a Yellow Medal token.
May 10 2023
May 10 2023
aklapper updated the test plan for D25213: Fix PHP 8.1 "strlen(null)" exception[s] which block rendering "Browse Projects" overlay dialog.
aklapper updated the test plan for D25213: Fix PHP 8.1 "strlen(null)" exception[s] which block rendering "Browse Projects" overlay dialog.
aklapper closed T15377: PHP 8.1 "strlen(null)" exception when trying to add empty user email address, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
aklapper committed rP4d9719539773: Fix PHP 8.1 "strlen(null)" exception when trying to add empty user email address.
Fix PHP 8.1 "strlen(null)" exception when trying to add empty user email address
aklapper committed rPc86364c2aa6d: Fix PHP 8.1 "strlen(null)" exceptions which block rendering user page after….
Fix PHP 8.1 "strlen(null)" exceptions which block rendering user page after…
May 9 2023
May 9 2023
aklapper added a comment to D25209: Fix PHP 8.1 "implicit conversion from float to int" exception on certain avatar colors which blocks rendering user pages.
In D25209#6204, @valerio.bozzolan wrote:Just to clarify, do you have an idea about the input domain of $a? (I will test this tomorrow)
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0