Page MenuHomePhorge
Feed Advanced Search

May 3 2023

aklapper created T15335: PHP 8.1 null parameter exceptions block rendering the "Browse Projects" overlay dialog.
May 3 2023, 13:59 · Arcanist, PHP 8 support
valerio.bozzolan awarded T15270: "Access Denied: Restricted File" strings concatenated without whitespace a Like token.
May 3 2023, 13:06 · UX, Good Starter Task, Files
aklapper closed T15325: PHP 8.1 "strlen(null)" exceptions block rendering Auth's Customize Messages page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 3 2023, 10:51 · PHP 8 support
aklapper closed D25172: Fix PHP 8.1 "strlen(null)" exceptions which block rendering Auth's Customize Messages page.
May 3 2023, 10:51
aklapper closed T15325: PHP 8.1 "strlen(null)" exceptions block rendering Auth's Customize Messages page as Resolved by committing rP8a3e063000c5: Fix PHP 8.1 "strlen(null)" exceptions which block rendering Auth's Customize….
May 3 2023, 10:51 · PHP 8 support
aklapper committed rP8a3e063000c5: Fix PHP 8.1 "strlen(null)" exceptions which block rendering Auth's Customize….
Fix PHP 8.1 "strlen(null)" exceptions which block rendering Auth's Customize…
May 3 2023, 10:51
aklapper closed T15327: PHP 8.1 "strlen(null)" exception blocks rendering project's Configure Menu page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 3 2023, 10:50 · PHP 8 support
aklapper closed D25173: Fix PHP 8.1 "strlen(null)" exception which blocks rendering project's Configure Menu page.
May 3 2023, 10:50
aklapper closed T15327: PHP 8.1 "strlen(null)" exception blocks rendering project's Configure Menu page as Resolved by committing rPb0cfb6ca6aca: Fix PHP 8.1 "strlen(null)" exception which blocks rendering project's Configure….
May 3 2023, 10:50 · Projects, PHP 8 support
aklapper committed rPb0cfb6ca6aca: Fix PHP 8.1 "strlen(null)" exception which blocks rendering project's Configure….
Fix PHP 8.1 "strlen(null)" exception which blocks rendering project's Configure…
May 3 2023, 10:50
aklapper closed T15324: PHP 8.1 "strlen(null)" exception blocks rendering Configuration's Settings page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 3 2023, 08:25 · PHP 8 support
aklapper closed D25171: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Configuration's Settings page.
May 3 2023, 08:25
aklapper closed T15324: PHP 8.1 "strlen(null)" exception blocks rendering Configuration's Settings page as Resolved by committing rP0ceb44c38af5: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Configuration's….
May 3 2023, 08:25 · PHP 8 support
aklapper committed rP0ceb44c38af5: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Configuration's….
Fix PHP 8.1 "strlen(null)" exception which blocks rendering Configuration's…
May 3 2023, 08:25
aklapper closed T15317: PHP 8.1 "strlen(null)" exception blocks rendering the "Manage Menu" page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 3 2023, 08:21 · PHP 8 support
aklapper closed T15317: PHP 8.1 "strlen(null)" exception blocks rendering the "Manage Menu" page as Resolved by committing rP1d8483a9bd85: Fix PHP 8.1 "strlen(null)" exception which blocks rendering the "Manage Menu"….
May 3 2023, 08:21 · PHP 8 support
aklapper closed D25166: Fix PHP 8.1 "strlen(null)" exception which blocks rendering the "Manage Menu" page.
May 3 2023, 08:21
aklapper committed rP1d8483a9bd85: Fix PHP 8.1 "strlen(null)" exception which blocks rendering the "Manage Menu"….
Fix PHP 8.1 "strlen(null)" exception which blocks rendering the "Manage Menu"…
May 3 2023, 08:20

May 2 2023

valerio.bozzolan awarded D25174: Remove PHP Safe Mode related code a Manufacturing Defect? token.
May 2 2023, 20:59
aklapper updated the summary of D25176: Fix PHP 8.1 "strlen(null)" exception which blocks creating a project with an empty Description field.
May 2 2023, 19:23
aklapper requested review of D25177: Fix PHP 8.1 "strlen(null)" exception which blocks creating a project with an empty Description field.
May 2 2023, 19:22
aklapper requested review of D25176: Fix PHP 8.1 "strlen(null)" exception which blocks creating a project with an empty Description field.
May 2 2023, 19:20
aklapper created T15331: PHP 8.1 "strlen(null)" exceptions block creating a project with an empty Description field.
May 2 2023, 19:19 · Projects, Arcanist, PHP 8 support
aklapper added a comment to D25175: Fix PHP 8.1 "strlen(null)" and "explode()" exceptions which block rendering Administrator Account Creation page.

I am not sure about the assumption I made about the false return value of isRawCacheDataValid().

May 2 2023, 18:56
aklapper requested review of D25175: Fix PHP 8.1 "strlen(null)" and "explode()" exceptions which block rendering Administrator Account Creation page.
May 2 2023, 18:55
aklapper added a revision to T15284: Installation: PHP 8.1 "strlen(null)" and "explode" exceptions block rendering Administrator Account Creation page: D25175: Fix PHP 8.1 "strlen(null)" and "explode()" exceptions which block rendering Administrator Account Creation page.
May 2 2023, 18:55 · People, PHP 8 support
aklapper renamed T15284: Installation: PHP 8.1 "strlen(null)" and "explode" exceptions block rendering Administrator Account Creation page from Installation: PHP 8.1 exceptions block rendering Administrator Account Creation page to Installation: PHP 8.1 "strlen(null)" and "explode" exceptions block rendering Administrator Account Creation page.
May 2 2023, 18:49 · People, PHP 8 support
aklapper attached a referenced file: F285676: phabInitUser-15-54-45.png.
May 2 2023, 17:46 · People, PHP 8 support
aklapper attached a referenced file: F285684: phabInitUser-15-55-21.png.
May 2 2023, 17:46 · People, PHP 8 support
aklapper added a comment to D25164: Fix PHP 8.1 "rawurlencode(null)" exception which blocks rendering a project page.

@valerio.bozzolan: Ah, thanks. If there is an assumption that string passed to phutil_escape_uri($string) shall never ever be null and in that case there is always an underlying bug to fix (that wasn't clear to me), then I'd say adding a phlog() makes sense if it automagically includes a stacktrace and has clear instructions what a random Phorge admin seeing that log entry is supposed to do (like "Unexpected null string passed to phutil_escape_uri. Please report a bug at https://we.phorge.it/maniphest/ and mention T15263 in your task.") Okay.

May 2 2023, 15:53
valerio.bozzolan awarded D25164: Fix PHP 8.1 "rawurlencode(null)" exception which blocks rendering a project page a Like token.
May 2 2023, 15:32
aklapper merged T15330: Installing: PHP 8.1 exceptions block rendering Administrator Account Creation page into T15284: Installation: PHP 8.1 "strlen(null)" and "explode" exceptions block rendering Administrator Account Creation page.
May 2 2023, 14:51 · People, PHP 8 support
aklapper merged task T15330: Installing: PHP 8.1 exceptions block rendering Administrator Account Creation page into T15284: Installation: PHP 8.1 "strlen(null)" and "explode" exceptions block rendering Administrator Account Creation page.
May 2 2023, 14:51 · People, PHP 8 support
aklapper renamed T15284: Installation: PHP 8.1 "strlen(null)" and "explode" exceptions block rendering Administrator Account Creation page from PHP 8.1: Exception passing null trying to create initial user account to Installation: PHP 8.1 exceptions block rendering Administrator Account Creation page.
May 2 2023, 14:51 · People, PHP 8 support
aklapper updated the summary of D25164: Fix PHP 8.1 "rawurlencode(null)" exception which blocks rendering a project page.
May 2 2023, 14:48
aklapper updated the diff for D25164: Fix PHP 8.1 "rawurlencode(null)" exception which blocks rendering a project page.

If you want easy extra points, maybe this can be even more nice, using phlog():

May 2 2023, 14:47
aklapper added a comment to T15326: PHP 8.0 without GD installed: Unhandled Exception setting a project profile image: Call to undefined function imagecreatefromstring().

Pseudo code, not tested as other exceptions block me from testing:

May 2 2023, 14:22 · Files, PHP 8 support
aklapper created T15330: Installing: PHP 8.1 exceptions block rendering Administrator Account Creation page.
May 2 2023, 14:18 · People, PHP 8 support
aklapper closed T15329: Remove PHP Safe Mode related code as Wontfix.

No, I found this issue by reading the code. However, declining based on comments in D25174 as Phorge does not seem to check for PHP >= 5.5.

May 2 2023, 14:06 · Config
aklapper abandoned D25174: Remove PHP Safe Mode related code.
In D25174#5371, @avivey wrote:

Why won't this software run with safe_mode enabled?

May 2 2023, 14:06
aklapper requested review of D25174: Remove PHP Safe Mode related code.
May 2 2023, 13:14
aklapper added a revision to T15329: Remove PHP Safe Mode related code: D25174: Remove PHP Safe Mode related code.
May 2 2023, 13:14 · Config
aklapper created T15329: Remove PHP Safe Mode related code.
May 2 2023, 13:12 · Config

May 1 2023

aklapper requested review of D25173: Fix PHP 8.1 "strlen(null)" exception which blocks rendering project's Configure Menu page.
May 1 2023, 23:01
aklapper added a revision to T15327: PHP 8.1 "strlen(null)" exception blocks rendering project's Configure Menu page: D25173: Fix PHP 8.1 "strlen(null)" exception which blocks rendering project's Configure Menu page.
May 1 2023, 23:01 · Projects, PHP 8 support
aklapper retitled D25171: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Configuration's Settings page from Fix PHP 8.1 "strlen(null)" exception[s] which block rendering Configuration's Settings page
May 1 2023, 22:58
aklapper created T15327: PHP 8.1 "strlen(null)" exception blocks rendering project's Configure Menu page.
May 1 2023, 22:47 · Projects, PHP 8 support
aklapper renamed T15326: PHP 8.0 without GD installed: Unhandled Exception setting a project profile image: Call to undefined function imagecreatefromstring() from PHP 8.0 without GD installed: Unhandled Exception setting a project profile image to PHP 8.0 without GD installed: Unhandled Exception setting a project profile image: Call to undefined function imagecreatefromstring().
May 1 2023, 22:35 · Files, PHP 8 support
aklapper created T15326: PHP 8.0 without GD installed: Unhandled Exception setting a project profile image: Call to undefined function imagecreatefromstring().
May 1 2023, 22:35 · Files, PHP 8 support
aklapper updated the summary of D25166: Fix PHP 8.1 "strlen(null)" exception which blocks rendering the "Manage Menu" page.
May 1 2023, 21:59
aklapper updated the test plan for D25172: Fix PHP 8.1 "strlen(null)" exceptions which block rendering Auth's Customize Messages page.
May 1 2023, 21:48
aklapper updated the diff for D25172: Fix PHP 8.1 "strlen(null)" exceptions which block rendering Auth's Customize Messages page.

Cover another exception/stacktrace in the same file in this patch

May 1 2023, 21:47
aklapper updated the test plan for D25172: Fix PHP 8.1 "strlen(null)" exceptions which block rendering Auth's Customize Messages page.
May 1 2023, 21:46
aklapper updated the task description for T15325: PHP 8.1 "strlen(null)" exceptions block rendering Auth's Customize Messages page.
May 1 2023, 21:42 · PHP 8 support
aklapper requested review of D25172: Fix PHP 8.1 "strlen(null)" exceptions which block rendering Auth's Customize Messages page.
May 1 2023, 21:34
aklapper added a revision to T15325: PHP 8.1 "strlen(null)" exceptions block rendering Auth's Customize Messages page: D25172: Fix PHP 8.1 "strlen(null)" exceptions which block rendering Auth's Customize Messages page.
May 1 2023, 21:34 · PHP 8 support
aklapper created T15325: PHP 8.1 "strlen(null)" exceptions block rendering Auth's Customize Messages page.
May 1 2023, 21:33 · PHP 8 support
aklapper requested review of D25171: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Configuration's Settings page.
May 1 2023, 21:18
aklapper added a revision to T15324: PHP 8.1 "strlen(null)" exception blocks rendering Configuration's Settings page: D25171: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Configuration's Settings page.
May 1 2023, 21:18 · PHP 8 support
aklapper created T15324: PHP 8.1 "strlen(null)" exception blocks rendering Configuration's Settings page.
May 1 2023, 21:17 · PHP 8 support
aklapper added a comment to D25166: Fix PHP 8.1 "strlen(null)" exception which blocks rendering the "Manage Menu" page.

(When using arc diff --update it's still unclear to me how to update the commit message. It seems a separate comment gets added ( https://we.phorge.it/D25166#5298 ) instead.

May 1 2023, 21:08
aklapper updated the diff for D25166: Fix PHP 8.1 "strlen(null)" exception which blocks rendering the "Manage Menu" page.

Fix PHP 8.1 "strlen(null)" exception which blocks rendering the "Manage Menu" page

May 1 2023, 21:05
aklapper closed D25147: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page.
May 1 2023, 20:31
aklapper closed T15297: PHP 8.1 "strlen(null)" exceptions block rendering the People page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 1 2023, 20:31 · PHP 8 support
aklapper closed T15297: PHP 8.1 "strlen(null)" exceptions block rendering the People page as Resolved by committing rP8f669ea08289: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page.
May 1 2023, 20:31 · People, PHP 8 support
aklapper committed rP8f669ea08289: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page.
Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page
May 1 2023, 20:31
aklapper closed T15321: PHP 8.1 "strlen(null)" and "array_slice(null)" exceptions block typeahead completion proposals, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 1 2023, 20:29 · PHP 8 support
aklapper closed D25170: Fix PHP 8.1 "strlen(null)" and "array_slice(null)" exceptions which block typeahead completion proposals.
May 1 2023, 20:29
aklapper closed T15321: PHP 8.1 "strlen(null)" and "array_slice(null)" exceptions block typeahead completion proposals as Resolved by committing rPaea1d4737954: Fix PHP 8.1 "strlen(null)" and "array_slice(null)" exceptions which block….
May 1 2023, 20:29 · PHP 8 support
aklapper committed rPaea1d4737954: Fix PHP 8.1 "strlen(null)" and "array_slice(null)" exceptions which block….
Fix PHP 8.1 "strlen(null)" and "array_slice(null)" exceptions which block…
May 1 2023, 20:29
aklapper closed T15313: PHP 8.1 "strlen(null)" exceptions block rendering a project page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 1 2023, 20:26 · PHP 8 support
aklapper closed D25163: Fix some PHP 8.1 "strlen(null)" exceptions which block rendering a project page.
May 1 2023, 20:26
aklapper closed T15313: PHP 8.1 "strlen(null)" exceptions block rendering a project page as Resolved by committing rPdff04ba91d45: Fix some PHP 8.1 "strlen(null)" exceptions which block rendering a project page.
May 1 2023, 20:26 · Projects, PHP 8 support
aklapper committed rPdff04ba91d45: Fix some PHP 8.1 "strlen(null)" exceptions which block rendering a project page.
Fix some PHP 8.1 "strlen(null)" exceptions which block rendering a project page
May 1 2023, 20:26
aklapper closed T15303: PHP 8.1 "strlen(null)" exception blocks rendering the Projects page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 1 2023, 20:23 · PHP 8 support
aklapper closed D25153: Fix PHP 8.1 "strlen(null)" exception which blocks rendering the Projects page (and log alien values).
May 1 2023, 20:23
aklapper closed T15303: PHP 8.1 "strlen(null)" exception blocks rendering the Projects page as Resolved by committing rP4d88095f2a53: Fix PHP 8.1 "strlen(null)" exception which blocks rendering the Projects page….
May 1 2023, 20:23 · Projects, PHP 8 support
aklapper committed rP4d88095f2a53: Fix PHP 8.1 "strlen(null)" exception which blocks rendering the Projects page….
Fix PHP 8.1 "strlen(null)" exception which blocks rendering the Projects page…
May 1 2023, 20:22
aklapper closed T15320: PHP 8.1 "strlen(null)" exception blocks rendering the Notifications' Advanced Search page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 1 2023, 20:18 · PHP 8 support
aklapper closed T15320: PHP 8.1 "strlen(null)" exception blocks rendering the Notifications' Advanced Search page as Resolved by committing rPb44665aefe52: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Notifications'….
May 1 2023, 20:18 · PHP 8 support
aklapper closed D25169: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Notifications' Advanced Search page.
May 1 2023, 20:18
aklapper committed rPb44665aefe52: Fix PHP 8.1 "strlen(null)" exception which blocks rendering Notifications'….
Fix PHP 8.1 "strlen(null)" exception which blocks rendering Notifications'…
May 1 2023, 20:18
aklapper renamed T15177: Allow to query Tasks with a custom boolean field set to false from Allow to query Tasks with a custom boolen field set to false to Allow to query Tasks with a custom boolean field set to false.
May 1 2023, 20:16 · Maniphest, User-valerio.bozzolan
aklapper closed T15310: PHP 8.1 "strlen(null)" exception blocks rendering External Editor user settings page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 1 2023, 20:14 · PHP 8 support
aklapper closed D25160: Fix PHP 8.1 "strlen(null)" exception[s] which blocks rendering External Editor user settings page.
May 1 2023, 20:14
aklapper closed T15310: PHP 8.1 "strlen(null)" exception blocks rendering External Editor user settings page as Resolved by committing rP63647f41f826: Fix PHP 8.1 "strlen(null)" exception[s] which blocks rendering External Editor….
May 1 2023, 20:14 · PHP 8 support
aklapper committed rP63647f41f826: Fix PHP 8.1 "strlen(null)" exception[s] which blocks rendering External Editor….
Fix PHP 8.1 "strlen(null)" exception[s] which blocks rendering External Editor…
May 1 2023, 20:14
aklapper closed T15319: PHP 8.1 "strlen(null)" exception blocks rendering user's Edit Profile page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 1 2023, 20:05 · PHP 8 support
aklapper closed D25168: Fix PHP 8.1 "strlen(null)" exception which blocks rendering user's Edit Profile page.
May 1 2023, 20:05
aklapper closed T15319: PHP 8.1 "strlen(null)" exception blocks rendering user's Edit Profile page as Resolved by committing rP255325bd046b: Fix PHP 8.1 "strlen(null)" exception which blocks rendering user's Edit Profile….
May 1 2023, 20:05 · People, PHP 8 support
aklapper committed rP255325bd046b: Fix PHP 8.1 "strlen(null)" exception which blocks rendering user's Edit Profile….
Fix PHP 8.1 "strlen(null)" exception which blocks rendering user's Edit Profile…
May 1 2023, 20:05
aklapper closed T15318: PHP 8.1 "strlen(null)" exceptions block rendering the People page of a user, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 1 2023, 20:03 · PHP 8 support
aklapper closed D25167: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page of a user.
May 1 2023, 20:03
aklapper closed T15318: PHP 8.1 "strlen(null)" exceptions block rendering the People page of a user as Resolved by committing rP9aa8d09d3138: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page of….
May 1 2023, 20:03 · People, PHP 8 support
aklapper committed rP9aa8d09d3138: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page of….
Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page of…
May 1 2023, 20:03
aklapper closed T15301: PHP 8.1 "strlen(null)" exception blocks loading icons when creating new Diffusion repository, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 1 2023, 20:01 · PHP 8 support
aklapper closed D25151: Fix PHP 8.1 "strlen(null)" exception which blocks loading icons when creating new Diffusion repository.
May 1 2023, 20:01
aklapper closed T15301: PHP 8.1 "strlen(null)" exception blocks loading icons when creating new Diffusion repository as Resolved by committing rP5a76e8d26232: Fix PHP 8.1 "strlen(null)" exception which blocks loading icons when creating….
May 1 2023, 20:01 · Diffusion, PHP 8 support
aklapper committed rP5a76e8d26232: Fix PHP 8.1 "strlen(null)" exception which blocks loading icons when creating….
Fix PHP 8.1 "strlen(null)" exception which blocks loading icons when creating…
May 1 2023, 20:01
aklapper updated the diff for D25147: Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page.

Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page

May 1 2023, 18:31