Differential D25078

Trigger: Capitalize most Buzzwords in our Weird Way as usual
AbandonedPublic
Actions

Authored by valerio.bozzolan on Mar 22 2023, 00:08.

Details

Reviewers

Sten

Group Reviewers

O1: Blessed Committers

Test Plan

Open the Trigger Page from a Workboard Column
See that Most Things are Finally in this usual Weird Way

Diff Detail

Repository

rP Phorge

Branch

capitalize-stuff-randomly

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 140
Build 140: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	767 ms	PhabricatorCelerityTestCase::testCelerityMaps Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
	685 ms	PhabricatorConduitTestCase::testConduitMethods 1 assertion passed.
	225 ms	PhabricatorInfrastructureTestCase::testApplicationsInstalled 1 assertion passed.
	251 ms	PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries 1 assertion passed.
	323 ms	PhabricatorLibraryTestCase::testEverythingImplemented 1 assertion passed.
		View Full Test Results (1 Failed · 29 Passed)

Event Timeline

valerio.bozzolan created this revision.Mar 22 2023, 00:08

Owners added a reviewer: O1: Blessed Committers.Mar 22 2023, 00:08

Herald added subscribers: Cigaryno, Matthew, tobiaswiese, speck. · View Herald TranscriptMar 22 2023, 00:08

valerio.bozzolan requested review of this revision.Mar 22 2023, 00:08

Harbormaster completed remote builds in B140: Diff 352.Mar 22 2023, 00:08

update celerity to make the lint happy

Harbormaster completed remote builds in B141: Diff 353.Mar 22 2023, 00:10

valerio.bozzolan mentioned this in Z1: Phorge.Mar 22 2023, 14:34

valerio.bozzolan awarded a token.Mar 22 2023, 14:43

also fix small typo "elmement"

Harbormaster completed remote builds in B149: Diff 361.Mar 22 2023, 18:07

valerio.bozzolan mentioned this in 2023-03-27.Mar 27 2023, 13:59

valerio.bozzolan mentioned this in Wikimedia Hackaton 2023 Athens Code Sprint.May 18 2023, 10:16

Apart from the pre-existing 'Statues' typo, looks good to me...

src/applications/project/trigger/PhabricatorProjectTriggerManiphestStatusRule.php
27	Plural of 'Status' is 'Statuses'. 'Statues' is the plural of 'Statue', which is something different.

let's also fix a typo (thanks Sten)

Harbormaster completed remote builds in B737: Diff 1219.Aug 10 2023, 07:47

Part of this Diff has no sense now that I learned that... some of these has sense. Let's close.

In D25507#14716, @aklapper wrote:

In D25507#14682, @valerio.bozzolan wrote:

Yeah I honestly don't know if uppercase or lowercase.

In this case should be lower-case because consistency and because it's pretty much a full sentence.

Relevant. "User Profiles":

https://we.phorge.it/source/phorge/browse/master/src/applications/people/config/PhabricatorUserConfigOptions.php$7

That's probably a page title and thus title case.

Also, "User profiles", 4 lines below:

https://we.phorge.it/source/phorge/browse/master/src/applications/people/config/PhabricatorUserConfigOptions.php$7

That's probably a button text or such and seems to be sentence case...