Page MenuHomePhorge
Differential D25920

Fix invalid CSS vertical-align value for .fancy-datepicker-core
ClosedPublic
Actions

Authored by aklapper on Mon, Mar 24, 12:11.
Tags
None
Referenced Files
F3553962: D25920.1744965985.diff
Thu, Apr 17, 08:46
F3553956: D25920.1744965192.diff
Thu, Apr 17, 08:33
F3552386: D25920.1744904020.diff
Wed, Apr 16, 15:33
F3531977: D25920.1744889002.diff
Wed, Apr 16, 11:23
F3531956: D25920.1744887173.diff
Wed, Apr 16, 10:52
F3531953: D25920.1744886873.diff
Wed, Apr 16, 10:47
F3531918: D25920.1744886577.diff
Wed, Apr 16, 10:42
F3531881: D25920.1744886517.diff
Wed, Apr 16, 10:41
View All 34 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rPf62918b019fb: Fix invalid CSS vertical-align value for .fancy-datepicker-core
Summary

vertical-align: center is not a valid value per https://developer.mozilla.org/en-US/docs/Web/CSS/vertical-align.
Likely middle was meant.

Test Plan

Read CSS docs; check output of your web browser console. (Interstingly, https://jigsaw.w3.org/css-validator/validator does not complain.)

Diff Detail

Repository
rP Phorge
Branch
cssVertAlign (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1808
Build 1808: arc lint + arc unit

Event Timeline

aklapper created this revision.Mon, Mar 24, 12:11
Owners added a reviewer: O1: Blessed Committers.Mon, Mar 24, 12:11
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMon, Mar 24, 12:11

Thanks for this patch! Kind reminder: if you touched CSS or JavaScript, please remember to also run this:

./bin/celerity map

⚙️ Thanks! Bip bop I'm a bot - helping for T15209

aklapper requested review of this revision.Mon, Mar 24, 12:11
Harbormaster completed remote builds in B1799: Diff 2768.Mon, Mar 24, 12:11
valerio.bozzolan accepted this revision.Tue, Mar 25, 13:24
This revision is now accepted and ready to land.Tue, Mar 25, 13:24
aklapper updated this revision to Diff 2782.Tue, Mar 25, 13:27

git rebase master

Harbormaster completed remote builds in B1808: Diff 2782.Tue, Mar 25, 13:27
Closed by commit rPf62918b019fb: Fix invalid CSS vertical-align value for .fancy-datepicker-core. · Explain WhyTue, Mar 25, 13:28
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rPf62918b019fb: Fix invalid CSS vertical-align value for .fancy-datepicker-core.
aklapper mentioned this in Next Up.Tue, Mar 25, 13:28

Revision Contents
Changeset List

PathSizePackages
resources/
celerity/
O1: Blessed Committers
webroot/
rsrc/
css/
phui/
2 linesO1: Blessed Committers

Diff 2782

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/phui/phui-form-view.css

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0