Page MenuHomePhorge
Differential D25920

Fix invalid CSS vertical-align value for .fancy-datepicker-core
ClosedPublic
Actions

Authored by aklapper on Mon, Mar 24, 12:11.
Tags
None
Referenced Files
F3344842: D25920.1743684780.diff
Wed, Apr 2, 12:53
F3344217: D25920.1743683587.diff
Wed, Apr 2, 12:33
F3341682: D25920.1743656175.diff
Wed, Apr 2, 04:56
F3339361: D25920.1743618382.diff
Tue, Apr 1, 18:26
F3331228: D25920.1743503735.diff
Mon, Mar 31, 10:35
F3331197: D25920.1743502746.diff
Mon, Mar 31, 10:19
F3324487: D25920.1743401277.diff
Sun, Mar 30, 06:07
F3320456: D25920.1743329863.diff
Sat, Mar 29, 10:17
View All 13 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rPf62918b019fb: Fix invalid CSS vertical-align value for .fancy-datepicker-core
Summary

vertical-align: center is not a valid value per https://developer.mozilla.org/en-US/docs/Web/CSS/vertical-align.
Likely middle was meant.

Test Plan

Read CSS docs; check output of your web browser console. (Interstingly, https://jigsaw.w3.org/css-validator/validator does not complain.)

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper created this revision.Mon, Mar 24, 12:11
Owners added a reviewer: O1: Blessed Committers.Mon, Mar 24, 12:11
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMon, Mar 24, 12:11

Thanks for this patch! Kind reminder: if you touched CSS or JavaScript, please remember to also run this:

./bin/celerity map

⚙️ Thanks! Bip bop I'm a bot - helping for T15209

aklapper requested review of this revision.Mon, Mar 24, 12:11
Harbormaster completed remote builds in B1799: Diff 2768.Mon, Mar 24, 12:11
valerio.bozzolan accepted this revision.Tue, Mar 25, 13:24
This revision is now accepted and ready to land.Tue, Mar 25, 13:24
aklapper updated this revision to Diff 2782.Tue, Mar 25, 13:27

git rebase master

Harbormaster completed remote builds in B1808: Diff 2782.Tue, Mar 25, 13:27
Closed by commit rPf62918b019fb: Fix invalid CSS vertical-align value for .fancy-datepicker-core. · Explain WhyTue, Mar 25, 13:28
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rPf62918b019fb: Fix invalid CSS vertical-align value for .fancy-datepicker-core.
aklapper mentioned this in Next Up.Tue, Mar 25, 13:28

Revision Contents
Changeset List

PathSizePackages
resources/
celerity/
O1: Blessed Committers
webroot/
rsrc/
css/
phui/
2 linesO1: Blessed Committers

Diff 2783

View Options

resources/celerity/map.php

Show First 20 Lines • Show All 271 Lines • ▼ Show 20 Lines private function writeStrings($root, array $strings) {
$this->writeCache($root, 'i18n_strings.json', $json); $this->writeCache($root, 'i18n_strings.json', $json);
} }
private function loadLibraryFiles($root) { private function loadLibraryFiles($root) {
$files = id(new FileFinder($root)) $files = id(new FileFinder($root))
->withType('f') ->withType('f')
->withSuffix('php') ->withSuffix('php')
->excludePath('*/.*') ->excludePath('*/.*')
->excludePath('*/__tests__/*')
->setGenerateChecksums(true) ->setGenerateChecksums(true)
->find(); ->find();
$map = array(); $map = array();
foreach ($files as $file => $hash) { foreach ($files as $file => $hash) {
$file = Filesystem::readablePath($file, $root); $file = Filesystem::readablePath($file, $root);
$file = ltrim($file, '/'); $file = ltrim($file, '/');
▲ Show 20 Lines • Show All 67 Lines • Show Last 20 Lines
View Options

webroot/rsrc/css/phui/phui-form-view.css

Show First 20 Lines • Show All 271 Lines • ▼ Show 20 Lines private function writeStrings($root, array $strings) {
$this->writeCache($root, 'i18n_strings.json', $json); $this->writeCache($root, 'i18n_strings.json', $json);
} }
private function loadLibraryFiles($root) { private function loadLibraryFiles($root) {
$files = id(new FileFinder($root)) $files = id(new FileFinder($root))
->withType('f') ->withType('f')
->withSuffix('php') ->withSuffix('php')
->excludePath('*/.*') ->excludePath('*/.*')
->excludePath('*/__tests__/*')
->setGenerateChecksums(true) ->setGenerateChecksums(true)
->find(); ->find();
$map = array(); $map = array();
foreach ($files as $file => $hash) { foreach ($files as $file => $hash) {
$file = Filesystem::readablePath($file, $root); $file = Filesystem::readablePath($file, $root);
$file = ltrim($file, '/'); $file = ltrim($file, '/');
▲ Show 20 Lines • Show All 67 Lines • Show Last 20 Lines
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0