Page MenuHomePhorge
Differential D25854

Phriction: fix issue with icons in table of contents on wide screens
ClosedPublic
Actions

Authored by mturdus on Wed, Dec 11, 17:47.

Details

Reviewers
aklapper
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15920: Make table of contents visible when using wide screens
Commits
rP4accca842029: Phriction: fix issue with icons in table of contents on wide screens
Summary

When using icons in front of a header title, a part of the icon was
not visible in the TOC on wide screens.

BeforeAfter
BEFORE.png (1×1 px, 176 KB)
AFTER.png (1×1 px, 176 KB)

Look at the table of contents on the left side.

Closes T15920

Test Plan

Steps to reproduce in a Phriction document:

== {icon users} How to Register-in ==

=== {icon heart spin} Credits ===

Verify if all icons are visible in TOC.

Diff Detail

Repository
rP Phorge
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1662
Build 1662: arc lint + arc unit

Event Timeline

mturdus created this revision.Wed, Dec 11, 17:47
Owners added a reviewer: O1: Blessed Committers.Wed, Dec 11, 17:47
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptWed, Dec 11, 17:47
Harbormaster completed remote builds in B1662: Diff 2587.Wed, Dec 11, 17:47
mturdus requested review of this revision.Wed, Dec 11, 17:47
aklapper accepted this revision.Wed, Dec 11, 19:16
aklapper subscribed.

Thanks for the super-quick patch! I can confirm that this fixes the issue in the Phriction ToC on wider screens.

This revision is now accepted and ready to land.Wed, Dec 11, 19:16
valerio.bozzolan accepted this revision.Thu, Dec 12, 09:16
valerio.bozzolan edited the summary of this revision. (Show Details)
valerio.bozzolan edited the test plan for this revision. (Show Details)

It also works with icons that are spinning lol thanks

valerio.bozzolan retitled this revision from Fix issue with icons in table of contents on wide screens to Phriction: fix issue with icons in table of contents on wide screens.Thu, Dec 12, 10:10
valerio.bozzolan edited the test plan for this revision. (Show Details)
Closed by commit rP4accca842029: Phriction: fix issue with icons in table of contents on wide screens. · Explain WhyThu, Dec 12, 15:50
This revision was automatically updated to reflect the committed changes.
mturdus added a commit: rP4accca842029: Phriction: fix issue with icons in table of contents on wide screens.

Revision Contents
Changeset List

PathSizePackages
resources/
celerity/
O1: Blessed Committers
webroot/
rsrc/
css/
phui/
9 linesO1: Blessed Committers

Diff 2587

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/phui/phui-document-pro.css

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0