Phriction: fix issue with icons in table of contents on wide screens
ClosedPublic
Actions

Authored by mturdus on Dec 11 2024, 17:47.

Details

Reviewers

aklapper
valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15920: Make table of contents visible when using wide screens

Commits

rP4accca842029: Phriction: fix issue with icons in table of contents on wide screens

Summary

When using icons in front of a header title, a part of the icon was
not visible in the TOC on wide screens.

Before	After

Look at the table of contents on the left side.

Closes T15920

Test Plan

Steps to reproduce in a Phriction document:

== {icon users} How to Register-in ==

=== {icon heart spin} Credits ===

Verify if all icons are visible in TOC.

Diff Detail

Repository

rP Phorge

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1662
Build 1662: arc lint + arc unit

Event Timeline

mturdus created this revision.Dec 11 2024, 17:47

Owners added a reviewer: O1: Blessed Committers.Dec 11 2024, 17:47

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptDec 11 2024, 17:47

Harbormaster completed remote builds in B1662: Diff 2587.Dec 11 2024, 17:47

mturdus requested review of this revision.Dec 11 2024, 17:47

Thanks for the super-quick patch! I can confirm that this fixes the issue in the Phriction ToC on wider screens.

This revision is now accepted and ready to land.Dec 11 2024, 19:16

It also works with icons that are spinning lol thanks

valerio.bozzolan retitled this revision from Fix issue with icons in table of contents on wide screens to Phriction: fix issue with icons in table of contents on wide screens.Dec 12 2024, 10:10

valerio.bozzolan edited the test plan for this revision. (Show Details)

Closed by commit rP4accca842029: Phriction: fix issue with icons in table of contents on wide screens. · Explain WhyDec 12 2024, 15:50

This revision was automatically updated to reflect the committed changes.

mturdus added a commit: rP4accca842029: Phriction: fix issue with icons in table of contents on wide screens.

Revision Contents
Changeset List

Path

Size

Packages

resources/

celerity/

map.php

O1: Blessed Committers

webroot/

rsrc/

css/

phui/

phui-document-pro.css

9 lines

O1: Blessed Committers

Diff 2587

View Options

resources/celerity/map.php

	<?php			<?php

	final class PhabricatorDatasourceURIEngineExtension			final class PhabricatorDatasourceURIEngineExtension
	extends PhabricatorDatasourceEngineExtension {			extends PhabricatorDatasourceEngineExtension {

	public function newQuickSearchDatasources() {			public function newQuickSearchDatasources() {
	return array();			return array();
	}			}

	public function newJumpURI($query) {			public function newJumpURI($query) {
	// If you search for a URI on the local install, just redirect to that			// If you search for a URI on the local install, just redirect to that
	// URI as though you had pasted it into the URI bar.			// URI as though you had pasted it into the URI bar.
	if (PhabricatorEnv::isSelfURI($query)) {			// Skip things that are really not full URLs, like "asdasd".
				// Note that the backend of "isSelfURI" is faster with a PhutilURI.
				$uri = new PhutilURI($query);
				if ($uri->getDomain() === '' \|\| !PhabricatorEnv::isSelfURI($uri)) {
				speckUnsubmitted Not Done Inline Actions Could this be combined with the next if statement, inverted? Looks like if the next if statement fails then it also returns null, and combining would simplify the logic here. speck: Could this be combined with the next if statement, inverted? Looks like if the next if…
				return null;
				}

	// Strip off the absolute part of the URI. If we don't, the URI redirect			// Strip off the absolute part of the URI. If we don't, the URI redirect
	// validator will get upset that we're performing an unmarked external			// validator will get upset that we're performing an unmarked external
	// redirect.			// redirect.

	// The correct host and protocol may also differ from the host and			// The correct host and protocol may also differ from the host and
	// protocol used in the search: for example, if you search for "http://"			// protocol used in the search: for example, if you search for "http://"
	// we want to redirect to "https://" if an install is HTTPS, and			// we want to redirect to "https://" if an install is HTTPS, and
	// the "isSelfURI()" check includes alternate domains in addition to the			// the "isSelfURI()" check includes alternate domains in addition to the
	// canonical domain.			// canonical domain.
				$uri = $uri
	$uri = id(new PhutilURI($query))
	->setDomain(null)			->setDomain(null)
	->setProtocol(null)			->setProtocol(null)
	->setPort(null);			->setPort(null);

	$uri = phutil_string_cast($uri);			$uri = phutil_string_cast($uri);

	// See T13412. If the URI was in the form "http://dev.example.com" with			// See T13412. If the URI was in the form "http://dev.example.com" with
	// no trailing slash, there may be no path. Redirecting to the empty			// no trailing slash, there may be no path. Redirecting to the empty
	// string is considered an error by safety checks during redirection,			// string is considered an error by safety checks during redirection,
	// so treat this like the user entered the URI with a trailing slash.			// so treat this like the user entered the URI with a trailing slash.
	if (!strlen($uri)) {			if (!strlen($uri)) {
	$uri = '/';			$uri = '/';
	}			}

	return $uri;			return $uri;
	}			}

	return null;
	}
	}			}

View Options

webroot/rsrc/css/phui/phui-document-pro.css

	<?php			<?php

	final class PhabricatorDatasourceURIEngineExtension			final class PhabricatorDatasourceURIEngineExtension
	extends PhabricatorDatasourceEngineExtension {			extends PhabricatorDatasourceEngineExtension {

	public function newQuickSearchDatasources() {			public function newQuickSearchDatasources() {
	return array();			return array();
	}			}

	public function newJumpURI($query) {			public function newJumpURI($query) {
	// If you search for a URI on the local install, just redirect to that			// If you search for a URI on the local install, just redirect to that
	// URI as though you had pasted it into the URI bar.			// URI as though you had pasted it into the URI bar.
	if (PhabricatorEnv::isSelfURI($query)) {			// Skip things that are really not full URLs, like "asdasd".
				// Note that the backend of "isSelfURI" is faster with a PhutilURI.
				$uri = new PhutilURI($query);
				if ($uri->getDomain() === '' \|\| !PhabricatorEnv::isSelfURI($uri)) {
				speckUnsubmitted Not Done Inline Actions Could this be combined with the next if statement, inverted? Looks like if the next if statement fails then it also returns null, and combining would simplify the logic here. speck: Could this be combined with the next if statement, inverted? Looks like if the next if…
				return null;
				}

	// Strip off the absolute part of the URI. If we don't, the URI redirect			// Strip off the absolute part of the URI. If we don't, the URI redirect
	// validator will get upset that we're performing an unmarked external			// validator will get upset that we're performing an unmarked external
	// redirect.			// redirect.

	// The correct host and protocol may also differ from the host and			// The correct host and protocol may also differ from the host and
	// protocol used in the search: for example, if you search for "http://"			// protocol used in the search: for example, if you search for "http://"
	// we want to redirect to "https://" if an install is HTTPS, and			// we want to redirect to "https://" if an install is HTTPS, and
	// the "isSelfURI()" check includes alternate domains in addition to the			// the "isSelfURI()" check includes alternate domains in addition to the
	// canonical domain.			// canonical domain.
				$uri = $uri
	$uri = id(new PhutilURI($query))
	->setDomain(null)			->setDomain(null)
	->setProtocol(null)			->setProtocol(null)
	->setPort(null);			->setPort(null);

	$uri = phutil_string_cast($uri);			$uri = phutil_string_cast($uri);

	// See T13412. If the URI was in the form "http://dev.example.com" with			// See T13412. If the URI was in the form "http://dev.example.com" with
	// no trailing slash, there may be no path. Redirecting to the empty			// no trailing slash, there may be no path. Redirecting to the empty
	// string is considered an error by safety checks during redirection,			// string is considered an error by safety checks during redirection,
	// so treat this like the user entered the URI with a trailing slash.			// so treat this like the user entered the URI with a trailing slash.
	if (!strlen($uri)) {			if (!strlen($uri)) {
	$uri = '/';			$uri = '/';
	}			}

	return $uri;			return $uri;
	}			}

	return null;
	}
	}			}

Phriction: fix issue with icons in table of contents on wide screensClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2587

resources/celerity/map.php

webroot/rsrc/css/phui/phui-document-pro.css

Phriction: fix issue with icons in table of contents on wide screens
ClosedPublic
Actions

Revision Contents
Changeset List