Page MenuHomePhorge

Add flexible line height to remarkup headers
ClosedPublic

Authored by bekay on Jan 22 2024, 16:57.

Details

Summary

The text in remarkup has a fixed line height. The headers will have the same fixed line height, even if their font size can be bigger than this line height. Especially on mobile this results in ugly sticked together lines which are less readable.

This revision will give the header a flexible line height of 1.3. Unitless means relative to the font size.

BeforeAfter
image.png (201×310 px, 14 KB)
image.png (258×309 px, 16 KB)

(I have moved the same margin attribute for every h{2-6} into the new declaration.)

Close T15716.

Test Plan

Just checkout and look in wiki articles with headers to see if everything looks nice and neat.

Diff Detail

Repository
rP Phorge
Branch
T15716
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1034
Build 1034: arc lint + arc unit

Event Timeline

bekay requested review of this revision.Jan 22 2024, 16:57

I'm inclined to merge this. Any objections?

This revision is now accepted and ready to land.Jan 26 2024, 05:06