Paths

Table of Contentst

Differential D26007

Remove unused CSS file aphront/panel-view.css
ClosedPublic
Actions

Authored by aklapper on Fri, May 9, 12:40.

Tags

None

Referenced Files

	F4379527: D26007.1748457164.diff
	Tue, May 27, 18:32

	F4370271: D26007.1748428533.diff
	Tue, May 27, 10:35

	F4368118: D26007.1748421465.diff
	Tue, May 27, 08:37

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPd784533cf71d: Remove unused CSS file aphront/panel-view.css

Summary

aphront-panel-flush
- Added in https://we.phorge.it/rP3f11c8a602f0a7567f8a51bc3b1a2dddbd46eec2, usage removed in https://we.phorge.it/rPc05306d746d7e06e3f2a5eb712af89a616abfdc6 by deleting src/applications/differential/view/DifferentialAddCommentView.php
aphront-panel-preview
- Added in https://we.phorge.it/rP3f11c8a602f0a7567f8a51bc3b1a2dddbd46eec2, usage removed in https://we.phorge.it/rP6bfb101aff20a1f1f0435178e2de044a945676ba and in https://we.phorge.it/rPc05306d746d7e06e3f2a5eb712af89a616abfdc6 by deleting src/applications/differential/view/DifferentialAddCommentView.php
aphront-panel-preview-loading-text
- Added in https://we.phorge.it/rP3f11c8a602f0a7567f8a51bc3b1a2dddbd46eec2, usage removed in https://we.phorge.it/rP6bfb101aff20a1f1f0435178e2de044a945676ba and in https://we.phorge.it/rPc05306d746d7e06e3f2a5eb712af89a616abfdc6 by deleting src/applications/differential/view/DifferentialAddCommentView.php

Test Plan

Grep the code for each CSS selector (grep --exclude="*.css" -R 'some-search-string' .), also do partial searches, get no results.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Fri, May 9, 12:40

Owners added a reviewer: O1: Blessed Committers.Fri, May 9, 12:40

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFri, May 9, 12:40

aklapper requested review of this revision.Fri, May 9, 12:40

Harbormaster completed remote builds in B1963: Diff 3025.Fri, May 9, 12:40

Maybe also we can drop something from ./webroot/rsrc/css/core/remarkup.css - since it seems to contain .aphront-panel-preview ( .aphront-panel-preview .phabricator-remarkup-mention-unknown)

aklapper edited the summary of this revision. (Show Details)Fri, May 9, 12:57

@valerio.bozzolan core/remarkup.css has five more unused selectors so I'd put them all together into one patch.

Flagging as "andre is merging stuff https://we.phorge.it/D26007#26996"

This revision now requires changes to proceed.Thu, May 22, 12:49

In D26007#26996, @aklapper wrote:

@valerio.bozzolan core/remarkup.css has five more unused selectors so I'd put them all together into one patch.

This very patch is about removing an unused CSS file called aphront/panel-view.css.
Removing orphan CSS selectors in core/remarkup.css is covered in D26016 instead - different topic.

aklapper requested review of this revision.Fri, May 23, 17:21

Unlocking patch

valerio.bozzolan removed a reviewer: valerio.bozzolan.Fri, May 23, 17:26

You grep like a rockstar

This revision is now accepted and ready to land.Fri, May 23, 17:29

no no I rock like a grapstar

git rebase master

Harbormaster completed remote builds in B2012: Diff 3095.Fri, May 23, 21:44

Closed by commit rPd784533cf71d: Remove unused CSS file aphront/panel-view.css. · Explain WhySat, May 24, 07:28

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPd784533cf71d: Remove unused CSS file aphront/panel-view.css.

Revision Contents
Changeset List

Path

Size

Packages

resources/

celerity/

O1: Blessed Committers

1 line

O1: Blessed Committers

webroot/

rsrc/

css/

aphront/

O1: Blessed Committers

Diff 3096

resources/celerity/map.php

Loading...

resources/celerity/packages.php

Loading...

webroot/rsrc/css/aphront/panel-view.css

Loading...