Revert "Fix editing Conpherence rooms on mobile"
ClosedPublic
Actions

Authored by aklapper on Tue, Apr 22, 12:55.

Details

Reviewers

Group Reviewers

Maniphest Tasks

T15513: Cannot edit Conpherence rooms on mobile
T16040: Regression: Sending a message in Conpherence rooms opens dialog to edit room

Commits

rPcadc00d744eb: Revert "Fix editing Conpherence rooms on mobile"

Summary

This reverts commit fd6118bfa601c1f48923cbe3f5d6bab61d5b36ab.

Closes T16040

Reopens T15513

Test Plan

Write text in a Conpherence room and press Enter to send the text.

Test again, as non-participant, on a public chat. Still works.

Diff Detail

Repository

rP Phorge

Branch

T16040revertD25879 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1881
Build 1881: arc lint + arc unit

Event Timeline

aklapper created this revision.Tue, Apr 22, 12:55

Owners added a reviewer: O1: Blessed Committers.Tue, Apr 22, 12:55

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptTue, Apr 22, 12:55

aklapper requested review of this revision.Tue, Apr 22, 12:55

Harbormaster completed remote builds in B1881: Diff 2895.Tue, Apr 22, 12:55

Oh boy. Thanks

This revision is now accepted and ready to land.Tue, Apr 22, 12:57

Closed by commit rPcadc00d744eb: Revert "Fix editing Conpherence rooms on mobile". · Explain WhyTue, Apr 22, 13:16

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPcadc00d744eb: Revert "Fix editing Conpherence rooms on mobile".

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

resources/

celerity/

map.php

100%

O1: Blessed Committers

src/

applications/

conpherence/

application/

PhabricatorConpherenceApplication.php

2 lines

O1: Blessed Committers

controller/

ConpherenceController.php

4 lines

O1: Blessed Committers

ConpherenceParticipantController.php

2 lines

O1: Blessed Committers

ConpherenceUpdateController.php

4 lines

O1: Blessed Committers

ConpherenceViewController.php

2 lines

O1: Blessed Committers

view/

ConpherenceDurableColumnView.php

4 lines

O1: Blessed Committers

webroot/

rsrc/

js/

application/

conpherence/

ConpherenceThreadManager.js

2 lines

O1: Blessed Committers

Diff 2895

View Options

resources/celerity/map.php

View Options

src/applications/conpherence/application/PhabricatorConpherenceApplication.php

View Options

src/applications/conpherence/controller/ConpherenceController.php

View Options

src/applications/conpherence/controller/ConpherenceParticipantController.php

View Options

src/applications/conpherence/controller/ConpherenceUpdateController.php

View Options

src/applications/conpherence/controller/ConpherenceViewController.php

View Options

src/applications/conpherence/view/ConpherenceDurableColumnView.php

View Options

webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js

Revert "Fix editing Conpherence rooms on mobile"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2895

resources/celerity/map.php

src/applications/conpherence/application/PhabricatorConpherenceApplication.php

src/applications/conpherence/controller/ConpherenceController.php

src/applications/conpherence/controller/ConpherenceParticipantController.php

src/applications/conpherence/controller/ConpherenceUpdateController.php

src/applications/conpherence/controller/ConpherenceViewController.php

src/applications/conpherence/view/ConpherenceDurableColumnView.php

webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js

Revert "Fix editing Conpherence rooms on mobile"
ClosedPublic
Actions

Revision Contents
Changeset List