Paths

Table of Contentst

Differential D25706

Remove workaround for IE8 to avoid mixed content warning
AbandonedPublic
Actions

Authored by aklapper on Jun 29 2024, 18:24.

Details

Reviewers

None

Group Reviewers

O1: Blessed Committers

Summary

Internet Explorer 8 displayed a bogus mixed content security warning when the src attribute was set to javascript:void(0).

See for example https://jira.atlassian.com/browse/CONFSERVER-15590 or https://blog.httpwatch.com/2009/09/17/even-more-problems-with-the-ie-8-mixed-content-warning/

This reverts rP34db006c4b6cc5f7627d582ded3001168f75ca68

Test Plan

None.

Diff Detail

Repository

rP Phorge

Branch

ie8mixedContentJS

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1382
Build 1382: arc lint + arc unit

Event Timeline

aklapper created this revision.Jun 29 2024, 18:24

Owners added a reviewer: O1: Blessed Committers.Jun 29 2024, 18:24

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJun 29 2024, 18:24

aklapper requested review of this revision.Jun 29 2024, 18:24

Harbormaster completed remote builds in B1382: Diff 2170.Jun 29 2024, 18:24

what will this do?

A day later this turns out to be a rather stupid patch. Things should remain as is as javascript:void(0) nowadays may trigger CSP errors.

Revision Contents
Changeset List

Path

Size

Packages

resources/

celerity/

map.php

O1: Blessed Committers

webroot/

rsrc/

externals/

javelin/

core/

init.js

3 lines

O1: Blessed Committers

Diff 2170

View Options

resources/celerity/map.php

View Options

webroot/rsrc/externals/javelin/core/init.js

Remove workaround for IE8 to avoid mixed content warningAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2170

resources/celerity/map.php

webroot/rsrc/externals/javelin/core/init.js

Remove workaround for IE8 to avoid mixed content warning
AbandonedPublic
Actions

Revision Contents
Changeset List