Page MenuHomePhorge
Files F2647389

D25069.1732366866.diff
No OneTemporary
Actions

D25069.1732366866.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -10,7 +10,7 @@
'conpherence.pkg.css' => '0e3cf785',
'conpherence.pkg.js' => '020aebcf',
'core.pkg.css' => 'f538846d',
- 'core.pkg.js' => '256dfd7b',
+ 'core.pkg.js' => '6a2c22c2',
'dark-console.pkg.js' => '187792c2',
'differential.pkg.css' => '609e63d4',
'differential.pkg.js' => 'c60bec1b',
@@ -265,7 +265,7 @@
'rsrc/externals/javelin/lib/__tests__/behavior.js' => '8426ebeb',
'rsrc/externals/javelin/lib/behavior.js' => '1b6acc2a',
'rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js' => '89a1ae3a',
- 'rsrc/externals/javelin/lib/control/typeahead/Typeahead.js' => 'a4356cde',
+ 'rsrc/externals/javelin/lib/control/typeahead/Typeahead.js' => 'd96e47a4',
'rsrc/externals/javelin/lib/control/typeahead/normalizer/TypeaheadNormalizer.js' => 'a241536a',
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadCompositeSource.js' => '22ee68a5',
'rsrc/externals/javelin/lib/control/typeahead/source/TypeaheadOnDemandSource.js' => '23387297',
@@ -731,7 +731,7 @@
'javelin-sound' => 'd4cc2d2a',
'javelin-stratcom' => '0889b835',
'javelin-tokenizer' => '89a1ae3a',
- 'javelin-typeahead' => 'a4356cde',
+ 'javelin-typeahead' => 'd96e47a4',
'javelin-typeahead-composite-source' => '22ee68a5',
'javelin-typeahead-normalizer' => 'a241536a',
'javelin-typeahead-ondemand-source' => '23387297',
@@ -1800,12 +1800,6 @@
'javelin-workflow',
'phabricator-draggable-list',
),
- 'a4356cde' => array(
- 'javelin-install',
- 'javelin-dom',
- 'javelin-vector',
- 'javelin-util',
- ),
'a43ae2ae' => array(
'javelin-install',
'javelin-dom',
@@ -2100,6 +2094,12 @@
'javelin-util',
'phabricator-shaped-request',
),
+ 'd96e47a4' => array(
+ 'javelin-install',
+ 'javelin-dom',
+ 'javelin-vector',
+ 'javelin-util',
+ ),
'da15d3dc' => array(
'phui-oi-list-view-css',
),
diff --git a/webroot/rsrc/externals/javelin/lib/control/typeahead/Typeahead.js b/webroot/rsrc/externals/javelin/lib/control/typeahead/Typeahead.js
--- a/webroot/rsrc/externals/javelin/lib/control/typeahead/Typeahead.js
+++ b/webroot/rsrc/externals/javelin/lib/control/typeahead/Typeahead.js
@@ -84,8 +84,19 @@
'mousedown',
'tag:a',
JX.bind(this, function(e) {
- if (!e.isRightButton()) {
+ if (e.isNormalMouseEvent()) {
this._choose(e.getNode('tag:a'));
+ } else {
+ // fix the middle-click and any non-normal mouse event
+ // in order to have an "open in a new tab" that just works natively
+ // or any other browser action that is supposed to be there.
+ //
+ // Probably this is one of the specific cases where kill() has
+ // sense instead of just stop(), since there are not much chances
+ // that another event listener had anything else to do
+ // during non-normal mousedown/click events.
+ // https://we.phorge.it/T15149
+ e.kill();
}
}));

File Metadata

Mime Type
text/plain
Expires
Sat, Nov 23, 13:01 (18 h, 9 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
991525
Default Alt Text
D25069.1732366866.diff (3 KB)

Event Timeline

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0