Things that are obviously bugs
Details
Mon, Jun 9
We end up in the depths of ArcanistBundle::newBase85Data() here.
Which tries to copy behavior of https://github.com/git/git/blob/master/diff.c#L3325-L3395 which may have changed over time (or not).
I'm still wondering if this is a change in git (the software) creating a binary diff which Phorge then compares to https://we.phorge.it/source/arcanist/browse/master/src/parser/__tests__/patches//5dec8bf28557f078d1987c4e8cfb53d08310f522.gitpatch.
@valerio.bozzolan See last code block in the task description
Fri, Jun 6
Wed, May 28
Sun, May 25
Thu, May 22
Questions about the steps:
Tue, May 20
Sat, May 17
Fri, May 16
@A_smart_kitten you are super-super-welcome if you create another parent task like this https://web.archive.org/web/20250218071010/https://secure.phabricator.com/T12486 so " Search exclude-by-tag doesn't work consistently with subprojects" - since I completely agree on your point but I'm unsure how to manage it, so here T15828 we become just one of your sub-tasks.
- 🔶 this task (T15828) is not reporting a real-world thing about this use with sub-projects
FWIW, my use case from today in terms of sub-projects was attempting to search tasks on Wikimedia Phabricator that were tagged with either #MediaWiki-Recent-changes or #Edit-Review-Improvements (or a subproject thereof).
Triaging a bit more than "Wishlist" and a bit less than "Normal" since a prototype is actionable but we still lived years without this... so, "Low".
OK hackers, thanks for stimulating a follow-up. I've studied this a bit and I have a more clear opinion. Let's write some notes down.
Gonna boldly call it a bug, given that I was about to file an upstream bug report for https://phabricator.wikimedia.org/T386830 before I came across this task :)
May 14 2025
Testing this a bit myself again, I discovered that actually this problem affects both Git and SVN, it just wasn't being noticed in my SVN testing because it doesn't go wrong if run from any subfolder. So for example in a checkout of rARC, running arc browse . in the root directory will pop one into the bogus path of, say, https://we.phorge.it/source/arcanist/browse/master/home/keithzg/Code/git/arcanist, but if I'm in my local ~/Code/git/arcanist/src/ then arc browse . pops open https://we.phorge.it/source/arcanist/browse/master/src as intended.
Thanks, @valerio.bozzolan! :D
May 13 2025
May 12 2025
May 9 2025
Thanks. I pinpoint also here your super-relevant extra details: https://we.phorge.it/D25887#26924
May 3 2025
Covered, thanks for review :3
Thaanks. Can reproduce in latest master. Premising that uhmmmm probably it seems we are not using the API correctly as the correct usage seems with objectType=TASK. Example to get my transactions: