Page MenuHomePhorge

Bug ReportsBugs
ActivePublic

Members

  • This project does not have any members.
  • View All

Watchers (1)

Details

Description

Things that are obviously bugs

Recent Activity

Yesterday

kat added a comment to T15956: Conpherence Persistent Chat does not attach files to message when pasted.

Yep. I'm up-to-date with master as of filing the issue^^.
This textbox isn't a Remarkup field (it's actually a ConpherenceDurableColumnView, which doesn't even have a metadata field in the first place)
In normal Conpherence views, the "Upload file" button works just fine. (except as mentioned in Z1, where reloading the page erases the metadata field)

Fri, Nov 15, 13:00 · Bug Reports
valerio.bozzolan added a comment to T15956: Conpherence Persistent Chat does not attach files to message when pasted.

Thanks. Can you reproduce with "Upload file" button too? If yes, maybe sub-task of: T15106: "Upload file" in remarkup text fields should attach by default

Fri, Nov 15, 12:03 · Bug Reports
kat created T15956: Conpherence Persistent Chat does not attach files to message when pasted.
Fri, Nov 15, 11:37 · Bug Reports

Fri, Oct 25

aklapper added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing.

This exception happens once $rule in the loop foreach ($this->getMarkupRules() as $rule) in PhutilRemarkupBlockRule::applyRules($text) becomes ProjectRemarkupRule. That's where it blows up.

Fri, Oct 25, 10:19 · Bug Reports, Remarkup, Affects-Wikimedia

Sep 17 2024

tiantiandas closed Q149: [BUG] Conduit API call error: Call to phutil_nonempty_string() expected null or a string, got: float. as obsolete.
Sep 17 2024, 00:17 · Bug Reports, Phorge

Sep 9 2024

valerio.bozzolan added a parent task for T15872: Understand how to defuse localization in GNU Gettext: T15927: Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal.
Sep 9 2024, 13:52 · Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan added a subtask for T15927: Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal: T15872: Understand how to defuse localization in GNU Gettext.
Sep 9 2024, 13:52 · User-valerio.bozzolan

Sep 5 2024

tiantiandas asked Q149: [BUG] Conduit API call error: Call to phutil_nonempty_string() expected null or a string, got: float..
Sep 5 2024, 06:29 · Bug Reports, Phorge

Sep 4 2024

aklapper merged T15937: Exception when viewing diff while not logged in into T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out.
Sep 4 2024, 07:51 · Bug Reports, Differential

Aug 28 2024

valerio.bozzolan closed T15905: Linter: do not break "ics" files as Resolved by committing rP3e5315181555: Calendar Import: add unit tests to cover participants.
Aug 28 2024, 07:31 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist

Aug 26 2024

valerio.bozzolan added a revision to T15927: Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal: D25809: ArcanistBundleTestCase: fix support of non-English environments.
Aug 26 2024, 14:23 · User-valerio.bozzolan

Aug 24 2024

valerio.bozzolan closed T15612: Missing "Authored on" commit date for Subversion commits as Resolved by committing rPb02615bd5027: Subversion: fix empty "Authored on" date on commit pages.
Aug 24 2024, 13:34 · User-valerio.bozzolan, Diffusion, Bug Reports

Aug 23 2024

aklapper renamed T15612: Missing "Authored on" commit date for Subversion commits from Missing subversion commit information to Missing "Authored on" commit date for Subversion commits.
Aug 23 2024, 18:30 · User-valerio.bozzolan, Diffusion, Bug Reports
valerio.bozzolan renamed T15927: Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal from Fix Arcanist unit test - Diff Parse Exception: Expected '\ No newline at end of file' to Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal.
Aug 23 2024, 13:40 · User-valerio.bozzolan
valerio.bozzolan created T15927: Fix Arcanist unit test ArcanistBundleTestCase->testNonlocalTrailingNewline() on non-English terminal.
Aug 23 2024, 13:38 · User-valerio.bozzolan

Aug 21 2024

valerio.bozzolan moved T15612: Missing "Authored on" commit date for Subversion commits from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Aug 21 2024, 13:33 · User-valerio.bozzolan, Diffusion, Bug Reports
valerio.bozzolan claimed T15612: Missing "Authored on" commit date for Subversion commits.
Aug 21 2024, 13:33 · User-valerio.bozzolan, Diffusion, Bug Reports
valerio.bozzolan added a revision to T15612: Missing "Authored on" commit date for Subversion commits: D25796: Subversion: fix empty "Authored on" date on commit pages.
Aug 21 2024, 13:33 · User-valerio.bozzolan, Diffusion, Bug Reports
valerio.bozzolan edited projects for T15612: Missing "Authored on" commit date for Subversion commits, added: Diffusion; removed Phorge.

This is becoming quite frustrating in my workplace in Torino. Let's start immersion mode.

Aug 21 2024, 13:29 · User-valerio.bozzolan, Diffusion, Bug Reports

Aug 17 2024

valerio.bozzolan added a project to T15918: When destroying a Project, all Sub-Projects are "You Shall Not Pass: Restricted Project": User-valerio.bozzolan.

The solution was to take direct children project and call $child->setParentProjectPHID($my_parent_phid).

Aug 17 2024, 13:49 · User-valerio.bozzolan, Bug Reports, Projects
valerio.bozzolan added a project to T15913: When deleting a Project, its direct Milestones remain orphan (should instead be dropped): User-valerio.bozzolan.

Finally in my Phorge I can kill these milestones \o/

Aug 17 2024, 13:45 · User-valerio.bozzolan, Bug Reports, Projects
valerio.bozzolan added a revision to T15918: When destroying a Project, all Sub-Projects are "You Shall Not Pass: Restricted Project": D25772: Projects: improve quality of destroy workflow.
Aug 17 2024, 13:29 · User-valerio.bozzolan, Bug Reports, Projects

Aug 16 2024

valerio.bozzolan created T15918: When destroying a Project, all Sub-Projects are "You Shall Not Pass: Restricted Project".
Aug 16 2024, 13:24 · User-valerio.bozzolan, Bug Reports, Projects

Aug 12 2024

valerio.bozzolan added a revision to T15913: When deleting a Project, its direct Milestones remain orphan (should instead be dropped): D25772: Projects: improve quality of destroy workflow.
Aug 12 2024, 21:21 · User-valerio.bozzolan, Bug Reports, Projects
valerio.bozzolan created T15913: When deleting a Project, its direct Milestones remain orphan (should instead be dropped).
Aug 12 2024, 20:54 · User-valerio.bozzolan, Bug Reports, Projects

Aug 11 2024

valerio.bozzolan added a revision to T15905: Linter: do not break "ics" files: D25767: Calendar Import: add unit tests to cover participants.
Aug 11 2024, 14:59 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist

Aug 10 2024

valerio.bozzolan closed T15110: File reference not removed when file is deleted as Resolved by committing rP2b7c0ec92f6c: Destroy file attachments when file is deleted, or object is deleted.
Aug 10 2024, 20:17 · Files, Bug Reports
valerio.bozzolan closed T15896: Explore How-To Permanently Destroy Things in Phorge, a subtask of T15110: File reference not removed when file is deleted, as Resolved.
Aug 10 2024, 20:14 · Files, Bug Reports

Aug 9 2024

valerio.bozzolan added a project to T15905: Linter: do not break "ics" files: User-valerio.bozzolan.
Aug 9 2024, 20:50 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist

Aug 7 2024

valerio.bozzolan added a revision to T15905: Linter: do not break "ics" files: D25766: Arcanist Text Linter: do not break the "ics" special format.
Aug 7 2024, 10:08 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist
valerio.bozzolan triaged T15905: Linter: do not break "ics" files as Normal priority.
Aug 7 2024, 09:58 · User-valerio.bozzolan, Bug Reports, Phorge, Arcanist

Aug 5 2024

aklapper added a comment to T15371: RuntimeException in preg_replace_callback: Text disappears due to Remarkup parsing.

This is an issue in https://we.phorge.it/source/phorge/browse/master/src/infrastructure/markup/rule/PhabricatorObjectRemarkupRule.php . In getObjectEmbedPattern(), preg_quote($prefix) returns \# and the method finally returns (\B{\#([^.\s?!,:;{}#\(\)"'\*/~]+(?:[^\s?!,:;{}#\(\)"'\*/~]*[^.\s?!,:;{}#\(\)"'\*/~]+)*)([,\s](?:[^}\\]|\\.)*)?}\B)u.
Within apply($text), $text becomes null after that first preg_replace_callback, so the second call barks.

Aug 5 2024, 12:44 · Bug Reports, Remarkup, Affects-Wikimedia

Aug 2 2024

valerio.bozzolan added a comment to T15110: File reference not removed when file is deleted.

Yep. In all cases it's at least a full-table-scan on file_attachment. Probably a bit more RAM-efficient with the NOT EXISTS thing since it does not need to have all file PHIDs in memory.

Aug 2 2024, 09:59 · Files, Bug Reports

Jul 30 2024

aklapper closed T15378: PhabricatorApplicationTransactionStructureException trying to mute File notifications: "Attempting to apply a transaction which has not been constructed correctly" as Resolved by committing rPe2919211f3c2: Avoid PhabricatorApplicationTransactionStructureException on editors not….
Jul 30 2024, 08:52 · Bug Reports
aklapper closed T15827: Possible to award a badge without selecting a recipient as Resolved by committing rP8793bdbaa87c: Disallow awarding a badge without selecting recipient.
Jul 30 2024, 08:50 · Bug Reports

Jul 24 2024

valerio.bozzolan created T15892: Post-Commit Audit review: authors cannot "Raise Concern".
Jul 24 2024, 09:27 · Discussion Needed, Bug Reports, Diffusion

Jul 23 2024

aklapper added a comment to T15378: PhabricatorApplicationTransactionStructureException trying to mute File notifications: "Attempting to apply a transaction which has not been constructed correctly".

My userbase is stellar in relentlessly clicking every button you provide them :P

Jul 23 2024, 09:34 · Bug Reports
valerio.bozzolan triaged T15378: PhabricatorApplicationTransactionStructureException trying to mute File notifications: "Attempting to apply a transaction which has not been constructed correctly" as Normal priority.

(Wow. I've never clicked on that button in my life, also when working)

Jul 23 2024, 08:27 · Bug Reports
valerio.bozzolan triaged T15827: Possible to award a badge without selecting a recipient as Normal priority.

Thanks :) Interesting weird transaction.

Jul 23 2024, 07:36 · Bug Reports

Jul 19 2024

aklapper added a comment to T15110: File reference not removed when file is deleted.

I'd be worried about DB performance running such a query as our DB has dozens of millions of files... (This is basically SELECT COUNT(*) FROM file_attachment fa WHERE fa.filePHID NOT IN (SELECT f.phid FROM file); in my understanding?)

Jul 19 2024, 15:30 · Files, Bug Reports
valerio.bozzolan added a comment to T15110: File reference not removed when file is deleted.

Unrelated but @aklapper I'm curious about the situation in WMF. If you can maybe report something like this:

Jul 19 2024, 13:18 · Files, Bug Reports

Jul 8 2024

valerio.bozzolan closed T15855: Fix "arc diff" in Subversion for non-English languages as Resolved by committing rARC72e59da8047c: Fix arc diff in Subversion for non-English languages.
Jul 8 2024, 08:06 · Bug Reports, User-valerio.bozzolan, Arcanist

Jul 3 2024

BlankEclair added a comment to T15875: Maniphest: Tasks can be closed as duplicate onto another task multiple times.

I haven't looked at Phorge's internals much yet, but perhaps the user could unmark a task as duplicate, or have the "Close As Duplicate" box be prefilled with the task that closed it and let the user deselect that and choose another one?

Jul 3 2024, 08:33 · Maniphest, Bug Reports
avivey added a comment to T15875: Maniphest: Tasks can be closed as duplicate onto another task multiple times.

Once we remove this, we'll need to handle this edge-case:

  • I've closed a ticket as "duplicate of T1", but I was wrong and want to mark it as "duplicate of T2" instead (and say it's not a dup of T1).
Jul 3 2024, 07:54 · Maniphest, Bug Reports
BlankEclair created T15875: Maniphest: Tasks can be closed as duplicate onto another task multiple times.
Jul 3 2024, 06:56 · Maniphest, Bug Reports

Jul 1 2024

valerio.bozzolan added a project to T15575: Moving a Phriction page does not move its Tags: Phriction.

Partially related to T15822: When a phriction page is moved, history should follow the page move

Jul 1 2024, 16:55 · Phriction, User-valerio.bozzolan, Bug Reports
valerio.bozzolan updated the task description for T15855: Fix "arc diff" in Subversion for non-English languages.
Jul 1 2024, 13:15 · Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan closed T15872: Understand how to defuse localization in GNU Gettext, a subtask of T15855: Fix "arc diff" in Subversion for non-English languages, as Resolved.
Jul 1 2024, 13:09 · Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan closed T15872: Understand how to defuse localization in GNU Gettext as Resolved.

OK. Well, thaanks \o/

Jul 1 2024, 13:09 · Bug Reports, User-valerio.bozzolan, Arcanist
valerio.bozzolan updated the task description for T15872: Understand how to defuse localization in GNU Gettext.
Jul 1 2024, 12:56 · Bug Reports, User-valerio.bozzolan, Arcanist