Things that are obviously bugs
Details
Today
(I cannot reproduce anymore, now I see the very - ugly - native desktop notification of my environment lol; but it's difficult to note since I've configured my computer to disappear after 0.5 seconds - also maybe a common problem I guess)
The "Grant permission" button works for me on Chrome/Windows.
Yesterday
You are totally right, I've never seen native browser notifications too. For some reasons I've always confused Phorge's popup with these since they are quite similar in my environment
Is there a possibility that you have a browser extension privacy-focused that automatically denies this permission?
Any error in your browser console?
Clicking on Send Test Notification, a notification shows up on the bottom of the screen, but this is totally unrelated to browser notifications.
After clicking on the Grant Permission button:
Can you share a screenshot after you click on that button?
Mon, Dec 16
Another related bug is that also referenced/attached files are kept on the old page. Maybe different bug report under same umbrella.
Let's promote to bug :D
The current workaround I'm proposing is just:
Wed, Dec 11
Thu, Dec 5
Tue, Dec 3
Mon, Dec 2
Sun, Dec 1
Tue, Nov 26
Sun, Nov 24
Sat, Nov 23
Digging deeper, the problem is specific to ProjectRemarkupRule::getObjectIDPattern. That returns:
Step 2: Remove irrelevant character class exclusions:
Disentangling that monster regex, step 1:
Indeed https://devina.io/redos-checker says the aformentioned regex is exponential time worst-case
I monkeypatched the code to print preg_last_error when the problematic preg_match returns null. The error is "Backtrack limit exhausted".
Fri, Nov 22
Thanks :)
Nov 16 2024
Nov 15 2024
Yep. I'm up-to-date with master as of filing the issue^^.
This textbox isn't a Remarkup field (it's actually a ConpherenceDurableColumnView, which doesn't even have a metadata field in the first place)
In normal Conpherence views, the "Upload file" button works just fine. (except as mentioned in Z1, where reloading the page erases the metadata field)
Thanks. Can you reproduce with "Upload file" button too? If yes, maybe sub-task of: T15106: "Upload file" in remarkup text fields should attach by default
Oct 25 2024
This exception happens once $rule in the loop foreach ($this->getMarkupRules() as $rule) in PhutilRemarkupBlockRule::applyRules($text) becomes ProjectRemarkupRule. That's where it blows up.