PhabricatorFileAttachmentQuery seems to eagerly load the object relation, however since the DestructionEngine extensions run after the object is already deleted, this fails and nothing is returned in the query. Changed to LiskDAO loadAllWhere, which also seems to use less queries in general (due to not eagerly loading), so changed the query in PhabricatorFile as well. Changed mpull to foreach per suggestion.

Commit fixup/update author details

Organised attachment deletion from the file side into the File object and deletion from the object side into the destruction engine extension. Also updated the SQL patch date in the file name.

In D25129#4083, @aklapper wrote:

Thanks for accepting. As I have been puzzled by arc for many years now, is there a way to merge via the web UI? arc land D25129 on a shell tells me that Branch "D25129" does not exist in the local working copy, likely because I've reset stuff here.

There is no way to merge from the web UI.

(Ignored unrelated build failures, see fix: D25133)

Rebased and applied suggested changes

In D25052#4102, @Dylsss wrote:

I reverted to a previous commit (36dba82224de1b64bf571ebae5e944ce8a02e7c2) and still get this error when uploading from the remarkup toolbar upload button. So I don't think it is related to this change.

In D25052#4034, @valerio.bozzolan wrote:

WARNING: After this change, in my JavaScript console I can see this exception: Error: JX.DOM.scry(<yuck>, ...): first argument must be a DOM node. - I do not understand a shit about Javelin so I really don't know what does it mean

In D25067#2470, @valerio.bozzolan wrote:

I'm not sure I can reproduce this issue before this patch.

W32

Use project slug

Rebased on master, ran bin/celerity map to resolve merge conflict.

Yes, you could also use milestones and tag the task with that milestone. For example, this is done at Wikimedia's Phabricator: https://phabricator.wikimedia.org/project/subprojects/5539/, where milestones are used to track changes associated with a task.

In addition to the above, it seems that commit d017f3f21021 is what broke this. And adjustTransactionValues is what changes the xaction from

Array
(
    [+] => Array
        (
            [0] => PHID-PIMG-m5pqg3eec46uvzw6uynm
        )

In D25052#1750, @avivey wrote:

I'd expect some PHP code to actually attach the files from attachedFilePHIDs to the relevant object, but I don't see it in this diff. Is that already happening somehow?

It's done here: https://we.phorge.it/source/phorge/browse/master/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php;5aa159a83013fca3a72f5c6d2c493c117fbbf83b$2296

Auto file attachments are also not working when editing a comment.

Differentiate between metadata of different text areas using node ID. e.g., new comment text areas and text areas in the edit comment dialog.

ran celerity map again

arc liberate

Linting

https://phabricator.wikimedia.org/D1203 is my fix for this issue at Wikimedia's install.