Before and after Chromium Lighthouse a11y result comparison of some Phorge pages for patches I'm going to attach.
(Goodhart's Law applies, as with any misguiding incentives.)

Sun, Jun 1, 11:02 · Accessibility

valerio.bozzolan accepted D26042: More Search-related PhpDoc additions.

More docs yuum

Sun, Jun 1, 10:04

aklapper requested review of D26043: Correct Conduit project.search color result for milestones.

Sun, Jun 1, 09:47

aklapper added a revision to T16088: Conduit's project.search returns wrong color for milestones: D26043: Correct Conduit project.search color result for milestones.

Sun, Jun 1, 09:47

aklapper created T16088: Conduit's project.search returns wrong color for milestones.

Sun, Jun 1, 09:42

aklapper edited the content of Next Up.

Sun, Jun 1, 08:12

aklapper closed T16081: Warn users that adding a second Multi-Factor Auth will require both instead of choosing one of them as Resolved by committing rPa7f94af9cf5b: Explain consequences when adding second Multi-Factor Auth.

Sun, Jun 1, 08:10

aklapper closed D26028: Explain consequences when adding second Multi-Factor Auth.

Sun, Jun 1, 08:10

aklapper committed rPa7f94af9cf5b: Explain consequences when adding second Multi-Factor Auth.

Sun, Jun 1, 08:10

Sat, May 31

aklapper added a comment to D26035: Remove unused functions in PhabricatorFulltextToken.

Also nothing seems to use these functions?:

[acko@fedora phorge]$ grep -r compileLiteralQuery .
./phorge/src/applications/search/compiler/__tests__/PhutilSearchQueryCompilerTestCase.php:          $literal_query = $compiler->compileLiteralQuery($tokens);
./phorge/src/applications/search/compiler/PhutilSearchQueryCompiler.php:  public function compileLiteralQuery(array $tokens) {
[acko@fedora phorge]$ grep -r compileStemmedQuery .
./phorge/src/applications/search/compiler/__tests__/PhutilSearchQueryCompilerTestCase.php:          $stemmed_query = $compiler->compileStemmedQuery($tokens);
./phorge/src/applications/search/compiler/PhutilSearchQueryCompiler.php:  public function compileStemmedQuery(array $tokens) {

Sat, May 31, 22:39

aklapper renamed T16072: Accessibility improvements (June 2025) from Accessibility improvements (May 2025) to Accessibility improvements (June 2025).

Sat, May 31, 21:58 · Accessibility

aklapper edited the content of Next Up.

Sat, May 31, 21:57

aklapper edited the content of Next Up.

Sat, May 31, 21:55

aklapper edited the content of Next Up.

Sat, May 31, 21:52

aklapper closed D26031: Allow using PCRE's just-in-time compilation.

Sat, May 31, 21:52

aklapper closed T16084: Stop disabling pcre.jit by default as Resolved by committing rARCc739de1ef2f5: Allow using PCRE's just-in-time compilation.

Sat, May 31, 21:52

aklapper committed rARCc739de1ef2f5: Allow using PCRE's just-in-time compilation.

Sat, May 31, 21:52

aklapper requested review of D26042: More Search-related PhpDoc additions.

Sat, May 31, 21:33

aklapper accepted D26039: LiskDAO::getConfiguration return typing.

Nice find. Applying this patch removes about 250 errors in phpstan output here.

Sat, May 31, 13:33

valerio.bozzolan added a comment to D26040: Add missing ArcanistWorkflow::runWorkflow method.

In D26040#27816, @aklapper wrote:

Keeping it protected will throw Protected method PhageExecWorkflow::runWorkflow() overriding public method ArcanistWorkflow::runWorkflow() should also be public.

Sat, May 31, 13:02

aklapper accepted D26040: Add missing ArcanistWorkflow::runWorkflow method.

Running phpstan analyse, before this patch I get Call to an undefined method ArcanistWorkflow::runWorkflow(), after this patch I get Method ArcanistWorkflow::runWorkflow() invoked with 1 parameter, 0 required, both in src/workflow/ArcanistWorkflow.php:227. That looks like an improvement indeed.

Sat, May 31, 11:56

valerio.bozzolan added a comment to D26040: Add missing ArcanistWorkflow::runWorkflow method.

(This seems nice) Small question: Does it still work for you keeping the method as protected instead of public?

Sat, May 31, 11:19

Fri, May 30

amybones requested review of D26041: Fix ArcanistWorkflow::shouldRequireCleanUntrackedFiles.

Fri, May 30, 23:48

amybones updated the diff for D26040: Add missing ArcanistWorkflow::runWorkflow method.

Get rid of coverage errors :)

Fri, May 30, 23:40

amybones requested review of D26040: Add missing ArcanistWorkflow::runWorkflow method.

Fri, May 30, 23:37

amybones requested review of D26039: LiskDAO::getConfiguration return typing.

Fri, May 30, 23:11

aklapper updated aklapper.

Fri, May 30, 22:05

aklapper added a comment to D26037: Add phpDoc to PhabricatorCursorPagedPolicyAwareQuery.

Yes to the idea however a related elephant in the room (IMHO) are those non-standard types like list or map or wild being replaced, no clue if that has any effects on...something™ (Diviner docs? Code?) as I haven't managed to understand the consequences of code in https://we.phorge.it/source/arcanist/browse/master/src/parser/PhutilTypeSpec.php yet. (Technically speaking map and list seem to be just arrays, indeed.)

Fri, May 30, 22:01

amybones requested review of D26038: phpDoc PhabricatorApplicationQuery.

Fri, May 30, 21:55

aklapper updated the summary of D26037: Add phpDoc to PhabricatorCursorPagedPolicyAwareQuery.

Fri, May 30, 21:55

aklapper closed D26034: Fix PHP 8.1 "strlen(null)" exception in Client ID handling of PhabricatorOAuthServerTokenController.

Fri, May 30, 21:12

aklapper committed rP0c34164c8bf9: Fix PHP 8.1 "strlen(null)" exception in Client ID handling of….

Fri, May 30, 21:12

amybones added a comment to D26027: Profile picture destroy: implement Before-Destruction engine to restore the builtin image.

This isn't important, it just seems like this is a nice in-context place to leave this information :)

Fri, May 30, 20:45

amybones updated the diff for D26037: Add phpDoc to PhabricatorCursorPagedPolicyAwareQuery.

Use R[] because the keys may not be sequential.

Fri, May 30, 20:31

amybones added a comment to D26037: Add phpDoc to PhabricatorCursorPagedPolicyAwareQuery.

Hmm.. clearly I need to set xdebug.mode correctly, but I'm not sure why it wasn't. It's been fine before.

Fri, May 30, 20:20

amybones requested review of D26037: Add phpDoc to PhabricatorCursorPagedPolicyAwareQuery.

Fri, May 30, 20:06

jasonrumney added a comment to Q182: Deprecation warnings with PHP 8.3.

Correct, my instance is running the current stable branch HEAD, which is 2024.35. I did notice that the last 5 were already fixed, and I searched for existing issues, but missed T15824 sorry.

Fri, May 30, 00:37 · Phorge

Thu, May 29

aklapper requested review of D26036: Fix PHP 8.1 "preg_replace(null)" exception in PhabricatorEditorURIEngine.php.

Thu, May 29, 21:33

aklapper added a revision to T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set: D26036: Fix PHP 8.1 "preg_replace(null)" exception in PhabricatorEditorURIEngine.php.

Thu, May 29, 21:33 · PHP 8 support, Deprecation Notice

aklapper added a comment to T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set.

Looking at src/applications/repository/storage/PhabricatorRepository.php I see stuff like $has_shortname = ($this->getRepositorySlug() !== null); so it seems that a repository "slug" is what the UI calls a "short name". That's also seconded by code in DiffusionRepositoryEditEngine.

Thu, May 29, 21:22 · PHP 8 support, Deprecation Notice

aklapper added a comment to T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set.

Copying from Q182:

PhabricatorEditorURIEngine.php:283, occurrences: 4
preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated
arcanist(head=stable, ref.master=989690868513, ref.stable=05abd055019c), libphremoteuser(head=clarion, ref.master=944307decd9c, ref.clarion=d0da6c048bd5), phorge(head=stable, custom=4), translations(head=wmf/stable, ref.wmf/stable=76bb64361cec)
#0 preg_replace(string, string, NULL) called at [<phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php:283]
#1 PhabricatorEditorURIEngine::escapeToken(NULL) called at [<phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php:144]
#2 PhabricatorEditorURIEngine::newURITokensForRepository() called at [<phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php:128]
#3 PhabricatorEditorURIEngine::getURITokensForRepository(string) called at [<phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php:84]
#4 PhabricatorEditorURIEngine::getURITokensForPath(string) called at [<phorge>/src/applications/differential/view/DifferentialChangesetDetailView.php:371]
#5 DifferentialChangesetDetailView::getEditorURITemplate() called at [<phorge>/src/applications/differential/view/DifferentialChangesetDetailView.php:272]
#6 DifferentialChangesetDetailView::render() called at [<phorge>/src/applications/differential/view/DifferentialChangesetListView.php:240]
#7 DifferentialChangesetListView::render() called at [<phorge>/src/view/AphrontView.php:222]
#8 AphrontView::producePhutilSafeHTML() called at [<phorge>/src/infrastructure/markup/render.php:115]
#9 phutil_escape_html(DifferentialChangesetListView) called at [<phorge>/src/infrastructure/markup/render.php:139]
#10 phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:139]
#11 phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:97]
#12 phutil_tag(string, array, array) called at [<phorge>/src/view/phui/PHUITwoColumnView.php:236]
#13 PHUITwoColumnView::buildFooter() called at [<phorge>/src/view/phui/PHUITwoColumnView.php:123]
#14 PHUITwoColumnView::getTagContent() called at [<phorge>/src/view/AphrontTagView.php:161]
#15 AphrontTagView::render() called at [<phorge>/src/view/AphrontView.php:222]
#16 AphrontView::producePhutilSafeHTML() called at [<phorge>/src/infrastructure/markup/render.php:115]
#17 phutil_escape_html(PHUITwoColumnView) called at [<phorge>/src/infrastructure/markup/render.php:139]
#18 phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:139]
#19 phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:97]
#20 phutil_tag(string, array, array) called at [<phorge>/src/view/formation/PHUIFormationContentView.php:13]
#21 PHUIFormationContentView::render() called at [<phorge>/src/view/AphrontView.php:222]
#22 AphrontView::producePhutilSafeHTML() called at [<phorge>/src/infrastructure/markup/render.php:115]
#23 phutil_escape_html(PHUIFormationContentView) called at [<phorge>/src/infrastructure/markup/render.php:139]
#24 phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:97]
#25 phutil_tag(string, array, array) called at [<phorge>/src/view/formation/PHUIFormationView.php:58]
#26 PHUIFormationView::render() called at [<phorge>/src/view/AphrontView.php:222]
#27 AphrontView::producePhutilSafeHTML() called at [<phorge>/src/infrastructure/markup/render.php:115]
#28 phutil_escape_html(PHUIFormationView) called at [<phorge>/src/infrastructure/markup/render.php:171]
#29 phutil_implode_html(string, array) called at [<phorge>/src/view/page/PhabricatorBarePageView.php:58]
#30 PhabricatorBarePageView::willRenderPage() called at [<phorge>/src/view/page/PhabricatorStandardPageView.php:217]
#31 PhabricatorStandardPageView::willRenderPage() called at [<phorge>/src/view/page/AphrontPageView.php:46]
#32 AphrontPageView::render() called at [<phorge>/src/view/page/PhabricatorStandardPageView.php:918]
#33 PhabricatorStandardPageView::produceAphrontResponse() called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:724]
#34 AphrontApplicationConfiguration::produceResponse(AphrontRequest, PhabricatorStandardPageView) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:299]
#35 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:203]
#36 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35]

Thu, May 29, 20:31 · PHP 8 support, Deprecation Notice

aklapper added a comment to D26034: Fix PHP 8.1 "strlen(null)" exception in Client ID handling of PhabricatorOAuthServerTokenController.

Thanks! Oh true I was forget the default fallback option... ah well I guess not a huge difference performance wise plus null feels cleaner to me :)

Thu, May 29, 17:44

valerio.bozzolan accepted D26034: Fix PHP 8.1 "strlen(null)" exception in Client ID handling of PhabricatorOAuthServerTokenController.

ooooor this, feel free to do whatever bro

Thu, May 29, 14:04

valerio.bozzolan added a project to T16079: Allow extensions to define "Before Destruction" engines: Discussion Needed.

The patch is already approved but maybe it's nice to bring more attention to extension developers

Thu, May 29, 13:51 · Discussion Needed, Extension Development, Feature Requests, User-valerio.bozzolan

aklapper added a comment to D26035: Remove unused functions in PhabricatorFulltextToken.

I'd love to have Phorge skip common words and short words though.
So maybe keeping these functions could even make sense so future improvements could call them?

Thu, May 29, 13:15

aklapper requested review of D26035: Remove unused functions in PhabricatorFulltextToken.

Thu, May 29, 13:07

aklapper requested review of D26034: Fix PHP 8.1 "strlen(null)" exception in Client ID handling of PhabricatorOAuthServerTokenController.

Thu, May 29, 10:08

aklapper added a comment to Q182: Deprecation warnings with PHP 8.3.

Hi, thanks a lot for sharing this! I assume you are running 2024.35 and not yet 2025.18.
You shared seven issues above.