Page MenuHomePhorge
Differential D25983

CSS: Add "clip-path" to deprecated "clip" property
ClosedPublic
Actions

Authored by aklapper on Thu, May 1, 12:27.

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T16046: CSS: Add "clip-path" as progressive enhancement for deprecated "clip" property
Commits
rP261fdca137e5: CSS: Add "clip-path" to deprecated "clip" property
Summary

Add "clip-path" as progressive enhancement for deprecated "clip" property to be more future-proof.
See the Phorge task for details.

Closes T16046

Test Plan

Probably browse Phorge pages which use FontAwesome icons, plus test with a screenreader software? (I didn't.)

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper created this revision.Thu, May 1, 12:27
Owners added a reviewer: O1: Blessed Committers.Thu, May 1, 12:27
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptThu, May 1, 12:27
aklapper requested review of this revision.Thu, May 1, 12:27
Harbormaster completed remote builds in B1910: Diff 2954.Thu, May 1, 12:27
aklapper added a comment.Thu, May 1, 12:28

Testing welcome.
Input from CSS folks welcome.

valerio.bozzolan accepted this revision.Thu, May 1, 19:55

I've done my best to try to understand what we are talking about, so, I've created a nonsense X grid made in this way to catch changes:

oldnew
newold

https://jsfiddle.net/tszjnqbr/

And I'm not whatsoever able to understand the difference, so...

sgtm

This revision is now accepted and ready to land.Thu, May 1, 19:55
Closed by commit rP261fdca137e5: CSS: Add "clip-path" to deprecated "clip" property. · Explain WhySat, May 3, 21:59
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rP261fdca137e5: CSS: Add "clip-path" to deprecated "clip" property.
aklapper mentioned this in Next Up.Sat, May 3, 21:59

Revision Contents
Changeset List

PathSizePackages
resources/
celerity/
O1: Blessed Committers
webroot/
rsrc/
css/
core/
4 linesO1: Blessed Committers
font/
4 linesO1: Blessed Committers

Diff 2980

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/core/core.css

Loading...
View Options

webroot/rsrc/css/font/font-awesome.css

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0