Page MenuHomePhorge
Create Task
Maniphest T16005

Remove unused table code in ManiphestReportController::renderBurn()
Open, Needs TriagePublic
Actions

Description

  1. After making sure that http://phorge.localhost/applications/view/PhabricatorFactApplication/ is installed, go to http://phorge.localhost/maniphest/report/burn/ on a larger Phorge Maniphest instance and wonder about its performance.
  2. Look at the code and wonder about things.
  3. Realize that ManiphestReportController does a lot of calculation to fill rows via $table = new AphrontTableView($rows);, then defines $panel = new PHUIObjectBoxView() and does $panel->setTable($table) to render that table never to be seen anywhere because a bit later $panel = id(new PhabricatorProjectBurndownChartEngine()) overwrites that table and all its data anyway. This re-definition of $panel was introduced in rP5c1b91ab457db9f3db10d8cc5e07831512645ebb.

Revisions and Commits

rP Phorge
Needs ReviewD25902 Remove unused code in ManiphestReportController::renderBurn()

Related Objects

Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0