Sorry if this unrelated, but this is an interesting partially-related commit:
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
May 6 2023
May 6 2023
Make sure Phorge is not hit by legal action because of your contribution
valerio.bozzolan updated the diff for D25157: Fix regression in PHUIObjectItemView.php:662: allow PhutilURI and other stringlike.
make my friend avivey more happy
avivey added inline comments to D25157: Fix regression in PHUIObjectItemView.php:662: allow PhutilURI and other stringlike.
valerio.bozzolan added inline comments to D25157: Fix regression in PHUIObjectItemView.php:662: allow PhutilURI and other stringlike.
avivey added inline comments to D25157: Fix regression in PHUIObjectItemView.php:662: allow PhutilURI and other stringlike.
valerio.bozzolan added inline comments to D25157: Fix regression in PHUIObjectItemView.php:662: allow PhutilURI and other stringlike.
avivey added inline comments to D25157: Fix regression in PHUIObjectItemView.php:662: allow PhutilURI and other stringlike.
aklapper requested review of D25196: Fix PHP 8.1 "strlen(null)" exception which blocks creating a blog post.
aklapper requested review of D25195: Fix PHP 8.1 "strlen(null)" exception which blocks blog rendering.
aklapper requested review of D25194: Fix PHP 8.1 "strlen(null)" exception which blocks blog creation.
valerio.bozzolan added inline comments to D25157: Fix regression in PHUIObjectItemView.php:662: allow PhutilURI and other stringlike.
Gopher Burrow/R4 is the first project in Phactory!
I created Gopher Burrow and (unnamed) R4.
Cool. Let's start with rRustConduit, because I think there's a bad joke in there about rusted pipes (12 seconds of google did not find a special name for it).
avivey moved T15290: vscode extension for working on phorge codebase from Backlog to Pending Projects on the Phactory: Community Projects board.
avivey moved T15351: Create repository for Conduit API client in Rust from Backlog to Pending Projects on the Phactory: Community Projects board.
By not signing a CLA, you'd have to explicitly set a license for each contribution you make - i.e., every single revision would have to include an explicit license, or it could not be incorporated into the main code-base.
This is technically handled by item 5 in our license, but it's reasonable to assume nobody ever reads that.
aklapper closed T15341: PHP 8.1 "strlen(null)" exceptions block rendering page of a File, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
aklapper closed T15340: PHP 8.1 "strlen(null)" exception blocks Space creation, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
aklapper closed T15339: PHP 8.1 "strlen(null)" exceptions block adding Dashboard to Project Menu, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 5 2023
May 5 2023
valerio.bozzolan accepted D25187: Fix PHP 8.1 "strlen(null)" exception which blocks rendering a File page when Alt Text was altered.
Thank you for this patch, again (!!!!!!)
valerio.bozzolan accepted D25186: Fix PHP 8.1 "strlen(null)" exceptions which block rendering page of a File.
Thanks for this patch, again (!!!)
In T15121#3880, @valerio.bozzolan wrote:I honestly do not want to allow my contributions to be re-licensed, since this usually means that the repository owner wants to re-license that work under a proprietary license when needed. I don't accept that. Normal volunteers do not accept that. This is probably not what we want.
bfs awarded D25191: Auto-subscription: little less verbose a Cup of Joe token.
Thanks for this patch, again
valerio.bozzolan accepted D25184: Fix PHP 8.1 "strlen(null)" exceptions which block adding Dashboard to Project Menu.
Tested this patch locally, no nuclear implosions, I was able to attach a Dashboard to a Project.
valerio.bozzolan awarded T15351: Create repository for Conduit API client in Rust a Yellow Medal token.
aklapper updated the task description for T15352: Remove outdated PHP version suffixes in package names on "Missing Required Extensions" and replace yum with dnf.
avivey added a project to T15351: Create repository for Conduit API client in Rust: Phactory: Community Projects.
valerio.bozzolan added a comment to D25157: Fix regression in PHUIObjectItemView.php:662: allow PhutilURI and other stringlike.
I love this community even if I think @avivey is planning to kill me :D
valerio.bozzolan added a comment to D25182: Fix PHP 8.1 "strlen(null)" and "preg_match()" exceptions which block repository creation.
In D25182#5597, @aklapper wrote:$content_type and $request_type ... are null. It is unclear to me why the HTTP Header sent by my web browser is not read.
valerio.bozzolan accepted D25182: Fix PHP 8.1 "strlen(null)" and "preg_match()" exceptions which block repository creation.
Also here I will start approving as behalf of myself, but not as O1 since they would very probably share my very same tips in the "Not Done" comments.
aklapper closed T15345: PHP 8.1 "strlen(null)" exception blocks editing a Dashboard Tab Panel, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
aklapper closed T15344: PHP 8.1 "strlen(null)" exception when DarkConsole is enabled, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
valerio.bozzolan accepted D25179: Fix PHP 8.1 null parameter exceptions which block rendering the "Browse Projects" overlay dialog.
Thanks for this patch
valerio.bozzolan updated the diff for D25188: Fix PHP 8.1 "strlen(null)" exception when DarkConsole is enabled.
hoping to be somehow useful, add a small inline comment
Thanks for this patch, again
valerio.bozzolan accepted D25189: Fix PHP 8.1 "strlen(null)" exception which blocks editing a Dashboard Tab Panel.
Thanks for this patch
valerio.bozzolan updated the diff for D25190: Fix PHP 8.1 "strlen(null)" exception which blocks creating personal and global Herald rules.
hoping to be useful, add a small PHPDoc to help future reviews
valerio.bozzolan accepted D25190: Fix PHP 8.1 "strlen(null)" exception which blocks creating personal and global Herald rules.
I tested this locally intensively creating a very weird entropy of possible Herald conditions. I also hacked my database manually, with dangerous fuzzy tests in the phabricator_herald.herald_condition database table, kind of:
May 4 2023
May 4 2023
valerio.bozzolan awarded D25157: Fix regression in PHUIObjectItemView.php:662: allow PhutilURI and other stringlike a Cup of Joe token.
valerio.bozzolan added inline comments to D25192: Ponder Answer Comments: indent textarea as Comments.
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0