In D25031#1902, @Ekubischta wrote:

This revision is nearly impossible to test

See my comments here D25030#1893

Error suppression with "@" is a poor solution to this issue

Mar 26 2023, 14:24 · Phorge

valerio.bozzolan renamed T15199: Introduce PhabricatorEnv::getEnvConfigStr() - that always return a string from Introduce PhabricatorEnv::getEnvConfigString() - that always return a string to Introduce PhabricatorEnv::getEnvConfigStr() - that always return a string.

Mar 26 2023, 14:13 · PHP 8 support, User-valerio.bozzolan

valerio.bozzolan updated the task description for T15199: Introduce PhabricatorEnv::getEnvConfigStr() - that always return a string.

Mar 26 2023, 14:07 · PHP 8 support, User-valerio.bozzolan

valerio.bozzolan updated the task description for T15199: Introduce PhabricatorEnv::getEnvConfigStr() - that always return a string.

Mar 26 2023, 13:48 · PHP 8 support, User-valerio.bozzolan

valerio.bozzolan updated the task description for T15199: Introduce PhabricatorEnv::getEnvConfigStr() - that always return a string.

Mar 26 2023, 13:27 · PHP 8 support, User-valerio.bozzolan

valerio.bozzolan updated the task description for T15199: Introduce PhabricatorEnv::getEnvConfigStr() - that always return a string.

Mar 26 2023, 13:20 · PHP 8 support, User-valerio.bozzolan

valerio.bozzolan triaged T15199: Introduce PhabricatorEnv::getEnvConfigStr() - that always return a string as High priority.

Mar 26 2023, 13:16 · PHP 8 support, User-valerio.bozzolan

valerio.bozzolan added a parent task for T15145: Evaluate PHP Rector to quick refactor Phorge to support PHP 8.1 / 8.2 or do other things: T15198: PHP 8.2 deprecations fix strategies.

Mar 26 2023, 12:31 · PHP 8 support, User-valerio.bozzolan

valerio.bozzolan removed a parent task for T15145: Evaluate PHP Rector to quick refactor Phorge to support PHP 8.1 / 8.2 or do other things: T15064: Make Phorge compatible with PHP 8.1/8.2/8.3.

Mar 26 2023, 12:30 · PHP 8 support, User-valerio.bozzolan

valerio.bozzolan edited subtasks for T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, added: T15198: PHP 8.2 deprecations fix strategies; removed: T15145: Evaluate PHP Rector to quick refactor Phorge to support PHP 8.1 / 8.2 or do other things.

Mar 26 2023, 12:30 · PHP 8 support

valerio.bozzolan added a parent task for T15196: PHP 8.2: using ${var} in strings is deprecated: T15198: PHP 8.2 deprecations fix strategies.

Mar 26 2023, 12:29 · PHP 8 support, User-valerio.bozzolan

valerio.bozzolan renamed T15196: PHP 8.2: using ${var} in strings is deprecated from Using ${var} in strings is deprecated, use {$var} instead to PHP 8.2: using ${var} in strings is deprecated.

Mar 26 2023, 12:29 · PHP 8 support, User-valerio.bozzolan

valerio.bozzolan triaged T15196: PHP 8.2: using ${var} in strings is deprecated as High priority.

Mar 26 2023, 11:53 · PHP 8 support, User-valerio.bozzolan

valerio.bozzolan added a task to D25031: Fix most PHP 8.1 and 8.2 issues: T15190: PHP 8.1: strlen() and other scalar-only functions do not accept NULL anymore - understand fix strategies.

Mar 26 2023, 10:40 · Phorge

valerio.bozzolan added a comment to T15041: Starmap.

@Cigaryno I noticed this topic. I would say: be bold and just share it directly in Starmap marking it as stub (there is a button to do that)

Mar 26 2023, 10:34 · Phorge

Mar 25 2023

Cigaryno edited the content of Welcome.

Mar 25 2023, 17:27 · Phorge

Mar 24 2023

valerio.bozzolan removed a parent task for T15145: Evaluate PHP Rector to quick refactor Phorge to support PHP 8.1 / 8.2 or do other things: T15188: arc lint: "Function utf8_decode() is deprecated" in PHP 8.2.

Mar 24 2023, 15:49 · PHP 8 support, User-valerio.bozzolan

valerio.bozzolan added a parent task for T15145: Evaluate PHP Rector to quick refactor Phorge to support PHP 8.1 / 8.2 or do other things: T15188: arc lint: "Function utf8_decode() is deprecated" in PHP 8.2.

Mar 24 2023, 13:44 · PHP 8 support, User-valerio.bozzolan

Mar 23 2023

valerio.bozzolan lowered the priority of T15065: Allow to do not forbid "open_basedir" from Low to Wishlist.

Mar 23 2023, 12:59 · User-valerio.bozzolan

Mar 15 2023

valerio.bozzolan triaged T15064: Make Phorge compatible with PHP 8.1/8.2/8.3 as High priority.

Mar 15 2023, 08:24 · PHP 8 support

valerio.bozzolan renamed T15145: Evaluate PHP Rector to quick refactor Phorge to support PHP 8.1 / 8.2 or do other things from Evaluate PHP Rector to quick refactor Phorge to support PHP 8.1 or do other things to Evaluate PHP Rector to quick refactor Phorge to support PHP 8.1 / 8.2 or do other things.

Mar 15 2023, 07:36 · PHP 8 support, User-valerio.bozzolan

valerio.bozzolan added projects to T15064: Make Phorge compatible with PHP 8.1/8.2/8.3: PHP 8.1 support (deprecated), PHP 8.2 support.

Mar 15 2023, 07:36 · PHP 8 support

Mar 11 2023

valerio.bozzolan added a comment to T15121: Contributor Agreement.

I agree that an agreement could be useful but I don't think that the author should ever allow to re-license its work. I honestly do not want to allow my contributions to be re-licensed, since this usually means that the repository owner wants to re-license that work under a proprietary license when needed. I don't accept that. Normal volunteers do not accept that. This is probably not what we want.

Mar 11 2023, 22:46 · Phorge

valerio.bozzolan closed T15145: Evaluate PHP Rector to quick refactor Phorge to support PHP 8.1 / 8.2 or do other things, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.

Mar 11 2023, 22:39 · PHP 8 support

valerio.bozzolan closed T15145: Evaluate PHP Rector to quick refactor Phorge to support PHP 8.1 / 8.2 or do other things as Resolved.

I just want to mark this as resolved since Rector.php is quite nice and simple and we can surely use this tool to do nice things, even without adding it in our Composer but just locally, when we need it.

Mar 11 2023, 22:39 · PHP 8 support, User-valerio.bozzolan