Page MenuHomePhorge

PHP 8.2: fixes for deprecated use of ${var} in strings
ClosedPublic

Authored by valerio.bozzolan on Mar 26 2023, 14:42.
Tags
None
Referenced Files
F3970288: D25098.1746526814.diff
Mon, May 5, 10:20
F3968831: D25098.1746521520.diff
Mon, May 5, 08:52
F3968830: D25098.1746521484.diff
Mon, May 5, 08:51
F3968829: D25098.1746521447.diff
Mon, May 5, 08:50
F3945704: D25098.1746445293.diff
Sun, May 4, 11:41
F3712655: D25098.1745690389.diff
Fri, Apr 25, 17:59
F3695573: D25098.1745592151.diff
Thu, Apr 24, 14:42
F3665040: D25098.1745464585.diff
Wed, Apr 23, 03:16
Tokens
"Like" token, awarded by valerio.bozzolan.

Details

Summary

Note that PHP 8.2 implemented this deprecation:

Using ${var} in strings is deprecated, use {$var} instead

This change fixes some known cases.

Ref T15196

Test Plan
  • I checked with my big eyes that everything is as it should be

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey subscribed.

I have a feeling both of these can be blamed back to me...

This revision is now accepted and ready to land.Mar 26 2023, 18:49

Thanks @avivey honestly it was interesting and deeply connected to a scary PHP internal travel: if I understand correctly, "id" is considered a constant and expanded as the "id" string for backward compatibility reasons. Then, ${} expands that.