Page MenuHomePhorge

PHP 8.2: fixes for deprecated use of ${var} in strings
ClosedPublic

Authored by valerio.bozzolan on Mar 26 2023, 14:42.
Tags
None
Referenced Files
F3527300: D25098.1744838955.diff
Tue, Apr 15, 21:29
F3406834: D25098.1744586628.diff
Sat, Apr 12, 23:23
F3400951: D25098.1744562048.diff
Sat, Apr 12, 16:34
F3383064: D25098.1744380425.diff
Thu, Apr 10, 14:07
F3375393: D25098.1744308274.diff
Wed, Apr 9, 18:04
F3367997: D25098.1744204834.diff
Tue, Apr 8, 13:20
F3367887: D25098.1744204030.diff
Tue, Apr 8, 13:07
F3363073: D25098.1744109689.diff
Mon, Apr 7, 10:54
Tokens
"Like" token, awarded by valerio.bozzolan.

Details

Summary

Note that PHP 8.2 implemented this deprecation:

Using ${var} in strings is deprecated, use {$var} instead

This change fixes some known cases.

Ref T15196

Test Plan
  • I checked with my big eyes that everything is as it should be

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey subscribed.

I have a feeling both of these can be blamed back to me...

This revision is now accepted and ready to land.Mar 26 2023, 18:49

Thanks @avivey honestly it was interesting and deeply connected to a scary PHP internal travel: if I understand correctly, "id" is considered a constant and expanded as the "id" string for backward compatibility reasons. Then, ${} expands that.