Before and after Chromium Lighthouse a11y result comparison of some Phorge pages for patches I'm going to attach.
(Goodhart's Law applies, as with any misguiding incentives.)
Feed Advanced Search
Sun, Jun 1
Sun, Jun 1
aklapper updated the summary of D26047: a11y: Add "title" to <a> tags of PHUIObjectItemView images.
aklapper updated the summary of D26046: a11y: Add aria-label to calendar date picker button.
aklapper updated the summary of D26045: a11y: Set textarea name parameter also as aria-label.
aklapper updated the summary of D26044: a11y: Add aria-label to global search field in top bar.
aklapper requested review of D26054: a11y: Add lang attribute to <html> element.
aklapper requested review of D26053: a11y: Do not mark top bar notifications area as aria-hidden.
aklapper requested review of D26051: a11y: Set aria-label for comment action options dropdown.
aklapper requested review of D26050: a11y: Set project workboard button tooltips as aria-label.
aklapper requested review of D26049: a11y: Add alt text to main picture on profile page.
aklapper requested review of D26048: a11y: Add aria-label to mini badges below user avatars.
aklapper requested review of D26047: a11y: Add "title" to <a> tags of PHUIObjectItemView images.
aklapper requested review of D26046: a11y: Add aria-label to calendar date picker button.
aklapper requested review of D26045: a11y: Set textarea name parameter also as aria-label.
aklapper requested review of D26044: a11y: Add aria-label to global search field in top bar.
aklapper added a comment to T16072: Accessibility improvements (June 2025).
aklapper requested review of D26043: Correct Conduit project.search color result for milestones.
Sat, May 31
Sat, May 31
aklapper added a comment to D26035: Remove unused functions in PhabricatorFulltextToken.
Also nothing seems to use these functions?:
[acko@fedora phorge]$ grep -r compileLiteralQuery .
./phorge/src/applications/search/compiler/__tests__/PhutilSearchQueryCompilerTestCase.php: $literal_query = $compiler->compileLiteralQuery($tokens);
./phorge/src/applications/search/compiler/PhutilSearchQueryCompiler.php: public function compileLiteralQuery(array $tokens) {
[acko@fedora phorge]$ grep -r compileStemmedQuery .
./phorge/src/applications/search/compiler/__tests__/PhutilSearchQueryCompilerTestCase.php: $stemmed_query = $compiler->compileStemmedQuery($tokens);
./phorge/src/applications/search/compiler/PhutilSearchQueryCompiler.php: public function compileStemmedQuery(array $tokens) {aklapper renamed T16072: Accessibility improvements (June 2025) from Accessibility improvements (May 2025) to Accessibility improvements (June 2025).
aklapper closed T16084: Stop disabling pcre.jit by default as Resolved by committing rARCc739de1ef2f5: Allow using PCRE's just-in-time compilation.
aklapper requested review of D26042: More Search-related PhpDoc additions.
Nice find. Applying this patch removes about 250 errors in phpstan output here.
Running phpstan analyse, before this patch I get Call to an undefined method ArcanistWorkflow::runWorkflow(), after this patch I get Method ArcanistWorkflow::runWorkflow() invoked with 1 parameter, 0 required, both in src/workflow/ArcanistWorkflow.php:227. That looks like an improvement indeed.
Fri, May 30
Fri, May 30
aklapper added a comment to D26037: Add phpDoc to PhabricatorCursorPagedPolicyAwareQuery.
Yes to the idea however a related elephant in the room (IMHO) are those non-standard types like list or map or wild being replaced, no clue if that has any effects on...something™ (Diviner docs? Code?) as I haven't managed to understand the consequences of code in https://we.phorge.it/source/arcanist/browse/master/src/parser/PhutilTypeSpec.php yet. (Technically speaking map and list seem to be just arrays, indeed.)
aklapper updated the summary of D26037: Add phpDoc to PhabricatorCursorPagedPolicyAwareQuery.
Thu, May 29
Thu, May 29
aklapper added a comment to T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set.
Looking at src/applications/repository/storage/PhabricatorRepository.php I see stuff like $has_shortname = ($this->getRepositorySlug() !== null); so it seems that a repository "slug" is what the UI calls a "short name". That's also seconded by code in DiffusionRepositoryEditEngine.
aklapper added a comment to T15824: Deprecation notice at PhabricatorEditorURIEngine.php:283 when no RepositorySlug set.
Copying from Q182:
PhabricatorEditorURIEngine.php:283, occurrences: 4 preg_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated arcanist(head=stable, ref.master=989690868513, ref.stable=05abd055019c), libphremoteuser(head=clarion, ref.master=944307decd9c, ref.clarion=d0da6c048bd5), phorge(head=stable, custom=4), translations(head=wmf/stable, ref.wmf/stable=76bb64361cec) #0 preg_replace(string, string, NULL) called at [<phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php:283] #1 PhabricatorEditorURIEngine::escapeToken(NULL) called at [<phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php:144] #2 PhabricatorEditorURIEngine::newURITokensForRepository() called at [<phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php:128] #3 PhabricatorEditorURIEngine::getURITokensForRepository(string) called at [<phorge>/src/infrastructure/editor/PhabricatorEditorURIEngine.php:84] #4 PhabricatorEditorURIEngine::getURITokensForPath(string) called at [<phorge>/src/applications/differential/view/DifferentialChangesetDetailView.php:371] #5 DifferentialChangesetDetailView::getEditorURITemplate() called at [<phorge>/src/applications/differential/view/DifferentialChangesetDetailView.php:272] #6 DifferentialChangesetDetailView::render() called at [<phorge>/src/applications/differential/view/DifferentialChangesetListView.php:240] #7 DifferentialChangesetListView::render() called at [<phorge>/src/view/AphrontView.php:222] #8 AphrontView::producePhutilSafeHTML() called at [<phorge>/src/infrastructure/markup/render.php:115] #9 phutil_escape_html(DifferentialChangesetListView) called at [<phorge>/src/infrastructure/markup/render.php:139] #10 phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:139] #11 phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:97] #12 phutil_tag(string, array, array) called at [<phorge>/src/view/phui/PHUITwoColumnView.php:236] #13 PHUITwoColumnView::buildFooter() called at [<phorge>/src/view/phui/PHUITwoColumnView.php:123] #14 PHUITwoColumnView::getTagContent() called at [<phorge>/src/view/AphrontTagView.php:161] #15 AphrontTagView::render() called at [<phorge>/src/view/AphrontView.php:222] #16 AphrontView::producePhutilSafeHTML() called at [<phorge>/src/infrastructure/markup/render.php:115] #17 phutil_escape_html(PHUITwoColumnView) called at [<phorge>/src/infrastructure/markup/render.php:139] #18 phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:139] #19 phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:97] #20 phutil_tag(string, array, array) called at [<phorge>/src/view/formation/PHUIFormationContentView.php:13] #21 PHUIFormationContentView::render() called at [<phorge>/src/view/AphrontView.php:222] #22 AphrontView::producePhutilSafeHTML() called at [<phorge>/src/infrastructure/markup/render.php:115] #23 phutil_escape_html(PHUIFormationContentView) called at [<phorge>/src/infrastructure/markup/render.php:139] #24 phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:97] #25 phutil_tag(string, array, array) called at [<phorge>/src/view/formation/PHUIFormationView.php:58] #26 PHUIFormationView::render() called at [<phorge>/src/view/AphrontView.php:222] #27 AphrontView::producePhutilSafeHTML() called at [<phorge>/src/infrastructure/markup/render.php:115] #28 phutil_escape_html(PHUIFormationView) called at [<phorge>/src/infrastructure/markup/render.php:171] #29 phutil_implode_html(string, array) called at [<phorge>/src/view/page/PhabricatorBarePageView.php:58] #30 PhabricatorBarePageView::willRenderPage() called at [<phorge>/src/view/page/PhabricatorStandardPageView.php:217] #31 PhabricatorStandardPageView::willRenderPage() called at [<phorge>/src/view/page/AphrontPageView.php:46] #32 AphrontPageView::render() called at [<phorge>/src/view/page/PhabricatorStandardPageView.php:918] #33 PhabricatorStandardPageView::produceAphrontResponse() called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:724] #34 AphrontApplicationConfiguration::produceResponse(AphrontRequest, PhabricatorStandardPageView) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:299] #35 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:203] #36 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35]
aklapper added a comment to D26034: Fix PHP 8.1 "strlen(null)" exception in Client ID handling of PhabricatorOAuthServerTokenController.
Thanks! Oh true I was forget the default fallback option... ah well I guess not a huge difference performance wise plus null feels cleaner to me :)
aklapper added a comment to D26035: Remove unused functions in PhabricatorFulltextToken.
I'd love to have Phorge skip common words and short words though.
So maybe keeping these functions could even make sense so future improvements could call them?
aklapper requested review of D26035: Remove unused functions in PhabricatorFulltextToken.
aklapper added a comment to Q182: Deprecation warnings with PHP 8.3.
Hi, thanks a lot for sharing this! I assume you are running 2024.35 and not yet 2025.18.
You shared seven issues above.
- The first issue is unresolved T15824.
- The second issue has not been reported yet about https://we.phorge.it/source/phorge/browse/master/src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php$26, I may write/propose a patch later once finishing some other work.
- The last five issues were fixed by rP372316c998362e3530c0e591fe0869e6a7e62af6.
Wed, May 28
Wed, May 28
aklapper updated the summary of D26000: Remove orphan CSS selectors in calendar/phui-calendar.css.
aklapper added a comment to D26000: Remove orphan CSS selectors in calendar/phui-calendar.css.
aklapper updated the summary of D25992: Remove unused anchor-target CSS for Conpherence message pane.
aklapper updated the diff for D25992: Remove unused anchor-target CSS for Conpherence message pane.
remove unused CSS as it's also unhelpful CSS when actually used
aklapper retitled D25992: Remove unused anchor-target CSS for Conpherence message pane from Conpherence message pane CSS: Fix typo in selector name
aklapper planned changes to D25992: Remove unused anchor-target CSS for Conpherence message pane.
These selectors currently do not get applied at all in Conpherence rooms when opening or creating URIs with anchors.
Tue, May 27
Tue, May 27
aklapper updated the diff for D25998: Remove orphan CSS selectors in base/main-menu-view.css.
git rebase master
aklapper updated the diff for D26028: Explain consequences when adding second Multi-Factor Auth.
Not really what we expected, but nice try
aklapper updated the diff for D26033: Search-related PhpDoc additions.
@param loves $name
aklapper requested review of D26033: Search-related PhpDoc additions.
aklapper updated the summary of D26026: Add a Before-Destruction Engine.
aklapper added a comment to T15903: Logged exceptions/errors should ignore user's language setting and be always in English.
Mon, May 26
Mon, May 26
aklapper added a comment to D26032: Mark policy transactions of Conduit-created new tasks as such to fix empty Feed transaction entries.
aklapper added inline comments to D26026: Add a Before-Destruction Engine.
valerio.bozzolan awarded T16085: PHP 8.1 "strncmp(null)" exception in transaction log for policy changes a Yellow Medal token.
Sun, May 25
Sun, May 25
Some small nitpicks only. Makes sense to me, didn't spot any logic flaws, keeps close to already existing code in that very directory
aklapper added a comment to D26032: Mark policy transactions of Conduit-created new tasks as such to fix empty Feed transaction entries.
Feed before applying the patch (T3922) and after applying the patch (T3923):
aklapper added a comment to T16085: PHP 8.1 "strncmp(null)" exception in transaction log for policy changes.
getIsCreateTransaction() should return true here but it doesn't.
I believe that this underlying problem can also trigger an exception, see https://phabricator.wikimedia.org/T361459
aklapper closed T16059: Remove -webkit-font-smoothing and -moz-osx-font-smoothing from CSS as Resolved by committing rP555e569ff8c4: Remove macOS specific font smoothing CSS.
Sat, May 24
Sat, May 24
aklapper updated the diff for D25989: Remove macOS specific font smoothing CSS.
git rebase master
aklapper updated the test plan for D26031: Allow using PCRE's just-in-time compilation.
aklapper requested review of D26031: Allow using PCRE's just-in-time compilation.