- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jun 8 2023
Jun 7 2023
@speck: Could you file a separate task please, as this task is only about making existing code not throw an exception under PHP8, while you seem to target workflows not functioning as expected? Thanks! :)
Would it make sense to put creating identities behind the existing Edit policy of the repository?
Jun 4 2023
Jun 3 2023
Cannot properly test locally (too many exceptions on PHP8.2 trying to create a local Git repo and commits to be indexed in Diffusion) how much this change would actually affect both editing and creating (or not) so I dumped an untested patch into P13
Ran ./scripts/celerity/generate_sprites.php and ./bin/celerity map
Fix broken code
It this a test?
No but you found a mistake. :) Calling getUTF8StringFromStorage($string, $encoding) both (!) parameters are null - see the second exception about line 298. Thus I initially replaced the strlen call in line 298 but then realized that mb_detect_encoding accepts the second parameter to be null. Still passed but probably only because I had already changed line 293 so this wasn't reached anymore, sigh. So the correct change would be updating line 298 indeed, uhm.
Jun 2 2023
Patch merged thus resolving
This now partially overlaps with D25269
May 31 2023
Use $raw_query !== null as requested
use a simple $symbol === null check as requested
May 30 2023
Make check in getUpcomingInput() also cover string "0" (as requested by valerio.bozzolan)
Use strict mode
Uh neat. Thanks for that testing!