Page MenuHomePhorge
Feed Advanced Search

Jun 8 2023

aklapper closed T15447: PHP 8.1 "strlen(null)" exception viewing branches of non-existing Hg repo, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 8 2023, 08:32 · PHP 8 support
aklapper closed T15447: PHP 8.1 "strlen(null)" exception viewing branches of non-existing Hg repo as Resolved by committing rPb3894bc2c62f: Fix PHP 8.1 "strlen(null)" exception viewing branches of non-existing Hg repo.
Jun 8 2023, 08:32 · PHP 8 support
aklapper closed D25279: Fix PHP 8.1 "strlen(null)" exception viewing branches of non-existing Hg repo.
Jun 8 2023, 08:32
aklapper committed rPb3894bc2c62f: Fix PHP 8.1 "strlen(null)" exception viewing branches of non-existing Hg repo.
Fix PHP 8.1 "strlen(null)" exception viewing branches of non-existing Hg repo
Jun 8 2023, 08:32
aklapper closed T15446: PHP 8.1 "strlen(null)" exception on SVN repo page with no branches as Resolved by committing rP66dd1c35d820: Fix PHP 8.1 "strlen(null)" exception on SVN repo page with no branches.
Jun 8 2023, 08:31 · PHP 8 support
aklapper closed T15446: PHP 8.1 "strlen(null)" exception on SVN repo page with no branches, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 8 2023, 08:31 · PHP 8 support
aklapper closed D25278: Fix PHP 8.1 "strlen(null)" exception on SVN repo page with no branches.
Jun 8 2023, 08:31
aklapper committed rP66dd1c35d820: Fix PHP 8.1 "strlen(null)" exception on SVN repo page with no branches.
Fix PHP 8.1 "strlen(null)" exception on SVN repo page with no branches
Jun 8 2023, 08:31
aklapper closed T15444: PHP 8.1 "strlen(null)" exception setting a Diffusion repo URI when diffusion.ssh-host is null, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 8 2023, 08:30 · PHP 8 support
aklapper closed T15444: PHP 8.1 "strlen(null)" exception setting a Diffusion repo URI when diffusion.ssh-host is null as Resolved by committing rP1028eb3ee966: Fix PHP 8.1 "strlen(null)" exception setting a Diffusion repo URI when….
Jun 8 2023, 08:30 · PHP 8 support
aklapper closed D25273: Fix PHP 8.1 "strlen(null)" exception setting a Diffusion repo URI when diffusion.ssh-host is null.
Jun 8 2023, 08:30
aklapper committed rP1028eb3ee966: Fix PHP 8.1 "strlen(null)" exception setting a Diffusion repo URI when….
Fix PHP 8.1 "strlen(null)" exception setting a Diffusion repo URI when…
Jun 8 2023, 08:30

Jun 7 2023

aklapper added a comment to T15440: PHP 8.1 strlen(null) and mb_detect_encoding(null) exceptions creating a Diffusion Identity without entering assignee.

@speck: Could you file a separate task please, as this task is only about making existing code not throw an exception under PHP8, while you seem to target workflows not functioning as expected? Thanks! :)

Jun 7 2023, 13:55 · PHP 8 support
aklapper added a comment to T15443: Add Diffusion policy capability "Can Edit and View Identities".

Would it make sense to put creating identities behind the existing Edit policy of the repository?

Jun 7 2023, 11:32 · Diffusion, Policy

Jun 4 2023

aklapper requested review of D25279: Fix PHP 8.1 "strlen(null)" exception viewing branches of non-existing Hg repo.
Jun 4 2023, 10:49
aklapper added a revision to T15447: PHP 8.1 "strlen(null)" exception viewing branches of non-existing Hg repo: D25279: Fix PHP 8.1 "strlen(null)" exception viewing branches of non-existing Hg repo.
Jun 4 2023, 10:49 · PHP 8 support
aklapper created T15447: PHP 8.1 "strlen(null)" exception viewing branches of non-existing Hg repo.
Jun 4 2023, 10:48 · PHP 8 support
aklapper requested review of D25278: Fix PHP 8.1 "strlen(null)" exception on SVN repo page with no branches.
Jun 4 2023, 10:00
aklapper added a revision to T15446: PHP 8.1 "strlen(null)" exception on SVN repo page with no branches: D25278: Fix PHP 8.1 "strlen(null)" exception on SVN repo page with no branches.
Jun 4 2023, 10:00 · PHP 8 support
aklapper created T15446: PHP 8.1 "strlen(null)" exception on SVN repo page with no branches.
Jun 4 2023, 09:59 · PHP 8 support
aklapper requested review of D25277: PHP 8.1 "strlen(null)" exception on SVN History page after changing "Import Only".
Jun 4 2023, 09:51
aklapper added a revision to T15445: PHP 8.1 "strlen(null)" exception on SVN History page after changing "Import Only": D25277: PHP 8.1 "strlen(null)" exception on SVN History page after changing "Import Only".
Jun 4 2023, 09:51 · PHP 8 support
aklapper created T15445: PHP 8.1 "strlen(null)" exception on SVN History page after changing "Import Only".
Jun 4 2023, 09:50 · PHP 8 support

Jun 3 2023

aklapper requested review of D25273: Fix PHP 8.1 "strlen(null)" exception setting a Diffusion repo URI when diffusion.ssh-host is null.
Jun 3 2023, 12:22
aklapper added a revision to T15444: PHP 8.1 "strlen(null)" exception setting a Diffusion repo URI when diffusion.ssh-host is null: D25273: Fix PHP 8.1 "strlen(null)" exception setting a Diffusion repo URI when diffusion.ssh-host is null.
Jun 3 2023, 12:22 · PHP 8 support
aklapper created T15444: PHP 8.1 "strlen(null)" exception setting a Diffusion repo URI when diffusion.ssh-host is null.
Jun 3 2023, 12:20 · PHP 8 support
aklapper added a comment to T15443: Add Diffusion policy capability "Can Edit and View Identities".

Cannot properly test locally (too many exceptions on PHP8.2 trying to create a local Git repo and commits to be indexed in Diffusion) how much this change would actually affect both editing and creating (or not) so I dumped an untested patch into P13

Jun 3 2023, 12:07 · Diffusion, Policy
aklapper created P13 T15443.
Jun 3 2023, 12:06
aklapper updated the diff for D25255: Correct Phorge icon on Auth Provider page.

Ran ./scripts/celerity/generate_sprites.php and ./bin/celerity map

Jun 3 2023, 11:18
aklapper retitled D25271: Fix PHP 8.1 "strlen(null)" exceptions creating a Diffusion Identity without entering assignee from Fix PHP 8.1 exceptions creating a Diffusion Identity without entering assignee
Jun 3 2023, 10:29
aklapper updated the diff for D25271: Fix PHP 8.1 "strlen(null)" exceptions creating a Diffusion Identity without entering assignee.

Fix broken code

Jun 3 2023, 10:18
aklapper added a comment to D25271: Fix PHP 8.1 "strlen(null)" exceptions creating a Diffusion Identity without entering assignee.

It this a test?

No but you found a mistake. :) Calling getUTF8StringFromStorage($string, $encoding) both (!) parameters are null - see the second exception about line 298. Thus I initially replaced the strlen call in line 298 but then realized that mb_detect_encoding accepts the second parameter to be null. Still passed but probably only because I had already changed line 293 so this wasn't reached anymore, sigh. So the correct change would be updating line 298 indeed, uhm.

Jun 3 2023, 10:15
aklapper closed T15441: PHP 8.1 "strlen(null)" exception on UIExamples' Bars page, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 3 2023, 09:51 · PHP 8 support
aklapper closed T15441: PHP 8.1 "strlen(null)" exception on UIExamples' Bars page as Resolved by committing rPd8d65f3f87ed: Fix PHP 8.1 "strlen(null)" exception on UIExamples' Bars page.
Jun 3 2023, 09:51 · PHP 8 support
aklapper closed D25272: Fix PHP 8.1 "strlen(null)" exception on UIExamples' Bars page.
Jun 3 2023, 09:51
aklapper committed rPd8d65f3f87ed: Fix PHP 8.1 "strlen(null)" exception on UIExamples' Bars page.
Fix PHP 8.1 "strlen(null)" exception on UIExamples' Bars page
Jun 3 2023, 09:50
aklapper added a project to T15443: Add Diffusion policy capability "Can Edit and View Identities": Policy.
Jun 3 2023, 09:47 · Diffusion, Policy
valerio.bozzolan awarded T15438: Add policy capability "Can create Dashboards" a Mountain of Wealth token.
Jun 3 2023, 09:45 · Dashboards, Policy
aklapper created T15443: Add Diffusion policy capability "Can Edit and View Identities".
Jun 3 2023, 09:19 · Diffusion, Policy
aklapper updated the task description for T15441: PHP 8.1 "strlen(null)" exception on UIExamples' Bars page.
Jun 3 2023, 09:15 · PHP 8 support

Jun 2 2023

aklapper requested review of D25272: Fix PHP 8.1 "strlen(null)" exception on UIExamples' Bars page.
Jun 2 2023, 19:20
aklapper added a revision to T15441: PHP 8.1 "strlen(null)" exception on UIExamples' Bars page: D25272: Fix PHP 8.1 "strlen(null)" exception on UIExamples' Bars page.
Jun 2 2023, 19:20 · PHP 8 support
aklapper created T15441: PHP 8.1 "strlen(null)" exception on UIExamples' Bars page.
Jun 2 2023, 19:19 · PHP 8 support
aklapper closed T15430: PHP 8.1 "strlen(null)" exceptions block creating a diff in Differential web interface, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 2 2023, 18:40 · PHP 8 support
aklapper closed T15430: PHP 8.1 "strlen(null)" exceptions block creating a diff in Differential web interface as Resolved by committing rPdd24c94b0741: Fix PHP 8.1 "strlen(null)" exceptions block creating a diff in Differential web….
Jun 2 2023, 18:40 · PHP 8 support
aklapper closed D25262: Fix PHP 8.1 "strlen(null)" exceptions block creating a diff in Differential web interface.
Jun 2 2023, 18:40
aklapper committed rPdd24c94b0741: Fix PHP 8.1 "strlen(null)" exceptions block creating a diff in Differential web….
Fix PHP 8.1 "strlen(null)" exceptions block creating a diff in Differential web…
Jun 2 2023, 18:40
aklapper closed T15414: PHP 8.1 "strlen(null)" exceptions trying to View Branches of a Diffusion repository, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 2 2023, 18:05 · PHP 8 support
aklapper closed T15414: PHP 8.1 "strlen(null)" exceptions trying to View Branches of a Diffusion repository as Resolved by committing rP0cbcb110b03b: Fix PHP 8.1 "strlen(null)" exceptions trying to View Branches of a Diffusion….
Jun 2 2023, 18:05 · PHP 8 support
aklapper closed D25241: Fix PHP 8.1 "strlen(null)" exceptions trying to View Branches of a Diffusion repository.
Jun 2 2023, 18:05
aklapper committed rP0cbcb110b03b: Fix PHP 8.1 "strlen(null)" exceptions trying to View Branches of a Diffusion….
Fix PHP 8.1 "strlen(null)" exceptions trying to View Branches of a Diffusion…
Jun 2 2023, 18:05
aklapper updated the summary of D25241: Fix PHP 8.1 "strlen(null)" exceptions trying to View Branches of a Diffusion repository.
Jun 2 2023, 18:04
aklapper requested review of D25271: Fix PHP 8.1 "strlen(null)" exceptions creating a Diffusion Identity without entering assignee.
Jun 2 2023, 17:58
aklapper added a revision to T15440: PHP 8.1 strlen(null) and mb_detect_encoding(null) exceptions creating a Diffusion Identity without entering assignee: D25271: Fix PHP 8.1 "strlen(null)" exceptions creating a Diffusion Identity without entering assignee.
Jun 2 2023, 17:58 · PHP 8 support
aklapper created T15440: PHP 8.1 strlen(null) and mb_detect_encoding(null) exceptions creating a Diffusion Identity without entering assignee.
Jun 2 2023, 17:57 · PHP 8 support
aklapper created T15439: AphrontQueryException creating a Diffusion Identity without entering assignee.
Jun 2 2023, 17:57
aklapper closed T15346: PHP 8.1 exceptions in JsonLint block rendering Tab Panels in Dashboards, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
Jun 2 2023, 16:31 · PHP 8 support
aklapper closed T15346: PHP 8.1 exceptions in JsonLint block rendering Tab Panels in Dashboards as Resolved by committing rARCb325304b6e52: Fix PHP 8.1 null exceptions which block rendering tab panels on dashboards.
Jun 2 2023, 16:31 · Arcanist, PHP 8 support
aklapper closed D25250: Fix PHP 8.1 null exceptions which block rendering tab panels on dashboards.
Jun 2 2023, 16:31
aklapper committed rARCb325304b6e52: Fix PHP 8.1 null exceptions which block rendering tab panels on dashboards.
Fix PHP 8.1 null exceptions which block rendering tab panels on dashboards
Jun 2 2023, 16:31
aklapper closed T15146: Dashboards: Tab panel sometimes displays the content of two tabs as Resolved.

Patch merged thus resolving

Jun 2 2023, 16:28 · Dashboards, Bug Reports
aklapper updated the test plan for D25270: Dashboards: add capability who can create Dashboards.
Jun 2 2023, 16:18
aklapper requested review of D25270: Dashboards: add capability who can create Dashboards.
Jun 2 2023, 16:16
aklapper added a revision to T15438: Add policy capability "Can create Dashboards": D25270: Dashboards: add capability who can create Dashboards.
Jun 2 2023, 16:16 · Dashboards, Policy
aklapper created T15438: Add policy capability "Can create Dashboards".
Jun 2 2023, 16:15 · Dashboards, Policy
aklapper added a comment to D25250: Fix PHP 8.1 null exceptions which block rendering tab panels on dashboards.

This now partially overlaps with D25269

Jun 2 2023, 07:38

May 31 2023

aklapper created T15436: "TypeError: config.datasets is undefined" in Facts when logged out.
May 31 2023, 15:56 · Bug Reports
aklapper closed T15435: PHP 8.1 "preg_match(null)" exception cloning a repository with no URI set, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 31 2023, 07:40 · PHP 8 support
aklapper closed T15435: PHP 8.1 "preg_match(null)" exception cloning a repository with no URI set as Resolved by committing rP6b8ec5014890: Fix PHP 8.1 "preg_match(null)" exception when cloning a repository with no URI….
May 31 2023, 07:40 · PHP 8 support
aklapper closed D25266: Fix PHP 8.1 "preg_match(null)" exception when cloning a repository with no URI set.
May 31 2023, 07:40
aklapper committed rP6b8ec5014890: Fix PHP 8.1 "preg_match(null)" exception when cloning a repository with no URI….
Fix PHP 8.1 "preg_match(null)" exception when cloning a repository with no URI…
May 31 2023, 07:40
aklapper closed T15422: PHP 8.1 "preg_match(null)" exception blocks rendering the "Browse Herald Rules" dialog, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
May 31 2023, 07:38 · PHP 8 support
aklapper closed T15422: PHP 8.1 "preg_match(null)" exception blocks rendering the "Browse Herald Rules" dialog as Resolved by committing rP1dd9609beddb: Fix PHP 8.1 "preg_match(null)" exception which blocks rendering the "Browse….
May 31 2023, 07:38 · PHP 8 support
aklapper closed D25248: Fix PHP 8.1 "preg_match(null)" exception which blocks rendering the "Browse Herald Rules" dialog.
May 31 2023, 07:38
aklapper committed rP1dd9609beddb: Fix PHP 8.1 "preg_match(null)" exception which blocks rendering the "Browse….
Fix PHP 8.1 "preg_match(null)" exception which blocks rendering the "Browse…
May 31 2023, 07:38
aklapper retitled D25248: Fix PHP 8.1 "preg_match(null)" exception which blocks rendering the "Browse Herald Rules" dialog from Fix PHP 8.1 "strlen(null)" exception which blocks rendering the "Browse Herald Rules" dialog
May 31 2023, 07:37
aklapper renamed T15422: PHP 8.1 "preg_match(null)" exception blocks rendering the "Browse Herald Rules" dialog from PHP 8.1 "strlen(null)" exception blocks rendering the "Browse Herald Rules" dialog to PHP 8.1 "preg_match(null)" exception blocks rendering the "Browse Herald Rules" dialog.
May 31 2023, 07:36 · PHP 8 support
aklapper updated the diff for D25248: Fix PHP 8.1 "preg_match(null)" exception which blocks rendering the "Browse Herald Rules" dialog.

Use $raw_query !== null as requested

May 31 2023, 06:05
aklapper updated the diff for D25266: Fix PHP 8.1 "preg_match(null)" exception when cloning a repository with no URI set.

use a simple $symbol === null check as requested

May 31 2023, 06:01

May 30 2023

aklapper requested review of D25266: Fix PHP 8.1 "preg_match(null)" exception when cloning a repository with no URI set.
May 30 2023, 18:29
aklapper added a revision to T15435: PHP 8.1 "preg_match(null)" exception cloning a repository with no URI set: D25266: Fix PHP 8.1 "preg_match(null)" exception when cloning a repository with no URI set.
May 30 2023, 18:29 · PHP 8 support
aklapper created T15435: PHP 8.1 "preg_match(null)" exception cloning a repository with no URI set.
May 30 2023, 18:28 · PHP 8 support
aklapper requested review of D25265: Fix PHP 8.1 "strlen(null)" exception on History page of Diffusion repo after renaming default branch.
May 30 2023, 18:16
aklapper added a revision to T15434: PHP 8.1 "strlen(null)" exception on History page of Diffusion repo after renaming default branch: D25265: Fix PHP 8.1 "strlen(null)" exception on History page of Diffusion repo after renaming default branch.
May 30 2023, 18:16 · PHP 8 support
aklapper created T15434: PHP 8.1 "strlen(null)" exception on History page of Diffusion repo after renaming default branch.
May 30 2023, 18:15 · PHP 8 support
aklapper updated the summary of D25240: Fix PHP 8.1 "strlen(null)" exception which blocks rendering errors on Create Blueprint page.
May 30 2023, 14:59
aklapper updated the summary of D25248: Fix PHP 8.1 "preg_match(null)" exception which blocks rendering the "Browse Herald Rules" dialog.
May 30 2023, 14:58
aklapper updated the summary of D25258: Fix PHP 8.1 "base64_decode(null)" exception calling Conduit's file.upload with no data passed.
May 30 2023, 14:57
aklapper updated the summary of D25259: Fix PHP 8.1 "trim(null)" exception which blocks rendering Conduit's harbormaster.sendmessage page.
May 30 2023, 14:57
valerio.bozzolan awarded D25249: Fix PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding a Mountain of Wealth token.
May 30 2023, 13:28
aklapper updated the diff for D25250: Fix PHP 8.1 null exceptions which block rendering tab panels on dashboards.

Make check in getUpcomingInput() also cover string "0" (as requested by valerio.bozzolan)

May 30 2023, 11:27
aklapper updated the diff for D25249: Fix PHP 8.0 ValueError calling mb_convert_encoding() with an invalid encoding.

Use strict mode

May 30 2023, 11:24
aklapper updated the diff for D25240: Fix PHP 8.1 "strlen(null)" exception which blocks rendering errors on Create Blueprint page.

Uh neat. Thanks for that testing!

May 30 2023, 11:16
aklapper requested review of D25264: Fix some PHP 8.1 "strlen(null)" exceptions on Differential Revision page.
May 30 2023, 11:05
aklapper added a revision to T15432: PHP 8.1 "strlen(null)" exceptions block rendering Differential Revision page: D25264: Fix some PHP 8.1 "strlen(null)" exceptions on Differential Revision page.
May 30 2023, 11:05 · PHP 8 support
aklapper created T15432: PHP 8.1 "strlen(null)" exceptions block rendering Differential Revision page.
May 30 2023, 10:59 · PHP 8 support
aklapper requested review of D25263: Fix PHP 8.1 "preg_match(null)" exception on "Create Revision" page in Differential when not entering data.
May 30 2023, 10:35
aklapper added a revision to T15431: PHP 8.1 "preg_match(null)" exception blocks rendering "Create Revision" page in Differential: D25263: Fix PHP 8.1 "preg_match(null)" exception on "Create Revision" page in Differential when not entering data.
May 30 2023, 10:35 · PHP 8 support
aklapper created T15431: PHP 8.1 "preg_match(null)" exception blocks rendering "Create Revision" page in Differential.
May 30 2023, 10:34 · PHP 8 support
aklapper requested review of D25262: Fix PHP 8.1 "strlen(null)" exceptions block creating a diff in Differential web interface.
May 30 2023, 10:22