PHP 8.1 "preg_match(null)" exception blocks rendering "Create Revision" page in Differential
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	aklapper
	May 30 2023, 10:34

Description

PHP 8.2.6; Phorge at e11c5486c92bd75895eda4e0d905d8e49c0f68b1 with D25262 on top
Go to Differential at http://phorge.localhost/differential/
Select Create Diff in upper right corner to go to http://phorge.localhost/differential/diff/create/
In the Raw Diff field, paste content of a valid diff file (e.g. starting with diff --git a/a.php b/b.php)
Select Create Diff button at the bottom
Select Continue button to go to Create Revision page on http://phorge.localhost/differential/revision/attach/4/to/
Do not enter any data, select Create New Revision button

[2023-05-30 10:26:44] EXCEPTION: (RuntimeException) preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=master, ref.master=18554ea76ceb), phorge(head=diffAttach, ref.master=e11c5486c92b, ref.diffAttach=e11c5486c92b)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<arcanist>/src/error/PhutilErrorHandler.php:261]
  #1 <#2> preg_match(string, NULL, NULL) called at [<phorge>/src/applications/differential/editor/DifferentialTransactionEditor.php:221]
  #2 <#2> DifferentialTransactionEditor::expandTransaction(DifferentialRevision, DifferentialTransaction) called at [<phorge>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:2174]
  #3 <#2> PhabricatorApplicationTransactionEditor::expandTransactions(DifferentialRevision, array) called at [<phorge>/src/applications/differential/editor/DifferentialTransactionEditor.php:149]
  #4 <#2> DifferentialTransactionEditor::expandTransactions(DifferentialRevision, array) called at [<phorge>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1221]
  #5 <#2> PhabricatorApplicationTransactionEditor::applyTransactions(DifferentialRevision, array) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1149]
  #6 <#2> PhabricatorEditEngine::buildEditResponse(DifferentialRevision) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1000]
  #7 <#2> PhabricatorEditEngine::buildResponse() called at [<phorge>/src/applications/differential/controller/DifferentialRevisionEditController.php:53]
  #8 <#2> DifferentialRevisionEditController::handleRequest(AphrontRequest) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:284]
  #9 phlog(RuntimeException) called at [<phorge>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:41]
  #10 PhabricatorDefaultRequestExceptionHandler::handleRequestThrowable(AphrontRequest, RuntimeException) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:751]
  #11 AphrontApplicationConfiguration::handleThrowable(RuntimeException) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:296]
  #12 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:203]
  #13 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35]
[2023-05-30 10:26:44] EXCEPTION: (PhutilAggregateException) Encountered a processing exception, then another exception when trying to build a response for the first exception.
    - RuntimeException: file_exists(): Passing null to parameter #1 ($filename) of type string is deprecated
    - RuntimeException: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:316]
arcanist(head=master, ref.master=18554ea76ceb), phorge(head=diffAttach, ref.master=e11c5486c92b, ref.diffAttach=e11c5486c92b)
  #0 <#4> preg_match(string, NULL, NULL) called at [<phorge>/src/applications/differential/editor/DifferentialTransactionEditor.php:221]
  #1 <#4> DifferentialTransactionEditor::expandTransaction(DifferentialRevision, DifferentialTransaction) called at [<phorge>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:2174]
  #2 <#4> PhabricatorApplicationTransactionEditor::expandTransactions(DifferentialRevision, array) called at [<phorge>/src/applications/differential/editor/DifferentialTransactionEditor.php:149]
  #3 <#4> DifferentialTransactionEditor::expandTransactions(DifferentialRevision, array) called at [<phorge>/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php:1221]
  #4 <#4> PhabricatorApplicationTransactionEditor::applyTransactions(DifferentialRevision, array) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1149]
  #5 <#4> PhabricatorEditEngine::buildEditResponse(DifferentialRevision) called at [<phorge>/src/applications/transactions/editengine/PhabricatorEditEngine.php:1000]
  #6 <#4> PhabricatorEditEngine::buildResponse() called at [<phorge>/src/applications/differential/controller/DifferentialRevisionEditController.php:53]
  #7 <#4> DifferentialRevisionEditController::handleRequest(AphrontRequest) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:284]
  #8 <#3> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<arcanist>/src/error/PhutilErrorHandler.php:261]
  #9 <#3> file_exists(NULL) called at [<arcanist>/src/filesystem/Filesystem.php:1068]
  #10 <#3> Filesystem::pathExists(NULL) called at [<arcanist>/src/filesystem/Filesystem.php:1169]
  #11 <#3> Filesystem::assertExists(NULL) called at [<arcanist>/src/filesystem/Filesystem.php:1020]
  #12 <#3> Filesystem::isDescendant(NULL, string) called at [<phorge>/src/view/widget/AphrontStackTraceView.php:33]
  #13 <#3> AphrontStackTraceView::render() called at [<phorge>/src/view/AphrontView.php:222]
  #14 <#3> AphrontView::producePhutilSafeHTML() called at [<phorge>/src/infrastructure/markup/render.php:115]
  #15 <#3> phutil_escape_html(AphrontStackTraceView) called at [<phorge>/src/infrastructure/markup/render.php:139]
  #16 <#3> phutil_escape_html(array) called at [<phorge>/src/infrastructure/markup/render.php:97]
  #17 <#3> phutil_tag(string, array, array) called at [<phorge>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:62]
  #18 <#3> PhabricatorDefaultRequestExceptionHandler::handleRequestThrowable(AphrontRequest, RuntimeException) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:751]
  #19 <#3> AphrontApplicationConfiguration::handleThrowable(RuntimeException) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:296]
  #20 <#2> AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:203]
  #21 <#2> AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35]
  #22 phlog(PhutilAggregateException) called at [<phorge>/src/aphront/response/AphrontUnhandledExceptionResponse.php:32]
  #23 AphrontUnhandledExceptionResponse::setException(PhutilAggregateException) called at [<phorge>/webroot/index.php:46]

Revisions and Commits

rP Phorge
	D25263	rP44a8a1c408ed Fix PHP 8.1 "preg_match(null)" exception on "Create Revision" page in…

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Open	None	T15064 Make Phorge compatible with PHP 8.1/8.2/8.3/8.4
Resolved	aklapper	T15431 PHP 8.1 "preg_match(null)" exception blocks rendering "Create Revision" page in Differential
		· · ·