Fix PHP 8.1 "strlen(null)" exception setting a Diffusion repo URI when diffusion.ssh-host is null
ClosedPublic
Actions

Authored by aklapper on Jun 3 2023, 12:22.

Details

Reviewers

speck

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15444: PHP 8.1 "strlen(null)" exception setting a Diffusion repo URI when diffusion.ssh-host is null

Commits

rP1028eb3ee966: Fix PHP 8.1 "strlen(null)" exception setting a Diffusion repo URI when…

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=master, ref.master=b325304b6e52), phorge(head=diffusionCreateRepoURI, ref.master=d8d65f3f87ed, ref.diffusionCreateRepoURI=d8d65f3f87ed)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/repository/storage/PhabricatorRepositoryURI.php:755]

Closes T15444

Test Plan

After applying this change and setting a repo URI following the steps in T15444, the page "R10: URI 58" on /diffusion/10/uri/view/58/ is correctly rendered without an exception.