Thanks. Moreover, looking at PhutilKeyValueCache it seems that setKey(null) has no sense. So thanks also for that extra care you already set.

Hi bekay, thanks for looking into this, very appreciated!

There is no reason to expose "Manage" for admins only. I'm abandoning this in favor of D25687.

I will then need a rebase for D25363

Could you clarify if this is only supposed to work for import an .ics URI and not for importing a single event via an .ics file? Maybe I'm overcomplicating things, what I tried:

I admit I am quite interested in the changes in src/applications/people/query/PhabricatorPeopleUserEmailQuery.php adding $userPhids and $isVerified as I have a downstream use case for them.
Would be lovely to get them in, nevertheless where the actual calendar feature request is going.

Use PhabricatorMarkupEngine::summarizeSentence() instead of mb_substr().

thanks you

To me it makes sense thanks. Maybe just add a comment somewhere to say that the menu should be automatically generated - T15224

So the "right" fix is to find what creates the current side-menu and make sure we call that, or figuring out why they're different here and normally the same.

So PHP, very wow

Test plan: I finished my ideas. It seems it just works 🤔

In D25685#18805, @avivey wrote:

this menu should have the same content as the side-menu on non-mobile view; And in most places, the framework handles that, by actually moving that menu.
So the "right" fix is to find what creates the current side-menu and make sure we call that, or figuring out why they're different here and normally the same.

As T15224 suggest, this menu should have the same content as the side-menu on non-mobile view; And in most places, the framework handles that, by actually moving that menu.
So the "right" fix is to find what creates the current side-menu and make sure we call that, or figuring out why they're different here and normally the same.

Better than before.

all those tears shed by devastated users after clicking the Calendar menu item

Ah, thanks.

No, it never was called anywhere. Read the HTML comment this commit deletes.

I cannot find getDateTranslations anywhere so I'm having the (probably very stupid) question where this function was called once upon a time (edit: oh well, I now realize it's a test case so I guess this just gets executed when running tests. sigh.).

Add minimal PHPDoc

I proposed two related patches in D25683 and D25685, both of them obsoleted by: D25687.

Maybe a good moment for minimal PHPDoc with

I will update the screenshots. Let's wait another +1 on strings.

Tried to re-phrase a bit, thanks to feedback from Italian coworkers and Andrè. lol

... but it turns out by concidence most of the date elements that are worth translating are already translatable from other references in the code:

// The only purpose of this function is to provide a static list of
// translations which can come from PhutilTranslator::translateDate() to
// allow translation extractor getting them.

I seem to have a bad habit of doing things and realizing they were stupid or I had missed something weeks to months later.

That would probably be a better User-Agent

/settings/panel/multifactor/ requires users to add a custom Name so there is likely code to adapt/reuse for /settings/panel/apitokens/

https://we.phorge.it/source/phorge/browse/master/src/applications/auth/adapter/PhutilGitHubAuthAdapter.php$57-58 uses a boring
$future->addHeader('User-Agent', __CLASS__); for this.

Use consistent CSS scopes. Tested. And really really last change for now. I think.

There may be some room for extra clarity for users in complex organization setups, but this is a rare enough operation (outside of dev) that it's probably not worth worrying about.

I would be find with turning this into "your PlatformSymbols::getPlatformServerName() account" instead if that's seen as clearer but I'm not convinced the platform is necessary here at all. Opinions on that welcome.