Page MenuHomePhorge

Auto-subscription: little less verbose
ClosedPublic

Authored by valerio.bozzolan on May 4 2023, 20:39.
Tags
Referenced Files
F3530212: D25191.1744872104.diff
Wed, Apr 16, 06:41
F3390324: D25191.1744465089.diff
Fri, Apr 11, 13:38
F3367964: D25191.1744204627.diff
Tue, Apr 8, 13:17
F3360995: D25191.1744014240.diff
Sun, Apr 6, 08:24
F3360528: D25191.1743999875.diff
Sun, Apr 6, 04:24
F3358411: D25191.1743923517.diff
Sat, Apr 5, 07:11
F3340088: D25191.1743631030.diff
Tue, Apr 1, 21:57
F3337338: D25191.1743588123.diff
Tue, Apr 1, 10:02
Tokens
"Cup of Joe" token, awarded by bfs.

Details

Summary

When the user "Mrs. Kitten" adds or remove "Mrs. Kitten" as Subscriber,
usually these messages were generated:

Mrs. Kitten added a subscriber: Mrs. Kitten.
Mrs. Kitten removed a subscriber: Mrs. Kitten.

This was a bit like the Spiderman meme self-pointing Spiderman.

After this change, these beautiful messages are generated instead:

Mrs. Kitten subscribed.
Mrs. Kitten unsubscribed.
BeforeAfter
Subscriber messages - Before.png (365×652 px, 61 KB)
Subscriber messages - After.png (365×652 px, 45 KB)

Closes T15347

Test Plan
  • subscribe on something
  • unsubscribe from something
  • all other cases remain as-is

Diff Detail

Repository
rP Phorge
Branch
subscriber-verbosity
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 360
Build 360: arc lint + arc unit

Event Timeline

Yes, for wonderful, WONDERFUL reasons, there was already an isSelfSubscription() function! ✨

bfs subscribed.

Seems reasonable and simple enough. Can we get a Blessed Committer to accept this?

This revision is now accepted and ready to land.Jun 8 2023, 01:11