Page MenuHomePhorge

Auto-subscription: little less verbose
ClosedPublic

Authored by valerio.bozzolan on May 4 2023, 20:39.
Tags
Referenced Files
Unknown Object (File)
Tue, Mar 26, 22:19
Unknown Object (File)
Tue, Mar 26, 22:19
Unknown Object (File)
Tue, Mar 26, 21:24
Unknown Object (File)
Tue, Mar 26, 20:59
Unknown Object (File)
Sun, Mar 24, 06:30
Unknown Object (File)
Wed, Mar 20, 10:34
Unknown Object (File)
Fri, Mar 15, 13:22
Unknown Object (File)
Feb 25 2024, 07:40
Tokens
"Cup of Joe" token, awarded by bfs.

Details

Summary

When the user "Mrs. Kitten" adds or remove "Mrs. Kitten" as Subscriber,
usually these messages were generated:

Mrs. Kitten added a subscriber: Mrs. Kitten.
Mrs. Kitten removed a subscriber: Mrs. Kitten.

This was a bit like the Spiderman meme self-pointing Spiderman.

After this change, these beautiful messages are generated instead:

Mrs. Kitten subscribed.
Mrs. Kitten unsubscribed.
BeforeAfter
Subscriber messages - Before.png (365×652 px, 61 KB)
Subscriber messages - After.png (365×652 px, 45 KB)

Closes T15347

Test Plan
  • subscribe on something
  • unsubscribe from something
  • all other cases remain as-is

Diff Detail

Repository
rP Phorge
Branch
subscriber-verbosity
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 360
Build 360: arc lint + arc unit

Event Timeline

Yes, for wonderful, WONDERFUL reasons, there was already an isSelfSubscription() function! ✨

bfs subscribed.

Seems reasonable and simple enough. Can we get a Blessed Committer to accept this?

This revision is now accepted and ready to land.Jun 8 2023, 01:11