Remove non-existing min-device-pixel-ratio CSS syntax
ClosedPublic
Actions

Authored by aklapper on Fri, Apr 25, 09:53.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPb578854017fc: Remove non-existing min-device-pixel-ratio CSS syntax

Summary

min-device-pixel-ratio/device-pixel-ratio do not exist.

For the records,

Standard min-resolution has been supported since Firefox 16 released 08/2012, Opera 12.1 released 11/2012, Chromium 29 released 07/2013, and Edge 12 released 07/2015
Safari 15.8 released 07/2022 still requires -webkit-min-device-pixel-ratio
Non-standard min--moz-device-pixel-ratio syntax was supported from Firefox 4 to Firefox 15 according to https://developer.mozilla.org/en-US/docs/Web/CSS/@media/-moz-device-pixel-ratio

Test Plan

Run /bin/celerity sprites, check that icons on http://phorge.localhost/auth/config/new/ still render.
Read CSS docs; probably install ancient browser versions if you don't trust documentation.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Fri, Apr 25, 09:53

Owners added a reviewer: O1: Blessed Committers.Fri, Apr 25, 09:53

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFri, Apr 25, 09:53

aklapper requested review of this revision.Fri, Apr 25, 09:53

Harbormaster completed remote builds in B1889: Diff 2918.Fri, Apr 25, 09:53

git rebase master

Harbormaster completed remote builds in B1893: Diff 2924.Fri, Apr 25, 15:56

git rebase master

Harbormaster completed remote builds in B1900: Diff 2936.Mon, Apr 28, 20:58

If the CSS rule should not change anything, why does it change something?

Anyway, I've enlarged all these pictures at 300x, and I'm not able to distinguish any change whatsoever. Plus, I see we are saving ELEVEN Kilobytes. Wow.

Let's unlock this extra computer firepower.

whatcouldgowrong